diff options
Diffstat (limited to 'src')
| -rwxr-xr-x | src/conf_mode/firewall.py | 5 | ||||
| -rwxr-xr-x | src/conf_mode/host_name.py | 5 | ||||
| -rwxr-xr-x | src/conf_mode/igmp_proxy.py | 3 | ||||
| -rwxr-xr-x | src/conf_mode/interfaces-ethernet.py | 5 | ||||
| -rwxr-xr-x | src/conf_mode/interfaces-vxlan.py | 3 | ||||
| -rwxr-xr-x | src/conf_mode/lldp.py | 7 | ||||
| -rwxr-xr-x | src/conf_mode/nat.py | 7 | ||||
| -rwxr-xr-x | src/conf_mode/nat66.py | 7 | ||||
| -rwxr-xr-x | src/conf_mode/policy-route.py | 3 | ||||
| -rwxr-xr-x | src/conf_mode/snmp.py | 5 | ||||
| -rwxr-xr-x | src/conf_mode/tftp_server.py | 5 | 
11 files changed, 33 insertions, 22 deletions
| diff --git a/src/conf_mode/firewall.py b/src/conf_mode/firewall.py index f33198a49..de78d53a8 100755 --- a/src/conf_mode/firewall.py +++ b/src/conf_mode/firewall.py @@ -21,6 +21,7 @@ from glob import glob  from json import loads  from sys import exit +from vyos.base import Warning  from vyos.config import Config  from vyos.configdict import dict_merge  from vyos.configdict import node_changed @@ -225,7 +226,7 @@ def verify_rule(firewall, rule_conf, ipv6):                              raise ConfigError(f'Invalid {error_group} "{group_name}" on firewall rule')                          if not group_obj: -                            print(f'WARNING: {error_group} "{group_name}" has no members') +                            Warning(f'{error_group} "{group_name}" has no members!')              if 'port' in side_conf or dict_search_args(side_conf, 'group', 'port_group'):                  if 'protocol' not in rule_conf: @@ -395,7 +396,7 @@ def resync_policy_route():      # Update policy route as firewall groups were updated      tmp = run(policy_route_conf_script)      if tmp > 0: -        print('Warning: Failed to re-apply policy route configuration') +        Warning('Failed to re-apply policy route configuration!')  def apply(firewall):      if 'first_install' in firewall: diff --git a/src/conf_mode/host_name.py b/src/conf_mode/host_name.py index 87bad0dc6..93f244f42 100755 --- a/src/conf_mode/host_name.py +++ b/src/conf_mode/host_name.py @@ -21,13 +21,14 @@ import copy  import vyos.util  import vyos.hostsd_client -from vyos import ConfigError +from vyos.base import Warning  from vyos.config import Config  from vyos.ifconfig import Section  from vyos.template import is_ip  from vyos.util import cmd  from vyos.util import call  from vyos.util import process_named_running +from vyos import ConfigError  from vyos import airbag  airbag.enable() @@ -113,7 +114,7 @@ def verify(hosts):      for interface, interface_config in hosts['nameservers_dhcp_interfaces'].items():          # Warnin user if interface does not have DHCP or DHCPv6 configured          if not set(interface_config).intersection(['dhcp', 'dhcpv6']): -            print(f'WARNING: "{interface}" is not a DHCP interface but uses DHCP name-server option!') +            Warning(f'"{interface}" is not a DHCP interface but uses DHCP name-server option!')      return None diff --git a/src/conf_mode/igmp_proxy.py b/src/conf_mode/igmp_proxy.py index fb030c9f3..37df3dc92 100755 --- a/src/conf_mode/igmp_proxy.py +++ b/src/conf_mode/igmp_proxy.py @@ -19,6 +19,7 @@ import os  from sys import exit  from netifaces import interfaces +from vyos.base import Warning  from vyos.config import Config  from vyos.configdict import dict_merge  from vyos.template import render @@ -92,7 +93,7 @@ def generate(igmp_proxy):      # bail out early - service is disabled, but inform user      if 'disable' in igmp_proxy: -        print('WARNING: IGMP Proxy will be deactivated because it is disabled') +        Warning('IGMP Proxy will be deactivated because it is disabled')          return None      render(config_file, 'igmp-proxy/igmpproxy.conf.tmpl', igmp_proxy) diff --git a/src/conf_mode/interfaces-ethernet.py b/src/conf_mode/interfaces-ethernet.py index 68f59893a..333d39e0e 100755 --- a/src/conf_mode/interfaces-ethernet.py +++ b/src/conf_mode/interfaces-ethernet.py @@ -19,6 +19,7 @@ import os  from glob import glob  from sys import exit +from vyos.base import Warning  from vyos.config import Config  from vyos.configdict import get_interface_dict  from vyos.configverify import verify_address @@ -142,8 +143,8 @@ def verify(ethernet):              raise ConfigError('XDP requires additional TX queues, too few available!')      if {'is_bond_member', 'mac'} <= set(ethernet): -        print(f'WARNING: changing mac address "{mac}" will be ignored as "{ifname}" ' -              f'is a member of bond "{is_bond_member}"'.format(**ethernet)) +        Warning(f'changing mac address "{mac}" will be ignored as "{ifname}" ' \ +                f'is a member of bond "{is_bond_member}"'.format(**ethernet))      # use common function to verify VLAN configuration      verify_vlan_config(ethernet) diff --git a/src/conf_mode/interfaces-vxlan.py b/src/conf_mode/interfaces-vxlan.py index 0a9b51cac..848112c17 100755 --- a/src/conf_mode/interfaces-vxlan.py +++ b/src/conf_mode/interfaces-vxlan.py @@ -19,6 +19,7 @@ import os  from sys import exit  from netifaces import interfaces +from vyos.base import Warning  from vyos.config import Config  from vyos.configdict import get_interface_dict  from vyos.configdict import leaf_node_changed @@ -78,7 +79,7 @@ def verify(vxlan):          return None      if int(vxlan['mtu']) < 1500: -        print('WARNING: RFC7348 recommends VXLAN tunnels preserve a 1500 byte MTU') +        Warning('RFC7348 recommends VXLAN tunnels preserve a 1500 byte MTU')      if 'group' in vxlan:          if 'source_interface' not in vxlan: diff --git a/src/conf_mode/lldp.py b/src/conf_mode/lldp.py index db8328259..2bb615eb7 100755 --- a/src/conf_mode/lldp.py +++ b/src/conf_mode/lldp.py @@ -18,6 +18,7 @@ import os  from sys import exit +from vyos.base import Warning  from vyos.config import Config  from vyos.configdict import dict_merge  from vyos.validate import is_addr_assigned @@ -84,11 +85,11 @@ def verify(lldp):      if 'management_address' in lldp:          for address in lldp['management_address']: -            message = f'WARNING: LLDP management address "{address}" is invalid' +            message = f'LLDP management address "{address}" is invalid'              if is_loopback_addr(address): -                print(f'{message} - loopback address') +                Warning(f'{message} - loopback address')              elif not is_addr_assigned(address): -                print(f'{message} - not assigned to any interface') +                Warning(f'{message} - not assigned to any interface')      if 'interface' in lldp:          for interface, interface_config in lldp['interface'].items(): diff --git a/src/conf_mode/nat.py b/src/conf_mode/nat.py index 14ca7bc94..8aaebf9ff 100755 --- a/src/conf_mode/nat.py +++ b/src/conf_mode/nat.py @@ -23,6 +23,7 @@ from platform import release as kernel_version  from sys import exit  from netifaces import interfaces +from vyos.base import Warning  from vyos.config import Config  from vyos.configdict import dict_merge  from vyos.template import render @@ -142,14 +143,14 @@ def verify(nat):                  raise ConfigError(f'{err_msg} outbound-interface not specified')              if config['outbound_interface'] not in 'any' and config['outbound_interface'] not in interfaces(): -                print(f'WARNING: rule "{rule}" interface "{config["outbound_interface"]}" does not exist on this system') +                Warning(f'rule "{rule}" interface "{config["outbound_interface"]}" does not exist on this system')              addr = dict_search('translation.address', config)              if addr != None:                  if addr != 'masquerade' and not is_ip_network(addr):                      for ip in addr.split('-'):                          if not is_addr_assigned(ip): -                            print(f'WARNING: IP address {ip} does not exist on the system!') +                            Warning(f'IP address {ip} does not exist on the system!')              elif 'exclude' not in config:                  raise ConfigError(f'{err_msg}\n' \                                    'translation address not specified') @@ -167,7 +168,7 @@ def verify(nat):                                    'inbound-interface not specified')              else:                  if config['inbound_interface'] not in 'any' and config['inbound_interface'] not in interfaces(): -                    print(f'WARNING: rule "{rule}" interface "{config["inbound_interface"]}" does not exist on this system') +                    Warning(f'rule "{rule}" interface "{config["inbound_interface"]}" does not exist on this system')              if dict_search('translation.address', config) == None and 'exclude' not in config: diff --git a/src/conf_mode/nat66.py b/src/conf_mode/nat66.py index 8bf2e8073..1cd15811f 100755 --- a/src/conf_mode/nat66.py +++ b/src/conf_mode/nat66.py @@ -21,6 +21,7 @@ import os  from sys import exit  from netifaces import interfaces +from vyos.base import Warning  from vyos.config import Config  from vyos.configdict import dict_merge  from vyos.template import render @@ -117,12 +118,12 @@ def verify(nat):                  raise ConfigError(f'{err_msg} outbound-interface not specified')              if config['outbound_interface'] not in interfaces(): -                raise ConfigError(f'WARNING: rule "{rule}" interface "{config["outbound_interface"]}" does not exist on this system') +                raise ConfigError(f'rule "{rule}" interface "{config["outbound_interface"]}" does not exist on this system')              addr = dict_search('translation.address', config)              if addr != None:                  if addr != 'masquerade' and not is_ipv6(addr): -                    raise ConfigError(f'Warning: IPv6 address {addr} is not a valid address') +                    raise ConfigError(f'IPv6 address {addr} is not a valid address')              else:                  raise ConfigError(f'{err_msg} translation address not specified') @@ -140,7 +141,7 @@ def verify(nat):                                    'inbound-interface not specified')              else:                  if config['inbound_interface'] not in 'any' and config['inbound_interface'] not in interfaces(): -                    print(f'WARNING: rule "{rule}" interface "{config["inbound_interface"]}" does not exist on this system') +                    Warning(f'rule "{rule}" interface "{config["inbound_interface"]}" does not exist on this system')      return None diff --git a/src/conf_mode/policy-route.py b/src/conf_mode/policy-route.py index 3d1d7d8c5..09d181d43 100755 --- a/src/conf_mode/policy-route.py +++ b/src/conf_mode/policy-route.py @@ -20,6 +20,7 @@ import re  from json import loads  from sys import exit +from vyos.base import Warning  from vyos.config import Config  from vyos.template import render  from vyos.util import cmd @@ -135,7 +136,7 @@ def verify_rule(policy, name, rule_conf, ipv6):                              raise ConfigError(f'Invalid {error_group} "{group_name}" on policy route rule')                          if not group_obj: -                            print(f'WARNING: {error_group} "{group_name}" has no members') +                            Warning(f'{error_group} "{group_name}" has no members')              if 'port' in side_conf or dict_search_args(side_conf, 'group', 'port_group'):                  if 'protocol' not in rule_conf: diff --git a/src/conf_mode/snmp.py b/src/conf_mode/snmp.py index 4fc6a4517..e35bb8a0c 100755 --- a/src/conf_mode/snmp.py +++ b/src/conf_mode/snmp.py @@ -18,6 +18,7 @@ import os  from sys import exit +from vyos.base import Warning  from vyos.config import Config  from vyos.configdict import dict_merge  from vyos.configverify import verify_vrf @@ -149,7 +150,7 @@ def verify(snmp):              tmp = extension_opt['script']              if not os.path.isfile(tmp): -                print(f'WARNING: script "{tmp}" does not exist!') +                Warning(f'script "{tmp}" does not exist!')              else:                  chmod_755(extension_opt['script']) @@ -158,7 +159,7 @@ def verify(snmp):              # We only wan't to configure addresses that exist on the system.              # Hint the user if they don't exist              if not is_addr_assigned(address): -                print(f'WARNING: SNMP listen address "{address}" not configured!') +                Warning(f'SNMP listen address "{address}" not configured!')      if 'trap_target' in snmp:          for trap, trap_config in snmp['trap_target'].items(): diff --git a/src/conf_mode/tftp_server.py b/src/conf_mode/tftp_server.py index ef726670c..95050624e 100755 --- a/src/conf_mode/tftp_server.py +++ b/src/conf_mode/tftp_server.py @@ -22,6 +22,7 @@ from copy import deepcopy  from glob import glob  from sys import exit +from vyos.base import Warning  from vyos.config import Config  from vyos.configdict import dict_merge  from vyos.configverify import verify_vrf @@ -68,8 +69,8 @@ def verify(tftpd):      for address, address_config in tftpd['listen_address'].items():          if not is_addr_assigned(address): -            print(f'WARNING: TFTP server listen address "{address}" not ' \ -                  'assigned to any interface!') +            Warning(f'TFTP server listen address "{address}" not ' \ +                     'assigned to any interface!')          verify_vrf(address_config)      return None | 
