summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-07-23interface: T6592: remove interface from conntrack ct_iface_map on deletionChristian Breunig
We always have had stale interface entries in the ct_iface_map of nftables/ conntrack for any interface that once belonged to a VRF. This commit will always clean the nftables interface map when the interface is deleted from the system.
2024-07-22Merge pull request #3827 from HollyGurza/T6525Christian Breunig
T6525: Add default dir for ext-scripts without absolute path
2024-07-22Merge pull request #3850 from c-po/openvpn-totp-T3834Christian Breunig
openvpn: T3834: verify() is not allowed to change anything on the system
2024-07-22Merge pull request #3832 from sever-sever/T6594Christian Breunig
T6594: Add missed pppd_compat module
2024-07-22Merge pull request #3839 from c-po/unused-importsChristian Breunig
vrf: T6592: remove unused import get_interface_config
2024-07-22openvpn: T3834: verify() is not allowed to change anything on the systemChristian Breunig
Commit e3c71af1466 ("remove secrets file if the tunnel is deleted and fix opmode commands") added a code path into verify() which removed files on the system if TOTP was not defined. This commit moves the code path to the appropriate generate() function.
2024-07-22Merge pull request #3833 from c-po/wifi-fixChristian Breunig
wireless: T6597: improve hostapd startup and corresponding smoketests
2024-07-22Merge pull request #3841 from lucasec/t6599Christian Breunig
T6599: ipsec: support disabling rekey of CHILD_SA, converge and fix defaults
2024-07-22T6599: ipsec: fix incorect default behavior for dead-peer-detectionLucas Christian
2024-07-22T6599: ipsec: support disabling rekey of CHILD_SA.Lucas Christian
Also adds support for life_bytes, life_packets, and DPD for remote-access connections. Changes behavior of remote-access esp-group lifetime setting to have parity with site-to-site connections.
2024-07-22Merge pull request #3838 from c-po/ospf-frr-fixChristian Breunig
smoketest: T6600: ospf: enable MPLS LDP on dummy interfaces
2024-07-21vrf: T6592: remove unused import get_interface_configChristian Breunig
Remove unused import (left over) from commit 36f3791e0 ("utils: migrate to new get_vrf_tableid() helper")
2024-07-21smoketest: T6600: ospf: enable MPLS LDP on dummy interfacesChristian Breunig
2024-07-20Merge pull request #3834 from c-po/interface-vrf-moveChristian Breunig
interfaces: T6592: moving an interface between VRF instances failed
2024-07-20Merge pull request #3835 from c-po/normalize-ymlChristian Breunig
GitHub: T6590: normalize LF in rebase label worflow file
2024-07-20utils: migrate to new get_vrf_tableid() helperChristian Breunig
Commit 452068ce7 ("interfaces: T6592: moving an interface between VRF instances failed") introduced a new helper to retrieve the VRF table ID from the Kernel. This commit migrates the old code path where the individual fields got queried to the new helper vyos.utils.network.get_vrf_tableid().
2024-07-20interfaces: T6592: moving an interface between VRF instances failedChristian Breunig
To reproduce: set vrf name mgmt table '150' set vrf name no-mgmt table '151' set interfaces ethernet eth2 vrf 'mgmt' commit set interfaces ethernet eth2 vrf no-mgmt commit This resulted in an error while interacting with nftables: [Errno 1] failed to run command: nft add element inet vrf_zones ct_iface_map { "eth2" : 151 } The reason is that the old mapping entry still exists and was not removed. This commit adds a new utility function get_vrf_tableid() and compares the current and new VRF table IDs assigned to an interface. If the IDs do not match, the nftables ct_iface_map entry is removed before the new entry is added.
2024-07-20GitHub: T6590: normalize LF in rebase label worflow fileChristian Breunig
2024-07-20wireless: T6597: improve hostapd startup and corresponding smoketestsChristian Breunig
This was found during smoketesting as thoase started to repeadingly fail in the last weeks File "/usr/libexec/vyos/tests/smoke/cli/test_interfaces_wireless.py", line 534, in test_wireless_security_station_address self.assertTrue(process_named_running('hostapd')) AssertionError: None is not true Digging into this revealed that this is NOT related to the smoketest coding but to hostapd/systemd instead. With a configured WIFI interface and calling: "sudo systemctl reload-or-restart hostapd@wlan1" multiple times in a short period caused systemd to report: "Jul 18 16:15:32 systemd[1]: hostapd@wlan1.service: Deactivated successfully." According to the internal systemd logic used in our version this is explained by: /* If there's a stop job queued before we enter the DEAD state, we shouldn't act on Restart=, in order to not * undo what has already been enqueued. */ if (unit_stop_pending(UNIT(s))) allow_restart = false; if (s->result == SERVICE_SUCCESS) s->result = f; if (s->result == SERVICE_SUCCESS) { unit_log_success(UNIT(s)); end_state = SERVICE_DEAD;` Where unit_log_success() generates the log message in question. Improve the restart login in the wireless interface script and an upgrade to hostapd solved the issue.
2024-07-19T6525: Add default dir for ext-scripts without absolute pathkhramshinr
2024-07-19SSTP-server: add missed pppd_compat moduleViacheslav Hletenko
2024-07-19PPTP-server: add missed pppd_compat moduleViacheslav Hletenko
2024-07-19L2TP-server: add missed pppd_compat moduleViacheslav Hletenko
2024-07-19IPoE-server: add missed pppd_compat moduleViacheslav Hletenko
2024-07-19smoketest: T6406: use check_kmod() helper over native call()Christian Breunig
2024-07-19smoketest: T6597: add "commit" debug informationChristian Breunig
2024-07-19utils: T5195: fix timeout commentChristian Breunig
2024-07-19Merge pull request #3828 from HollyGurza/T6578Christian Breunig
T6578: Fix unhandled exception in "show openconnect-server sessions"
2024-07-18openvpn: T6591: deprecate OpenVPN server net30 topology (#3825)Daniil Baturin
2024-07-18Merge pull request #3818 from dmbaturin/T6586-unconfigured-objectJohn Estabrook
op-mode: T6586: add a distinct exception for unconfigured objects (as opposed to entire subsystems)
2024-07-18T6578: Fix unhandled exception in "show openconnect-server sessions"khramshinr
2024-07-18Merge pull request #3820 from kumvijaya/currentChristian Breunig
T6590: rebase label worflow added
2024-07-17Merge pull request #3811 from dmbaturin/T6580-op-mode-path-completionChristian Breunig
op-mode: T6580: read active nodes directly from the config tree without calling cli-shell-api
2024-07-17T6590: rebase label worflow addedVijayakumar A
2024-07-17Merge pull request #3817 from c-po/op-mode-restartChristian Breunig
op-mode: T6577: create generic service restart helper to work with the API
2024-07-17op-mode: T6586: add a distinct exception for unconfigured objectsDaniil Baturin
as opposed to entire subsystems
2024-07-16op-mode: T6577: create generic service restart helper to work with the APIChristian Breunig
Right now we have multiple restart helpers (e.g. dhcp server, ssh, ntp) that all do the same (more or less): * Check if service is configured on CLI * Restart if configured * Error out if unconfigured This is not available via the op-mode API. Create a new restart.py op-mode helper that takes the service name and possible VRF as argument so it's also exposed via API.
2024-07-16Merge pull request #3809 from kumvijaya/currentChristian Breunig
T6572: added trigger pr caller workflow
2024-07-15Merge pull request #3816 from zdc/T6583-currentDaniil Baturin
ruff: T6583: Added settings for ruff
2024-07-15ruff: T6583: Added settings for ruffzsdc
Ruff settings help to write code in the same style for all contributors. These settings are compatible with requirements used in another very (if not the most) popular code formatter - black, except using a single quote, to keep the style also compatible with what we have now.
2024-07-15Merge pull request #3810 from c-po/restart-ntpChristian Breunig
op-mode: T6575: add support for NTP service restart via CLI
2024-07-15Merge pull request #3813 from jestabro/configdep-errorChristian Breunig
configdep: T6559: fix regression in dependent script error under configd
2024-07-15configdep: T6559: add smoketest of dependency script errorJohn Estabrook
2024-07-14configdep: T6559: use single dependency list with reset under configdJohn Estabrook
2024-07-14configdep: T6559: drop global redundancy removal to fix error reportingJohn Estabrook
2024-07-14Merge pull request #3812 from dmbaturin/T6581-show-firewall-rule-completionChristian Breunig
firewall: T6581: fix completion for "show firewall ... rule"
2024-07-14firewall: T6581: fix completion for "show firewall ... rule"Daniil Baturin
2024-07-14op-mode: T6580: read active nodes directly from the config treeDaniil Baturin
without calling cli-shell-api
2024-07-13op-mode: T6575: add support for NTP service restart via CLIChristian Breunig
This seemed to be arround in the early days, but is not available since at least VyOS 1.3.3. Add CLI helper to restart the NTP process (chrony).
2024-07-13T6572: added trigger workflow caller workflowVijayakumar A