summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-05-09Merge pull request #405 from kroy-the-rabbit/patch-1Daniil Baturin
T2441: Fix parse error in TZ validator
2020-05-08T2441: Fix parse errorkroy-the-rabbit
2020-05-09Merge branch 'current' of https://github.com/vyos/vyos-1x into currentDaniil Baturin
2020-05-09T2431: remove the numeric validator for it now lives in vyos-utils.Daniil Baturin
2020-05-08validator: T2417: remove src/validators/mac-addressChristian Poessinger
File now provided by vyos-utils
2020-05-08Merge pull request #395 from thomas-mangin/T2417Christian Poessinger
validator: T2417: try to make the code clearer
2020-05-08Merge branch 'current' of github.com:thomas-mangin/vyos-1x into T2417Thomas Mangin
2020-05-08Merge pull request #401 from runborg/T2436Christian Poessinger
T2436: Adding offline python compile to fetch syntax faults
2020-05-08Merge branch 'dhcpd-permissions-T2432' of https://github.com/jjakob/vyos-1x ↵Christian Poessinger
into current * 'dhcpd-permissions-T2432' of https://github.com/jjakob/vyos-1x: dhcp-server, dhcpv6-server: T2432: chown lease file to nobody:nogroup
2020-05-08Merge pull request #399 from jjakob/disable-address-fix-T2427Christian Poessinger
wireless: T2427: migrate to use common configdict and vlan functions, add common interface includes to template
2020-05-08Merge pull request #398 from jjakob/bridge-fix-T2241Christian Poessinger
openvpn: T2241: fix wrong indent caused by 66e15005
2020-05-08Merge pull request #402 from jjakob/fix-syntax-T2435Christian Poessinger
T2435: fix syntax errors
2020-05-08Merge pull request #404 from jjakob/dhcp-systemd-improve-T2438Christian Poessinger
dhcp(v6)-server/relay: T2438: change systemd service type to forking, validate config files
2020-05-08dhcpv6-relay: T2438: change systemd service typeJernej Jakob
The default of systemd services Type=simple isn't suitable for dhcrelay and other daemons. - change service type to forking - add RuntimeDirectory - set PIDFile
2020-05-08dhcp-relay: T2438: change systemd service typeJernej Jakob
The default of systemd services Type=simple isn't suitable for dhcrelay and other daemons. - change service type to forking - add RuntimeDirectory - set PIDFile
2020-05-08dhcpv6-server: T2438: change systemd service type, validate config fileJernej Jakob
The default of systemd services Type=simple isn't suitable for dhcpd and other daemons. - change service type to forking - add RuntimeDirectory - set paths to files in Environment - set PIDFile - validate config and lease file in ExecStartPre - add -q to make dhcpd quiet and only log to syslog - set Restart=always
2020-05-08dhcp-server: T2438: change systemd service type, validate config fileJernej Jakob
The default of systemd services Type=simple isn't suitable for dhcpd and other daemons. - change service type to forking - add RuntimeDirectory - set paths to files in Environment - set PIDFile - validate config and lease file in ExecStartPre - add -q to make dhcpd quiet and only log to syslog - set Restart=always
2020-05-08dhcp-server, dhcpv6-server: T2432: chown lease file to nobody:nogroupJernej Jakob
Commits f37194604 and 0cbad2850 migrated isc-dhcp-server(6) from SysVInit to SystemD, changing the user and group dhcpd is started as. This caused a permission error when dhcpd tried to write to lease files: dhcpd[2829]: Can't create new lease file: Permission denied As dhcpd is started as nobody:nogroup, setting the permissions on the lease files to 664 root:vyattacfg would make dhcpd unable to write to them. We can't make the files other-writable, as that would be a big security issue, so we need to set either the owner or group of the files to be dhcpd writeble. There should be no harm in changing both to nobody:nogroup, as they were previously root:root. If some other VyOS code doesn't like the ownership of these files in /config, they can be either excluded from the check (possibly moved into their own directory), or changed back to root:vyattacfg and vyattacfg added to nogroup.
2020-05-08T2436: Adding offline python compile to fetch syntax faultsRunar Borge
In the past there have been quite a few tickets regarding python syntax errors on scripts rewritten to python. To make a quickfix on some of these faults we could make a Jenkins step that executes: python3 -m compileall -q . to do a offline compile of the python files.
2020-05-08vlan: T2435: fix missing dict key in print variableJernej Jakob
2020-05-08vxlan: T2435: fix syntax errorJernej Jakob
2020-05-08pseudo-ethernet: T2435: fix syntax and copy-paste errorJernej Jakob
2020-05-07T2431: use native versions of validate-value and numeric validator.Daniil Baturin
2020-05-07openvpn: T2241: fix wrong indent caused by 66e15005Jernej Jakob
2020-05-07wireless: T2427: add common interface includes to templateJernej Jakob
2020-05-07wireless: T2427: migrate to use common configdict and vlan functionsJernej Jakob
Other interfaces were previously migrated, but this one was forgotten, causing a commit error: File "/usr/libexec/vyos/conf_mode/interfaces-wireless.py", line 621, in verify verify_vlan_config(wifi) File "/usr/lib/python3/dist-packages/vyos/ifconfig_vlan.py", line 155, in verify_vlan_config for vif in config['vif'].values(): AttributeError: 'list' object has no attribute 'values'
2020-05-07Merge pull request #391 from thomas-mangin/T1230Christian Poessinger
debug: T1230: add time information to saved debug logs
2020-05-06Merge branch 'http-api' of jestabro/vyos-1x into currentJohn Estabrook
http api: T2395: add waitress as production WSGI server http api: T2395: replace bottle with flask as microframework http api: use decorator to get command data from request http api: catch appropriate errors http api: function names should be consistent
2020-05-06http api: T2395: add waitress as production WSGI serverJohn Estabrook
2020-05-06http api: T2395: replace bottle with flask as microframeworkJohn Estabrook
2020-05-06http api: use decorator to get command data from requestJohn Estabrook
2020-05-06http api: catch appropriate errorsJohn Estabrook
2020-05-06http api: function names should be consistentJohn Estabrook
2020-05-07debug: T1230: add time information to saved debug logsThomas Mangin
2020-05-06sstp: T2392: add IPv6 DNS supportChristian Poessinger
New command added: * set vpn sstp network-settings name-server 2001:db8::1111
2020-05-06sstp: T2392: add initial IPv6 supportChristian Poessinger
New commands added: * set vpn sstp network-settings client-ipv6-pool prefix 2001:db8::/64 mask 112 * set vpn sstp network-settings client-ipv6-pool delegate 2001:db8:100::/48 delegation-prefix 64
2020-05-06debug: T1230: add time information to saved debug logsThomas Mangin
2020-05-06validator: T2417: try to make the code clearerThomas Mangin
2020-05-06Merge pull request #394 from thomas-mangin/T2426Daniil Baturin
debug: T2426: remove invisible characters when printing
2020-05-06debug: T2426: remove invisible characters when printingThomas Mangin
2020-05-06Merge pull request #393 from jjakob/disable-address-fix-T2427Christian Poessinger
T2427: fix interface addressing, bugfix config library, migrate VLAN config to dicts, move VLAN adding to common function
2020-05-05pseudo-ethernet: T2427: move VLAN adding to common functionJernej Jakob
2020-05-05ethernet: T2427: move VLAN adding to common functionJernej Jakob
2020-05-05bonding: T2427: move VLAN adding to common functionJernej Jakob
2020-05-05configdict: T2427: clarify code commentsJernej Jakob
2020-05-05vlan: T2427: move code that applies VLANs to interface to common functionJernej Jakob
2020-05-05vlan: T2427: convert vlan config variables from lists to dictsJernej Jakob
Previously all vlan configs, which are dicts, were appended to a simple list, with the distinguishing 'id' stored inside the dicts themselves. This worked, but wasn't ideal. This commit converts them to dicts, where the key is the VLAN ID and value the config dict of that VLAN. This makes it posible to access single VLANs by their ID (key) and we can for-loop and get both the ID and config with: 'for vif_id, vif in conf["vif"].items():'
2020-05-05configdict: T2427: do not remove all addresses when disabling interfaceJernej Jakob
Commit 3fdf0093a introduced code that removed all addresses from an interface when that interface is disabled. This is wrong, as other configured services may be listening on these addresses and may fail to start if their configured address isn't present. It also caused a commit error when applying dhcp-server configuration: DHCP server configuration error! None of configured DHCP subnets does not have appropriate primary IP address on any broadcast interface. This commit reverts it to prior behavior, which was to just put the interface admin down and leave all addresses configured, other than the IPv6 'fe80::EUI-64/64' link-local, which it deletes, as the interface may not have a MAC if it's put down.
2020-05-05config: T2427: always return copies of listsJernej Jakob
Since lists in python are assigned by reference, taking the return value from these functions and modifying it will modify all other return values of functions that called the function before and did not explicitly copy it. To be safe, always make a copy of lists before returning them.
2020-05-05Merge pull request #384 from jjakob/bridge-fix-T2241Christian Poessinger
T2241: fix interfaces falling out of bridge