summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-07-25Merge pull request #3869 from vyos/mergify/bp/sagitta/pr-3856Christian Breunig
vrf: T6602: verify supplied VRF name on all interface types (backport #3856)
2024-07-24vrf: T6602: verify supplied VRF name on all interface typesmergify/bp/sagitta/pr-3856Christian Breunig
Only some (e.g. ethernet or wireguard) interfaces validate if the supplied VRF actually exists. If this is not validated, one can pass an invalid VRF to the system which generates an OSError exception. To reproduce set interfaces vxlan vxlan1 vni 1000 set interfaces vxlan vxlan1 remote 1.2.3.4 set interfaces vxlan vxlan1 vrf smoketest results in OSError: [Errno 255] failed to run command: ip link set dev vxlan1 master smoketest_mgmt This commit adds the missing verify_vrf() call to the missing interface types and an appropriate smoketest for all interfaces supporting VRF assignment. (cherry picked from commit dd0ebffa33728e452ac6e11737c2283f0e390359)
2024-07-24Merge pull request #3845 from vyos/mergify/bp/sagitta/pr-3833Christian Breunig
wireless: T6597: improve hostapd startup and corresponding smoketests (backport #3833)
2024-07-23wireless: T6597: improve hostapd startup and corresponding smoketestsmergify/bp/sagitta/pr-3833Christian Breunig
This was found during smoketesting as thoase started to repeadingly fail in the last weeks File "/usr/libexec/vyos/tests/smoke/cli/test_interfaces_wireless.py", line 534, in test_wireless_security_station_address self.assertTrue(process_named_running('hostapd')) AssertionError: None is not true Digging into this revealed that this is NOT related to the smoketest coding but to hostapd/systemd instead. With a configured WIFI interface and calling: "sudo systemctl reload-or-restart hostapd@wlan1" multiple times in a short period caused systemd to report: "Jul 18 16:15:32 systemd[1]: hostapd@wlan1.service: Deactivated successfully." According to the internal systemd logic used in our version this is explained by: /* If there's a stop job queued before we enter the DEAD state, we shouldn't act on Restart=, in order to not * undo what has already been enqueued. */ if (unit_stop_pending(UNIT(s))) allow_restart = false; if (s->result == SERVICE_SUCCESS) s->result = f; if (s->result == SERVICE_SUCCESS) { unit_log_success(UNIT(s)); end_state = SERVICE_DEAD;` Where unit_log_success() generates the log message in question. Improve the restart login in the wireless interface script and an upgrade to hostapd solved the issue. (cherry picked from commit a67f49d99eda00998c425f9a663e138dbd0f7755)
2024-07-23smoketest: T6406: use check_kmod() helper over native call()Christian Breunig
(cherry picked from commit 8bf6687b5276589e64988c3c54dbf61a628ee2a0)
2024-07-23smoketest: T6597: add "commit" debug informationChristian Breunig
(cherry picked from commit f6485f7df8713298d81ec0d45c548417db111523)
2024-07-23utils: T5195: fix timeout commentChristian Breunig
(cherry picked from commit 11b273108d78ab1588be3c077f40b2ac876369a4)
2024-07-23Merge pull request #3847 from vyos/mergify/bp/sagitta/pr-3524Christian Breunig
wireless: T6320: Add 802.11ax at 6GHz to VyOS (backport #3524)
2024-07-23wireless: T6320: add 802.11ax at 6GHzmergify/bp/sagitta/pr-3524Alain Lamar
Authored-By: Alain Lamar <alain_lamar@yahoo.de> (cherry picked from commit d5e988ba2d0fa0189feff22374c9b46eb49e2e79)
2024-07-23openvpn: T3834: verify() is not allowed to change anything on the system (#3851)mergify[bot]
Commit e3c71af1466 ("remove secrets file if the tunnel is deleted and fix opmode commands") added a code path into verify() which removed files on the system if TOTP was not defined. This commit moves the code path to the appropriate generate() function. (cherry picked from commit 40c835992db9217f48e54dbbf15a7fbf1dcba482) Co-authored-by: Christian Breunig <christian@breunig.cc>
2024-07-23wireless: T6425: Fixing VHT beamforming for 802.11ac (backport #3576) (#3849)mergify[bot]
* wireless: T6425: Fix broken VHT beamforming (cherry picked from commit f75f0f9c94472f46e056808c3ac6aba809c090f0) * wireless: T6425: Add smoketests for VHT beamforming (cherry picked from commit 578fbe0eb436697132e5a738fec5a4ac61ced8da) * wireless: T6425: adjust to latest country-code changes Commit 9e22ab6b2a ("wireless: T6318: move country-code to a system wide configuration") removed the per wifi interface setting for a country-code. This commit adjust the smoketests to the new design. (cherry picked from commit 312273c9569d973c510d871adb941709804d8868) --------- Co-authored-by: Alain Lamar <alain_lamar@yahoo.de> Co-authored-by: Christian Breunig <christian@breunig.cc>
2024-07-22Merge pull request #3837 from vyos/mergify/bp/sagitta/pr-3834Christian Breunig
interfaces: T6592: moving an interface between VRF instances failed (backport #3834)
2024-07-21vrf: T6592: remove unused import get_interface_configmergify/bp/sagitta/pr-3834Christian Breunig
Remove unused import (left over) from commit 36f3791e0 ("utils: migrate to new get_vrf_tableid() helper") (cherry picked from commit b551f542c5c906c901e3be37ad3fd68c8248473d)
2024-07-20utils: migrate to new get_vrf_tableid() helperChristian Breunig
Commit 452068ce7 ("interfaces: T6592: moving an interface between VRF instances failed") introduced a new helper to retrieve the VRF table ID from the Kernel. This commit migrates the old code path where the individual fields got queried to the new helper vyos.utils.network.get_vrf_tableid(). (cherry picked from commit 36f3791e0c15267483d59a3bb74465811d08df88)
2024-07-20interfaces: T6592: moving an interface between VRF instances failedChristian Breunig
To reproduce: set vrf name mgmt table '150' set vrf name no-mgmt table '151' set interfaces ethernet eth2 vrf 'mgmt' commit set interfaces ethernet eth2 vrf no-mgmt commit This resulted in an error while interacting with nftables: [Errno 1] failed to run command: nft add element inet vrf_zones ct_iface_map { "eth2" : 151 } The reason is that the old mapping entry still exists and was not removed. This commit adds a new utility function get_vrf_tableid() and compares the current and new VRF table IDs assigned to an interface. If the IDs do not match, the nftables ct_iface_map entry is removed before the new entry is added. (cherry picked from commit 452068ce78581bb6fba2df4dba197e95b9aeb33d) # Conflicts: # python/vyos/ifconfig/interface.py # python/vyos/utils/network.py
2024-07-19Merge pull request #3831 from vyos/mergify/bp/sagitta/pr-3828Christian Breunig
T6578: Fix unhandled exception in "show openconnect-server sessions" (backport #3828)
2024-07-19T6578: Fix unhandled exception in "show openconnect-server sessions"mergify/bp/sagitta/pr-3828khramshinr
(cherry picked from commit e858d96a3fbc1ae4719a50ee67df02b2f256b40f)
2024-07-18Merge pull request #3826 from vyos/mergify/bp/sagitta/pr-3748John Estabrook
T6523: Telegraf use nft scripts only if the firewall configured (backport #3748)
2024-07-18Merge pull request #3824 from vyos/mergify/bp/sagitta/pr-3813Daniil Baturin
configdep: T6559: fix regression in dependent script error under configd (backport #3813)
2024-07-18T6523: Telegraf use nft scripts only if the firewall configuredmergify/bp/sagitta/pr-3748Viacheslav Hletenko
If a firewall is not configured there is no reason to get and execute telegraf firewall custom scripts as there are no nft chain in the firewall nftables configuration (cherry picked from commit ebff0c481907ac0c2c0be9981c3c3d87caf3003b)
2024-07-17configdep: T6559: add smoketest of dependency script errormergify/bp/sagitta/pr-3813John Estabrook
(cherry picked from commit ad43aa885a8ef689da212088d6ebb37c32d72883)
2024-07-17configdep: T6559: use single dependency list with reset under configdJohn Estabrook
(cherry picked from commit 52d08b1ec5b2943744daac7123e35fd415f85db2)
2024-07-17configdep: T6559: drop global redundancy removal to fix error reportingJohn Estabrook
(cherry picked from commit 7249d10f1fbb3f90a4bdbcd0223926d0380ddd3a)
2024-07-16Merge pull request #3814 from vyos/mergify/bp/sagitta/pr-3810Daniil Baturin
op-mode: T6575: add support for NTP service restart via CLI (backport #3810)
2024-07-15op-mode: T6575: add support for NTP service restart via CLImergify/bp/sagitta/pr-3810Christian Breunig
This seemed to be arround in the early days, but is not available since at least VyOS 1.3.3. Add CLI helper to restart the NTP process (chrony). (cherry picked from commit ca4f4343999bdbd8450ef952f42062877d6f3bab)
2024-07-14Merge pull request #3807 from vyos/mergify/bp/sagitta/pr-3805Christian Breunig
op-mode: T6566: add support for listing all interfaces in "monitor bandwidth" (backport #3805)
2024-07-11op-mode: T6566: add support for listing all interfaces in "monitor bandwidth"mergify/bp/sagitta/pr-3805Christian Breunig
Right now we can only monitor the bandwidth for one individual interface, but not all at once. This adds support to monitor all interfaces. (cherry picked from commit 7704af0c4454725e8c67138e5cabab3328bde0f8)
2024-07-11Merge pull request #3801 from kumvijaya/sagittaChristian Breunig
T6564: workflow trigger restriction for sagitta
2024-07-09T6564: workflow trigger restriction for sagittaVijayakumar A
2024-07-07Merge pull request #3798 from vyos/mergify/bp/sagitta/pr-3791Christian Breunig
op-mode: T6537: remove unused cmd imported from vyos.utils.process (backport #3791)
2024-07-06op-mode: T6537: remove unused cmd imported from vyos.utils.processChristian Breunig
Commit dc60fe99350 ("op-mode: T6537: include hostname in the reboot/shutdown warning message") added a more local import of vyos.utils.process.cmd() that made the fglobal import obsolete and trigger a linter warning. $ make unused-imports -------------------------------------------------------------------- Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00) (cherry picked from commit 6b2e45c073eeef62bbb5905e1bff98e20199b6b0)
2024-07-06Merge pull request #3794 from vyos/T6556-un-used-import-permission-sagittaChristian Breunig
T6556: pull_request to pull_request_target type for unused import
2024-07-05Merge pull request #3786 from vyos/T6556-trigger-branches-cleanup-sagittaChristian Breunig
T6556: permission update for unused import check
2024-07-05T6556: pull_request to pull_request_target type for unused importVijayakumar A
2024-07-05Merge pull request #3780 from vyos/mergify/bp/sagitta/pr-3777Christian Breunig
wireless: T4287: use upstream regulatory database due to kernel signing (backport #3777)
2024-07-05T6556: permission update for unused import checkVijayakumar A
2024-07-04wireless: T4287: use Debian postinst over preinst when using update-alternativesChristian Breunig
This fixes an error during ISO assembly: update-alternatives: error: no alternatives for regulatory.db dpkg: error processing archive /tmp/apt-dpkg-install-PJplR3/00-vyos-1x_1.5dev0-1880-gecaa44498_amd64.deb (--unpack): new vyos-1x package pre-installation script subprocess returned error exit status 2 (cherry picked from commit a414190447c32be0775a077cde13cef0cf2b8c54)
2024-07-04Merge pull request #3759 from vyos/mergify/bp/sagitta/pr-3721Christian Breunig
ssh: T5878: Allow changing the PubkeyAcceptedAlgorithms option (backport #3721)
2024-07-04Merge pull request #3775 from vyos/mergify/bp/sagitta/pr-3767Christian Breunig
op-mode: T6537: include hostname in the reboot/shutdown warning message (backport #3767)
2024-07-04wireless: T4287: use upstream regulatory database due to kernel signingChristian Breunig
Most likely b/c of our non signed Kernel binary we do not trust the Debian signed wireless regulatory database. Fallback to the upstream database instead. (cherry picked from commit 9263965071289b6e51e22669b6d588a8d8fbcc1f)
2024-07-04Merge pull request #3765 from vyos/mergify/bp/sagitta/pr-3760Christian Breunig
syslog: T5366: remove reference to deprecated sysvinit rsyslog script (backport #3760)
2024-07-03op-mode: T6537: include hostname in the reboot/shutdown warning messageDaniil Baturin
(cherry picked from commit dc60fe993505d1adca60f9b6e0f47f565c459331)
2024-07-03Merge pull request #3762 from vyos/mergify/bp/sagitta/pr-3749Christian Breunig
T6536: nat: add migration script that replaces wildcard charater (backport #3749)
2024-07-03T6536: change wildcard character from + to * - extend fix to interfaces ↵Nicolas Fort
defined in zone policy. (cherry picked from commit 66ec278393dbabe71f320c543816f27797d51140)
2024-07-03syslog: T5366: remove reference to deprecated sysvinit rsyslog scriptJohn Estabrook
(cherry picked from commit 977d2fbf7a62a97d98b38cf28e62f08fc9e8d3a2)
2024-07-03T6536: nat: add migration script that replaces wildcard charater supported ↵Nicolas Fort
in 1.3 <+> with character supported in latest version <*> (cherry picked from commit 148af29b68416a5b8d0e025a16aef252fdf31e67) # Conflicts: # src/migration-scripts/nat/6-to-7
2024-07-03ssh: T5878: Allow changing the PubkeyAcceptedAlgorithms optionkhramshinr
(cherry picked from commit 06e6e011cdf12e8d10cf1f6d4d848fd5db51720d)
2024-07-03Merge pull request #3755 from vyos/mergify/bp/sagitta/pr-3752Daniil Baturin
T6538: Add the ability to set GENEVE interfaces to VRF (backport #3752)
2024-07-03T6538: Add the ability to set GENEVE interfaces to VRFViacheslav Hletenko
(cherry picked from commit 5748db4ebb4f4023f8e33d45121ff24267941cc7)
2024-07-01Merge pull request #3735 from vyos/mergify/bp/sagitta/pr-3731Christian Breunig
op-mode: T5633, T6465: fix error when op cmd interrupted, updates some system call syntax (backport #3731)
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-27 12:39:31 +0000