Age | Commit message (Collapse) | Author |
|
This was found during smoketesting as thoase started to repeadingly fail in the last weeks
File "/usr/libexec/vyos/tests/smoke/cli/test_interfaces_wireless.py", line 534, in test_wireless_security_station_address
self.assertTrue(process_named_running('hostapd'))
AssertionError: None is not true
Digging into this revealed that this is NOT related to the smoketest coding but
to hostapd/systemd instead. With a configured WIFI interface and calling:
"sudo systemctl reload-or-restart hostapd@wlan1" multiple times in a short
period caused systemd to report:
"Jul 18 16:15:32 systemd[1]: hostapd@wlan1.service: Deactivated successfully."
According to the internal systemd logic used in our version this is explained by:
/* If there's a stop job queued before we enter the DEAD state, we shouldn't act on Restart=, in order to not
* undo what has already been enqueued. */
if (unit_stop_pending(UNIT(s)))
allow_restart = false;
if (s->result == SERVICE_SUCCESS)
s->result = f;
if (s->result == SERVICE_SUCCESS) {
unit_log_success(UNIT(s));
end_state = SERVICE_DEAD;`
Where unit_log_success() generates the log message in question.
Improve the restart login in the wireless interface script and an upgrade to
hostapd solved the issue.
|
|
|
|
|
|
|
|
op-mode: T6580: read active nodes directly from the config tree without calling cli-shell-api
|
|
op-mode: T6577: create generic service restart helper to work with the API
|
|
Right now we have multiple restart helpers (e.g. dhcp server, ssh, ntp) that
all do the same (more or less):
* Check if service is configured on CLI
* Restart if configured
* Error out if unconfigured
This is not available via the op-mode API. Create a new restart.py op-mode
helper that takes the service name and possible VRF as argument so it's also
exposed via API.
|
|
T6572: added trigger pr caller workflow
|
|
ruff: T6583: Added settings for ruff
|
|
Ruff settings help to write code in the same style for all contributors. These
settings are compatible with requirements used in another very (if not the most)
popular code formatter - black, except using a single quote, to keep the style
also compatible with what we have now.
|
|
op-mode: T6575: add support for NTP service restart via CLI
|
|
configdep: T6559: fix regression in dependent script error under configd
|
|
|
|
|
|
|
|
firewall: T6581: fix completion for "show firewall ... rule"
|
|
|
|
without calling cli-shell-api
|
|
This seemed to be arround in the early days, but is not available since at
least VyOS 1.3.3. Add CLI helper to restart the NTP process (chrony).
|
|
|
|
|
|
|
|
op-mode: T6566: add support for listing all interfaces in "monitor bandwidth"
|
|
Right now we can only monitor the bandwidth for one individual interface, but
not all at once. This adds support to monitor all interfaces.
|
|
|
|
|
|
op-mode: T6537: remove unused cmd imported from vyos.utils.process
|
|
smoketest: T6539: remove explicit test for non existing global log entry
|
|
GitHub: T6494: do not use 0/null value to mark build succeed
|
|
|
|
Commit dc60fe99350 ("op-mode: T6537: include hostname in the reboot/shutdown
warning message") added a more local import of vyos.utils.process.cmd() that
made the fglobal import obsolete and trigger a linter warning.
$ make unused-imports
--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)
|
|
T6496: Added support for WPA-Enterprise client-mode
|
|
T6556: workflow trigger branches cleanup
|
|
|
|
|
|
fix: attempt to fix indentation on `wpa_supplicant.conf.j2`
fix: attempt to fix indentation on `wpa_supplicant.conf.j2`
fix: incorrect bssid mapping
fix: use the correct jinja templating (I think)
fix: “remote blank space
fix: attempt to fix the formatting in j2
fix: attempt to fix the formatting in j2
feat: rename enterprise username and password + add checks in conf mode.
fix: move around `bssid` config option on `wpa_supplicant.conf.j2` and fix the security config part
fix: fix indentation on `wpa_supplicant.conf.j2`
|
|
Commit dd5908eac ("T6539: add logging options to load-balancer reverse-proxy")
added CLI commands to add custom log entries for frontend and backend servers
as well as a global log directive.
Remove explicit test code for no longer always present "global log" directive.
|
|
migration: T6007: add missing check for None in utility function
|
|
GitHub performs loose equality comparisons.
If the types do not match, GitHub coerces the type to a number. GitHub casts
data types to a number using these conversions:
https://docs.github.com/en/actions/learn-github-actions/expressions
|
|
An empty component version string will trigger a full migration,
however, the case of component_version is None was missed in a utility
function. Fix comment formatting.
|
|
|
|
wireless: T4287: use Debian postinst over preinst when using update-alternatives
|
|
This fixes an error during ISO assembly:
update-alternatives: error: no alternatives for regulatory.db
dpkg: error processing archive /tmp/apt-dpkg-install-PJplR3/00-vyos-1x_1.5dev0-1880-gecaa44498_amd64.deb (--unpack):
new vyos-1x package pre-installation script subprocess returned error exit status 2
|
|
wireless: T4287: use upstream regulatory database due to kernel signing
|
|
T6539: add logging options to load-balancer reverse-proxy
|
|
op-mode: T6371: fix output of NAT rules with single port range
|
|
vyos_net_name: T6544: Updated the `vyos_net_name` script
|
|
|
|
|
|
Most likely b/c of our non signed Kernel binary we do not trust the Debian
signed wireless regulatory database. Fallback to the upstream database instead.
|