summaryrefslogtreecommitdiff
path: root/src/conf_mode/interfaces-pppoe.py
AgeCommit message (Collapse)Author
2020-04-12template: T2230: use render to generate templatesThomas Mangin
convert all call to jinja to use template.render
2020-04-12vyos.util: rename chmod_x() -> chmod_755()Christian Poessinger
2020-04-10pppoe: T2248: connect-on-demand and vrf are mutually exclusiveChristian Poessinger
As PPP can be used to establish a connection on-demand it manages the Kernel default route. This can not be used when using VRFs which are managed by the ip-up.d and ip-down.d scripts - thus those options are now mutially exclusive. The best fix would be adding support for VRFs into PPP.
2020-04-09pppoe: enable Jinja2 trim_blocksChristian Poessinger
2020-04-08vyos-util: rename chown_file() > chown()Christian Poessinger
... to make it clear also directories can be chown(-ed)
2020-04-06util: T2226: rewrite pppoe to use cmdThomas Mangin
2020-04-04vyos.util: rename chmod_x_file() to chmod_x()Christian Poessinger
Now both files and directories are supported.
2020-04-04pppoe: T1318: bugfix: proper use of ip-pre-up.d directoryChristian Poessinger
Commit b250b233ec1 ("pppoe: T1318: move Jinja2 templates to data/templates folder") actually placed the pre-up configuration script into the ip-up folder.
2020-04-04pppoe: T2219: move adding of default route to ip-(up|down) scriptChristian Poessinger
As PPPoE interfaces should be part of a VRF it is required that the default can also be set into the specified VRF. The default way of PPP by setting the "defaultroute" option does not take a VRF into account. In this case PPP installs a Kernel route forwarding all default traffic over this interface. This change installs a static route with metric 1 instead into the routing table via FRR. This is not the same as a Kernel route in terms of metric 1 compared to 0 but it should do the trick.
2020-04-04pppoe: T1318: move Jinja2 templates to data/templates folderChristian Poessinger
This makes the actual code which generates the configs much more human readable.
2020-04-04vyos.util: use common subprocess_cmd wrapperChristian Poessinger
2020-04-03pppoe: T1318: minor cleanupsChristian Poessinger
2020-04-03pppoe: bugfix template name after migration to ip-up scriptsChristian Poessinger
Commit 6a0c6783d8b2 ("pppoe: migrate alias and vrf script from pre-up to up") changed the name of the ip-up script template but the template definition has been forgotten. This caused: NameError: name 'config_pppoe_ip_up_tmpl' is not defined
2020-04-02pppoe: migrate alias and vrf script from pre-up to upChristian Poessinger
As the pre-up script is only run once when the interface is brought up but not when the interface maybe only comes up 20 seconds later due to the remote site some actions can not be performed as placing the interface e.g. into a VRF instance.
2020-04-02pppoe: migrate to new new helpers in vyos.utilChristian Poessinger
Commit d2cf287 ("vyos.util: add chown_file and chmod_x_file helpers") added common helper functions to chown or chmod +x a file. Make use of those helpers.
2020-04-02pppoe: vrf: bugfix - only pppoe0 could be assigned to a VRFChristian Poessinger
2020-03-29pppoe: T1318: create peer directory on demandChristian Poessinger
2020-03-29pppoe: T1988: bugfix creating ip-pre-up.d directory after moving to vyos-1xChristian Poessinger
The creation of this directory has been done in the past using vyatta- wirelessmodem and after it's replacement in vyos-1x the directory has not been deployed anymore. Thos when rendering the PPPoE configuration the directory will be created on deemand.
2020-03-10pppoe: T1318: add missing ondemand config settingChristian Poessinger
2020-03-10pppoe: T1318: minor code cleanupChristian Poessinger
2020-03-07pppoe: T1318: move to Python3 f-strings where possibleChristian Poessinger
2020-03-07vrf: T31: enable vrf support for pppoe interfaceChristian Poessinger
2020-03-07pppoe: T1493: rename variables on ipv6-up scriptChristian Poessinger
2020-03-05pppoe: T1493: fix for fix of invalid reference of ipv6-up script fileChristian Poessinger
Commit d161cbb ("pppoe: T1493: fix invalid reference of ipv6-up script file") actually introduced another bug instead of fixing it. It was catched by vyos-smoketest ... luckily! Sorry!
2020-03-05pppoe: T1493: fix invalid reference of ipv6-up script fileChristian Poessinger
2020-03-05pppoe: T1493: support IPv6 address negotiation which is required for DHCPv6-PDChristian Poessinger
2020-03-04pppoe: T1318: IPv6 supportChristian Poessinger
2020-03-03interfaces: T1579: fix c/p error when evaluating ↵Christian Poessinger
os.environ['VYOS_TAGNODE_VALUE'] This has been only a theoretical problem but then the error condition was triggered - only an error has been printed instead of raising an Exception.
2020-03-01pppoe: T2087: enable unlimited connection attemptsChristian Poessinger
2020-02-25pppoe: T2055: verify logfile really existsChristian Poessinger
2020-02-25Merge branch 'pppoe-t2070' of github.com:c-po/vyos-1x into currentChristian Poessinger
* 'pppoe-t2070' of github.com:c-po/vyos-1x: pppoe: T2070: rewrite (dis-)connect op-mode commands in XML and Python gitignore: fix ignore pattern of all debhelper files pppoe: T2055: make logfile owned by root/vyattacfg pppoe: T1318: validate existing source-interface
2020-02-25pppoe: T2055: make logfile owned by root/vyattacfgChristian Poessinger
2020-02-25pppoe: T1318: validate existing source-interfaceChristian Poessinger
It is not only sufficient to check if there is a source-interface configured, but rather it must also be checked if the source-interface exists at all in the system. If the interface does not exist pppd will complain with: pppd[2778]: /usr/sbin/pppd: In file /etc/ppp/peers/pppoe1: unrecognized option 'eth0.202'
2020-02-24pppoe-client: T2069: Use rp_pppoe_service for send correct service-nameDmitriyEshenko
2020-02-23pppoe: T1318: set interface descriptionChristian Poessinger
2020-02-23pppoe: T2055: do not try to start a deleted dialer interfaceChristian Poessinger
2020-02-23pppoe: T1318: declutter name-server CLI nodesChristian Poessinger
Instead of letting the user choose between auto and none where auto is default, it makes more sesne to just offer an option to disable the default behavior.
2020-02-23pppoe: T1318: migrate user-id and password nodes under an authentication nodeChristian Poessinger
2020-02-23pppoe: T1318: rename link to source-interfaceChristian Poessinger
2020-02-23pppoe: T1318: use lists rather then strings on Config()Christian Poessinger
2020-02-23pppoe: T1318: support interface descriptionChristian Poessinger
2020-02-23pppoe: T1318: remove obsolete ipv6-up.d scriptChristian Poessinger
The generated script was not called at all. Verified in vyOS 1.2.3 and rolling. Looks like a leftover from the past. If this functionality is required - it should be re-implemented the proper way!
2020-02-23pppoe: T1318: use systemd to manage connectionChristian Poessinger
This reduces the amount of self written code to start-stop-daemon and also kill the process if it has no connection yet (there won't be a PID file in this case) and getting the proper PID for multiple processes would require me to walk the /proc/<pid>/cmdline for every binary involved.
2020-02-23pppoe: T1318: remove process startup debug outputChristian Poessinger
We no longer need to see the command which is used to spawn up PPPd and dial the connection.
2020-02-23pppoe: T1318: move process startup to apply()Christian Poessinger
2020-02-23pppoe: T1318: "link" option is mandatoryChristian Poessinger
2020-02-23pppoe: T1318: add first version of new XML/Python implementationChristian Poessinger
vyos@vyos# show interfaces pppoe pppoe pppoe0 { default-route force link eth2.7 mtu 400 name-server auto password 12345678 user-id vyos@vyos.io }