summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)Author
2024-08-13configverify: T6642: verify_interface_exists requires config_dict argmergify/bp/sagitta/pr-3961John Estabrook
The function verify_interface_exists requires a reference to the ambient config_dict rather than creating an instance. As access is required to the 'interfaces' path, provide as attribute of class ConfigDict, so as not to confuse path searches of script-specific config_dict instances. (cherry picked from commit 5f23b7275564cfaa7c178d320868b5f5e86ae606)
2024-08-09qos: T6638: require interface state existence in verify conditionalmergify/bp/sagitta/pr-3960John Estabrook
(cherry picked from commit ed63c9d1896a218715e13e1799fc059f4561f75e)
2024-08-03Merge pull request #3928 from vyos/mergify/bp/sagitta/pr-3923Daniil Baturin
console: T3334: remove unused directories imported from vyos.defaults (backport #3923)
2024-08-02T6486: T6379: Rewrite generate openvpn client-config (#3926)mergify[bot]
This command helps to generate users `.ovpn` files Rewrite `generate openvpn client-config` to use Config() It needs to get the default values as `ConfigTreeQuery` is not supporting default values. Fixed "ignores configured protocol type" if TCP is used Fixed lzo, was used even if lzo not configured Fixed encryption is not parse the dict (cherry picked from commit fe50f1a9292b34e168b35453f2cfc2aee2ca4843) Co-authored-by: Viacheslav Hletenko <v.gletenko@vyos.io>
2024-08-02Merge pull request #3921 from vyos/mergify/bp/sagitta/pr-3903Christian Breunig
T6617: T6618: vpn ipsec remote-access: fix profile generators (backport #3903)
2024-08-02Merge pull request #3905 from vyos/mergify/bp/sagitta/pr-3883Christian Breunig
vrf: T6603: conntrack ct_iface_map must only contain one entry for iifname/oifname (backport #3883)
2024-08-01console: T3334: remove unused directories imported from vyos.defaultsmergify/bp/sagitta/pr-3923Christian Breunig
(cherry picked from commit 4055090a8d4fd64288eab7ae41aa9440f5de4ece)
2024-08-01T6617: T6618: vpn ipsec remote-access: fix profile generatorsmergify/bp/sagitta/pr-3903Lucas Christian
(cherry picked from commit e97d86e619e134f4dfda06efb7df4a3296d17b95)
2024-08-01Merge pull request #3918 from vyos/mergify/bp/sagitta/pr-3915Christian Breunig
ipsec: T6148: Removed unused imports (backport #3915)
2024-07-31Merge pull request #3907 from vyos/mergify/bp/sagitta/pr-3715fett0
T6313: Add "NAT" to "generate" command for rule resequence (backport #3715)
2024-07-31ipsec: T6148: Removed unused imports (#3915)mergify/bp/sagitta/pr-3915aapostoliuk
Removed unused pprint module (cherry picked from commit cb1834742f4ed01d99d6396af8339dd59788ef65)
2024-07-31ipsec: T6148: Fixed reset command by adding init after terminating (#3763) ↵mergify[bot]
(#3909) Strongswan does not initiate session after termination via vici. Added an CHILD SAs initialization on the initiator side of the tunnel. (cherry picked from commit 8838b29180ccc26d2aca0c22c9c8ca5e274825b2) Co-authored-by: aapostoliuk <108394744+aapostoliuk@users.noreply.github.com>
2024-07-30system: op-mode: T3334: allow delayed getty restart when configuring serial ↵Andrew Topp
ports * Created op-mode command "restart serial console" * Relocated service control to vyos.utils.serial helpers, used by conf- and op-mode serial console handling * Checking for logged-in serial sessions that may be affected by getty reconfig * Warning the user when changes are committed and serial sessions are active, otherwise restart services as normal. No prompts issued during commit, all config gen/commit steps still occur except for the service restarts (everything remains consistent) * To apply committed changes, user will need to run "restart serial console" to complete the process or reboot the whole router * Added additional flags and target filtering for generic use of helpers. (cherry picked from commit bc9049ebd76576d727fa87b10b96d1616950237c)
2024-07-30T6313: Add "NAT" to "generate" command for rule resequencemergify/bp/sagitta/pr-3715khramshinr
(cherry picked from commit 142545b0535d0a994182389c99b7bcd6d7c37c24)
2024-07-30vrf: T6603: improve code runtime when retrieving info from nftables vrf zonemergify/bp/sagitta/pr-3883Christian Breunig
(cherry picked from commit 31acb42ecdf4ecf0f636f831f42a845b8a00d367)
2024-07-30vrf: T6603: conntrack ct_iface_map must only contain one entry for ↵Christian Breunig
iifname/oifname When any of the following features NAT, NAT66 or Firewall is enabled, for every VRF on the CLI we install one rule into nftables for conntrack: chain vrf_zones_ct_in { type filter hook prerouting priority raw; policy accept; counter packets 3113 bytes 32227 ct original zone set iifname map @ct_iface_map counter packets 8550 bytes 80739 ct original zone set iifname map @ct_iface_map counter packets 5644 bytes 67697 ct original zone set iifname map @ct_iface_map } This is superfluous. (cherry picked from commit d6e9824f1612bd8c876437c071f31a1a0f44af5d)
2024-07-29Merge pull request #3862 from vyos/mergify/bp/sagitta/pr-3853Christian Breunig
system_option: T5552: Apply IPv4 and IPv6 options after reapplying sysctls by TuneD (backport #3853)
2024-07-28T6605: restore configd error formatting to be consistent with CLI (#3868) ↵mergify[bot]
(#3878) (cherry picked from commit 645f24908c9b338adc56ecc83f8c44d0b0206550) Co-authored-by: John Estabrook <jestabro@vyos.io>
2024-07-26vxlan: T6505: Support VXLAN VLAN-VNI range mapping in CLI (#3756)mergify/bp/sagitta/pr-3756Nataliia S
(cherry picked from commit 115e99630a317cab62c6f99e0461f6ce2c1edaf3)
2024-07-25Merge pull request #3843 from vyos/mergify/bp/sagitta/pr-3841Christian Breunig
T6599: ipsec: support disabling rekey of CHILD_SA, converge and fix defaults (backport #3841)
2024-07-25system_option: T5552: Apply IPv4 and IPv6 options after reapplying sysctls ↵mergify/bp/sagitta/pr-3853Nataliia Solomko
by TuneD (cherry picked from commit 7b82e4005724683c6311fab22358746f2cca4c1b)
2024-07-24vrf: T6602: verify supplied VRF name on all interface typesmergify/bp/sagitta/pr-3856Christian Breunig
Only some (e.g. ethernet or wireguard) interfaces validate if the supplied VRF actually exists. If this is not validated, one can pass an invalid VRF to the system which generates an OSError exception. To reproduce set interfaces vxlan vxlan1 vni 1000 set interfaces vxlan vxlan1 remote 1.2.3.4 set interfaces vxlan vxlan1 vrf smoketest results in OSError: [Errno 255] failed to run command: ip link set dev vxlan1 master smoketest_mgmt This commit adds the missing verify_vrf() call to the missing interface types and an appropriate smoketest for all interfaces supporting VRF assignment. (cherry picked from commit dd0ebffa33728e452ac6e11737c2283f0e390359)
2024-07-23wireless: T6597: improve hostapd startup and corresponding smoketestsmergify/bp/sagitta/pr-3833Christian Breunig
This was found during smoketesting as thoase started to repeadingly fail in the last weeks File "/usr/libexec/vyos/tests/smoke/cli/test_interfaces_wireless.py", line 534, in test_wireless_security_station_address self.assertTrue(process_named_running('hostapd')) AssertionError: None is not true Digging into this revealed that this is NOT related to the smoketest coding but to hostapd/systemd instead. With a configured WIFI interface and calling: "sudo systemctl reload-or-restart hostapd@wlan1" multiple times in a short period caused systemd to report: "Jul 18 16:15:32 systemd[1]: hostapd@wlan1.service: Deactivated successfully." According to the internal systemd logic used in our version this is explained by: /* If there's a stop job queued before we enter the DEAD state, we shouldn't act on Restart=, in order to not * undo what has already been enqueued. */ if (unit_stop_pending(UNIT(s))) allow_restart = false; if (s->result == SERVICE_SUCCESS) s->result = f; if (s->result == SERVICE_SUCCESS) { unit_log_success(UNIT(s)); end_state = SERVICE_DEAD;` Where unit_log_success() generates the log message in question. Improve the restart login in the wireless interface script and an upgrade to hostapd solved the issue. (cherry picked from commit a67f49d99eda00998c425f9a663e138dbd0f7755)
2024-07-23wireless: T6320: add 802.11ax at 6GHzmergify/bp/sagitta/pr-3524Alain Lamar
Authored-By: Alain Lamar <alain_lamar@yahoo.de> (cherry picked from commit d5e988ba2d0fa0189feff22374c9b46eb49e2e79)
2024-07-23openvpn: T3834: verify() is not allowed to change anything on the system (#3851)mergify[bot]
Commit e3c71af1466 ("remove secrets file if the tunnel is deleted and fix opmode commands") added a code path into verify() which removed files on the system if TOTP was not defined. This commit moves the code path to the appropriate generate() function. (cherry picked from commit 40c835992db9217f48e54dbbf15a7fbf1dcba482) Co-authored-by: Christian Breunig <christian@breunig.cc>
2024-07-22T6599: ipsec: fix incorect default behavior for dead-peer-detectionmergify/bp/sagitta/pr-3841Lucas Christian
(cherry picked from commit 23a3419d512139650cfe3dc76759b370b0c0c3d6)
2024-07-21vrf: T6592: remove unused import get_interface_configmergify/bp/sagitta/pr-3834Christian Breunig
Remove unused import (left over) from commit 36f3791e0 ("utils: migrate to new get_vrf_tableid() helper") (cherry picked from commit b551f542c5c906c901e3be37ad3fd68c8248473d)
2024-07-20utils: migrate to new get_vrf_tableid() helperChristian Breunig
Commit 452068ce7 ("interfaces: T6592: moving an interface between VRF instances failed") introduced a new helper to retrieve the VRF table ID from the Kernel. This commit migrates the old code path where the individual fields got queried to the new helper vyos.utils.network.get_vrf_tableid(). (cherry picked from commit 36f3791e0c15267483d59a3bb74465811d08df88)
2024-07-19T6578: Fix unhandled exception in "show openconnect-server sessions"mergify/bp/sagitta/pr-3828khramshinr
(cherry picked from commit e858d96a3fbc1ae4719a50ee67df02b2f256b40f)
2024-07-18Merge pull request #3826 from vyos/mergify/bp/sagitta/pr-3748John Estabrook
T6523: Telegraf use nft scripts only if the firewall configured (backport #3748)
2024-07-18T6523: Telegraf use nft scripts only if the firewall configuredmergify/bp/sagitta/pr-3748Viacheslav Hletenko
If a firewall is not configured there is no reason to get and execute telegraf firewall custom scripts as there are no nft chain in the firewall nftables configuration (cherry picked from commit ebff0c481907ac0c2c0be9981c3c3d87caf3003b)
2024-07-17configdep: T6559: use single dependency list with reset under configdJohn Estabrook
(cherry picked from commit 52d08b1ec5b2943744daac7123e35fd415f85db2)
2024-07-17configdep: T6559: drop global redundancy removal to fix error reportingJohn Estabrook
(cherry picked from commit 7249d10f1fbb3f90a4bdbcd0223926d0380ddd3a)
2024-07-06op-mode: T6537: remove unused cmd imported from vyos.utils.processChristian Breunig
Commit dc60fe99350 ("op-mode: T6537: include hostname in the reboot/shutdown warning message") added a more local import of vyos.utils.process.cmd() that made the fglobal import obsolete and trigger a linter warning. $ make unused-imports -------------------------------------------------------------------- Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00) (cherry picked from commit 6b2e45c073eeef62bbb5905e1bff98e20199b6b0)
2024-07-03op-mode: T6537: include hostname in the reboot/shutdown warning messageDaniil Baturin
(cherry picked from commit dc60fe993505d1adca60f9b6e0f47f565c459331)
2024-07-03T6536: change wildcard character from + to * - extend fix to interfaces ↵Nicolas Fort
defined in zone policy. (cherry picked from commit 66ec278393dbabe71f320c543816f27797d51140)
2024-07-03T6536: nat: add migration script that replaces wildcard charater supported ↵Nicolas Fort
in 1.3 <+> with character supported in latest version <*> (cherry picked from commit 148af29b68416a5b8d0e025a16aef252fdf31e67) # Conflicts: # src/migration-scripts/nat/6-to-7
2024-07-01Merge pull request #3735 from vyos/mergify/bp/sagitta/pr-3731Christian Breunig
op-mode: T5633, T6465: fix error when op cmd interrupted, updates some system call syntax (backport #3731)
2024-07-01Merge pull request #3738 from vyos/mergify/bp/sagitta/pr-3720Christian Breunig
T6477: Add telegraf loki output plugin (backport #3720)
2024-06-29op-mode: T6524: rewrite "release dhcp(v6) interface" to new op-mode formatChristian Breunig
(cherry picked from commit 5ade35255b3d8438aa6082fe56ae459d50cdc0a5)
2024-06-28T6477: Add telegraf loki output pluginViacheslav Hletenko
Add Loki plugin to telegraf set service monitoring telegraf loki url xxx (cherry picked from commit 3365eb7ab99fa9a259fe440eb51e82fc0a0a4dc6)
2024-06-28Fixes error generated when op cmd interrupted, updates show system calls to ↵Ginko
new cli syntax (#3731) (cherry picked from commit a095a3c7b3dd4459dc8626f0e5adecda855580e0)
2024-06-26interfaces: T6519: harden config migration if ethernet interface is missingChristian Breunig
During a corner case where the configuration is migrated to a different system with fewer ethernet interfaces, migration will fail during an image upgrade. vyos.ethtool.Ethtool() is instantiated with an invalid interface leading to an exception that kills the migrator (cherry picked from commit e47d4fd385631236da6882233b09f6364cbb077b)
2024-06-24T3202: add single variable for Kernel dynamic debug settingsChristian Breunig
(cherry picked from commit 9495f904fcc157521ca001ee21cf31be28a6b3a0)
2024-06-24T3202: Enable wireguard debug messagesNataliia Solomko
(cherry picked from commit d818788932e3c57d020cca9236df7275da452fce)
2024-06-24Merge pull request #3709 from vyos/mergify/bp/sagitta/pr-3677Christian Breunig
T5949: Add option to disable USB autosuspend (backport #3677)
2024-06-24Merge pull request #3689 from vyos/mergify/bp/sagitta/pr-3682Christian Breunig
openconnect: T6500: add support for multiple ca-certificates (backport #3682)
2024-06-24pki: T6241: remove debug print statement about updated subsystems (#3670)mergify[bot]
Commit 9f9891a2099 ("pki: T6241: Fix dependency updates on PKI changes") added a print() statement which notified the users about the subsystems which got supplied with an updated certificate. Example: > PKI: Updating config: interfaces openvpn vtun0 tls certificate openvpn_vtun0 > PKI: Updating config: interfaces openvpn vtun0 tls ca_certificate openvpn_vtun0_1 This is an informational message which should maybe (if needed) be sent to syslog. But the main issue is that CLI paths are mangled (- to _) which makes the about print output wrong and could potentially confuse users. Statement has been commented to be re-enabled for debugging. (cherry picked from commit a4d49a96918c0f0dac3d17f9cf3a5b8f3a9505c0) Co-authored-by: Christian Breunig <christian@breunig.cc>
2024-06-24pki: T4026: Only emit private keys when available (#3667)mergify[bot]
* install_certificate() code path handles private_key=None & key_passphrase=None OK already * file and console output paths will error trying to encode None as a key * This is only an issue for a couple of the generate_*_sign() functions, where having a null private key is possible * Self-signing and CA creation always generate a private key * Certreqs will generate a private key if not already provided * Do not prompt for a private key passphrase if we aren't giving back a private key (cherry picked from commit d2cf8eeee9053d04f34c5e8a22373290d078ab37) Co-authored-by: Andrew Topp <andrewt@telekinetica.net>
2024-06-22Merge pull request #3650 from vyos/mergify/bp/sagitta/pr-3646Christian Breunig
op-mode: T6407: "generate pki" missed to mangle in ACME certificates when required (backport #3646)