From 0a436e1fce66391311799bc970f05f6f4ba880ad Mon Sep 17 00:00:00 2001 From: Nicolas Fort Date: Mon, 22 Jan 2024 11:28:20 +0000 Subject: T5957: fix removal of interface in firewall rules. --- python/vyos/firewall.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python/vyos/firewall.py b/python/vyos/firewall.py index a2622fa00..28ebf282c 100644 --- a/python/vyos/firewall.py +++ b/python/vyos/firewall.py @@ -280,7 +280,7 @@ def parse_rule(rule_conf, hook, fw_name, rule_id, ip_name): operator = '!=' iiface = iiface[1:] output.append(f'iifname {operator} {{{iiface}}}') - else: + elif 'group' in rule_conf['inbound_interface']: iiface = rule_conf['inbound_interface']['group'] if iiface[0] == '!': operator = '!=' @@ -295,7 +295,7 @@ def parse_rule(rule_conf, hook, fw_name, rule_id, ip_name): operator = '!=' oiface = oiface[1:] output.append(f'oifname {operator} {{{oiface}}}') - else: + elif 'group' in rule_conf['outbound_interface']: oiface = rule_conf['outbound_interface']['group'] if oiface[0] == '!': operator = '!=' -- cgit v1.2.3