From 0cb568c0eb9168c82fa3f12de77737bbab46c53d Mon Sep 17 00:00:00 2001
From: Christian Breunig <christian@breunig.cc>
Date: Mon, 11 Nov 2024 20:26:06 +0100
Subject: babel: T4977: use common include for IPv4/IPv6 route redistribution

---
 .../include/babel/redistribute-common.xml.i        | 38 +++++++++++
 interface-definitions/protocols_babel.xml.in       | 78 ++--------------------
 2 files changed, 42 insertions(+), 74 deletions(-)
 create mode 100644 interface-definitions/include/babel/redistribute-common.xml.i

diff --git a/interface-definitions/include/babel/redistribute-common.xml.i b/interface-definitions/include/babel/redistribute-common.xml.i
new file mode 100644
index 000000000..93efe68dd
--- /dev/null
+++ b/interface-definitions/include/babel/redistribute-common.xml.i
@@ -0,0 +1,38 @@
+<!-- include start from babel/redistribute-common.xml.i -->
+<leafNode name="bgp">
+    <properties>
+      <help>Border Gateway Protocol (BGP)</help>
+      <valueless/>
+    </properties>
+  </leafNode>
+  <leafNode name="connected">
+    <properties>
+      <help>Connected routes (directly attached subnet or host)</help>
+      <valueless/>
+    </properties>
+  </leafNode>
+  <leafNode name="isis">
+    <properties>
+      <help>Intermediate System to Intermediate System (IS-IS)</help>
+      <valueless/>
+    </properties>
+  </leafNode>
+  <leafNode name="kernel">
+    <properties>
+      <help>Redistribute Kernel routes (not installed via the zebra RIB)</help>
+      <valueless/>
+    </properties>
+  </leafNode>
+  <leafNode name="openfabric">
+    <properties>
+      <help>OpenFabric Routing Protocol</help>
+      <valueless/>
+    </properties>
+  </leafNode>
+  <leafNode name="static">
+    <properties>
+      <help>Statically configured routes</help>
+      <valueless/>
+    </properties>
+  </leafNode>
+<!-- include end -->
diff --git a/interface-definitions/protocols_babel.xml.in b/interface-definitions/protocols_babel.xml.in
index edea57425..2795a7dd4 100644
--- a/interface-definitions/protocols_babel.xml.in
+++ b/interface-definitions/protocols_babel.xml.in
@@ -71,36 +71,7 @@
                   <help>Redistribute IPv4 routes</help>
                 </properties>
                 <children>
-                  <leafNode name="bgp">
-                    <properties>
-                      <help>Redistribute BGP routes</help>
-                      <valueless/>
-                    </properties>
-                  </leafNode>
-                  <leafNode name="connected">
-                    <properties>
-                      <help>Redistribute connected routes</help>
-                      <valueless/>
-                    </properties>
-                  </leafNode>
-                  <leafNode name="isis">
-                    <properties>
-                      <help>Redistribute IS-IS routes</help>
-                      <valueless/>
-                    </properties>
-                  </leafNode>
-                  <leafNode name="kernel">
-                    <properties>
-                      <help>Redistribute kernel routes</help>
-                      <valueless/>
-                    </properties>
-                  </leafNode>
-                  <leafNode name="nhrp">
-                    <properties>
-                      <help>Redistribute NHRP routes</help>
-                      <valueless/>
-                    </properties>
-                  </leafNode>
+                  #include <include/babel/redistribute-common.xml.i>
                   <leafNode name="ospf">
                     <properties>
                       <help>Redistribute OSPF routes</help>
@@ -113,12 +84,6 @@
                       <valueless/>
                     </properties>
                   </leafNode>
-                  <leafNode name="static">
-                    <properties>
-                      <help>Redistribute static routes</help>
-                      <valueless/>
-                    </properties>
-                  </leafNode>
                 </children>
               </node>
               <node name="ipv6">
@@ -126,51 +91,16 @@
                   <help>Redistribute IPv6 routes</help>
                 </properties>
                 <children>
-                  <leafNode name="bgp">
-                    <properties>
-                      <help>Redistribute BGP routes</help>
-                      <valueless/>
-                    </properties>
-                  </leafNode>
-                  <leafNode name="connected">
-                    <properties>
-                      <help>Redistribute connected routes</help>
-                      <valueless/>
-                    </properties>
-                  </leafNode>
-                  <leafNode name="isis">
-                    <properties>
-                      <help>Redistribute IS-IS routes</help>
-                      <valueless/>
-                    </properties>
-                  </leafNode>
-                  <leafNode name="kernel">
-                    <properties>
-                      <help>Redistribute kernel routes</help>
-                      <valueless/>
-                    </properties>
-                  </leafNode>
-                  <leafNode name="nhrp">
-                    <properties>
-                      <help>Redistribute NHRP routes</help>
-                      <valueless/>
-                    </properties>
-                  </leafNode>
+                  #include <include/babel/redistribute-common.xml.i>
                   <leafNode name="ospfv3">
                     <properties>
-                      <help>Redistribute OSPFv3 routes</help>
+                      <help>Open Shortest Path First (IPv6) (OSPFv3)</help>
                       <valueless/>
                     </properties>
                   </leafNode>
                   <leafNode name="ripng">
                     <properties>
-                      <help>Redistribute RIPng routes</help>
-                      <valueless/>
-                    </properties>
-                  </leafNode>
-                  <leafNode name="static">
-                    <properties>
-                      <help>Redistribute static routes</help>
+                      <help>Routing Information Protocol next-generation (IPv6) (RIPng)</help>
                       <valueless/>
                     </properties>
                   </leafNode>
-- 
cgit v1.2.3