From 0ea58ccad9eccb5fa34da146cfd2ed9f9844e02f Mon Sep 17 00:00:00 2001 From: Nataliia Solomko Date: Thu, 23 Apr 2026 14:20:10 +0300 Subject: op-mode: T8305: Fix completion for "show isis neighbor " command MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Problem: The completion helper for `show isis neighbor` showed `system-id` as a literal keyword suggestion, leading users to type exactly `system-id` instead of an actual neighbor name. Doing so returned `Invalid system id system-id`. In reality, FRR accepts any real system-id (e.g. vyos01) and returns correct per-neighbor details — the issue was purely in the completion hint misguiding the user. Fix: Replaced the static `system-id` placeholder in the completion helper with a dynamic script that queries `vtysh -c "show isis hostname"` and offers real neighbor names as tab-completion suggestions. --- op-mode-definitions/include/isis-common.xml.i | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/op-mode-definitions/include/isis-common.xml.i b/op-mode-definitions/include/isis-common.xml.i index 17132b857..3ddbfbf82 100644 --- a/op-mode-definitions/include/isis-common.xml.i +++ b/op-mode-definitions/include/isis-common.xml.i @@ -106,7 +106,7 @@ Show specific IS-IS neighbor adjacency - system-id + ${vyos_op_scripts_dir}/vtysh_wrapper.sh $@ -- cgit v1.2.3