From 1053b331172277f7e3b2714fca84da7db4eb6221 Mon Sep 17 00:00:00 2001
From: Christian Poessinger <christian@poessinger.com>
Date: Fri, 6 Dec 2019 18:08:54 +0100
Subject: T1843: use include files for interface MTU size

---
 .../include/interface-mtu-1450-9000.xml.i          | 13 ++++++++++
 .../include/interface-mtu-68-9000.xml.i            | 13 ++++++++++
 interface-definitions/include/vif-s.xml.i          | 28 ++--------------------
 interface-definitions/include/vif.xml.i            | 14 +----------
 interface-definitions/interfaces-bonding.xml.in    | 14 +----------
 interface-definitions/interfaces-ethernet.xml.in   | 14 +----------
 interface-definitions/interfaces-geneve.xml.in     | 14 +----------
 interface-definitions/interfaces-vxlan.xml.in      | 14 +----------
 8 files changed, 33 insertions(+), 91 deletions(-)
 create mode 100644 interface-definitions/include/interface-mtu-1450-9000.xml.i
 create mode 100644 interface-definitions/include/interface-mtu-68-9000.xml.i

diff --git a/interface-definitions/include/interface-mtu-1450-9000.xml.i b/interface-definitions/include/interface-mtu-1450-9000.xml.i
new file mode 100644
index 000000000..87296a050
--- /dev/null
+++ b/interface-definitions/include/interface-mtu-1450-9000.xml.i
@@ -0,0 +1,13 @@
+<leafNode name="mtu">
+  <properties>
+    <help>Maximum Transmission Unit (MTU)</help>
+    <valueHelp>
+      <format>1450-9000</format>
+      <description>Maximum Transmission Unit</description>
+    </valueHelp>
+    <constraint>
+      <validator name="numeric" argument="--range 1450-9000"/>
+    </constraint>
+    <constraintErrorMessage>MTU must be between 1450 and 9000</constraintErrorMessage>
+  </properties>
+</leafNode>
diff --git a/interface-definitions/include/interface-mtu-68-9000.xml.i b/interface-definitions/include/interface-mtu-68-9000.xml.i
new file mode 100644
index 000000000..ad11afa80
--- /dev/null
+++ b/interface-definitions/include/interface-mtu-68-9000.xml.i
@@ -0,0 +1,13 @@
+<leafNode name="mtu">
+  <properties>
+    <help>Maximum Transmission Unit (MTU)</help>
+    <valueHelp>
+      <format>68-9000</format>
+      <description>Maximum Transmission Unit</description>
+    </valueHelp>
+    <constraint>
+      <validator name="numeric" argument="--range 68-9000"/>
+    </constraint>
+    <constraintErrorMessage>MTU must be between 68 and 9000</constraintErrorMessage>
+  </properties>
+</leafNode>
diff --git a/interface-definitions/include/vif-s.xml.i b/interface-definitions/include/vif-s.xml.i
index 3cb28d7e0..a109eed6b 100644
--- a/interface-definitions/include/vif-s.xml.i
+++ b/interface-definitions/include/vif-s.xml.i
@@ -38,19 +38,7 @@
       </properties>
     </leafNode>
     #include <include/interface-mac.xml.i>
-    <leafNode name="mtu">
-      <properties>
-        <help>Maximum Transmission Unit (MTU)</help>
-        <valueHelp>
-          <format>68-9000</format>
-          <description>Maximum Transmission Unit</description>
-        </valueHelp>
-        <constraint>
-          <validator name="numeric" argument="--range 68-9000"/>
-        </constraint>
-        <constraintErrorMessage>MTU must be between 68 and 9000</constraintErrorMessage>
-      </properties>
-    </leafNode>
+    #include <include/interface-mtu-68-9000.xml.i>
     <tagNode name="vif-c">
       <properties>
         <help>QinQ TAG-C Virtual Local Area Network (VLAN) ID</help>
@@ -71,19 +59,7 @@
         </leafNode>
         #include <include/interface-disable.xml.i>
         #include <include/interface-mac.xml.i>
-        <leafNode name="mtu">
-          <properties>
-            <help>Maximum Transmission Unit (MTU)</help>
-            <valueHelp>
-              <format>68-9000</format>
-              <description>Maximum Transmission Unit</description>
-            </valueHelp>
-            <constraint>
-              <validator name="numeric" argument="--range 68-9000"/>
-            </constraint>
-            <constraintErrorMessage>MTU must be between 68 and 9000</constraintErrorMessage>
-          </properties>
-        </leafNode>
+        #include <include/interface-mtu-68-9000.xml.i>
       </children>
     </tagNode>
   </children>
diff --git a/interface-definitions/include/vif.xml.i b/interface-definitions/include/vif.xml.i
index 954803319..c74d7815e 100644
--- a/interface-definitions/include/vif.xml.i
+++ b/interface-definitions/include/vif.xml.i
@@ -75,18 +75,6 @@
       </children>
     </node>
     #include <include/interface-mac.xml.i>
-    <leafNode name="mtu">
-      <properties>
-        <help>Maximum Transmission Unit (MTU)</help>
-        <valueHelp>
-          <format>68-9000</format>
-          <description>Maximum Transmission Unit</description>
-        </valueHelp>
-        <constraint>
-          <validator name="numeric" argument="--range 68-9000"/>
-        </constraint>
-        <constraintErrorMessage>MTU must be between 68 and 9000</constraintErrorMessage>
-      </properties>
-    </leafNode>
+    #include <include/interface-mtu-68-9000.xml.i>
   </children>
 </tagNode>
diff --git a/interface-definitions/interfaces-bonding.xml.in b/interface-definitions/interfaces-bonding.xml.in
index c36001d5d..71d1672bb 100644
--- a/interface-definitions/interfaces-bonding.xml.in
+++ b/interface-definitions/interfaces-bonding.xml.in
@@ -168,19 +168,7 @@
               </leafNode>
             </children>
           </node>
-          <leafNode name="mtu">
-            <properties>
-              <help>Maximum Transmission Unit (MTU)</help>
-              <valueHelp>
-                <format>68-9000</format>
-                <description>Maximum Transmission Unit</description>
-              </valueHelp>
-              <constraint>
-                <validator name="numeric" argument="--range 68-9000"/>
-              </constraint>
-              <constraintErrorMessage>MTU must be between 68 and 9000</constraintErrorMessage>
-            </properties>
-          </leafNode>
+          #include <include/interface-mtu-68-9000.xml.i>
           <leafNode name="primary">
             <properties>
               <help>Primary device interface</help>
diff --git a/interface-definitions/interfaces-ethernet.xml.in b/interface-definitions/interfaces-ethernet.xml.in
index dec2619ee..96f7a9454 100644
--- a/interface-definitions/interfaces-ethernet.xml.in
+++ b/interface-definitions/interfaces-ethernet.xml.in
@@ -102,19 +102,7 @@
             </children>
           </node>
           #include <include/interface-mac.xml.i>
-          <leafNode name="mtu">
-            <properties>
-              <help>Maximum Transmission Unit (MTU)</help>
-              <valueHelp>
-                <format>68-9000</format>
-                <description>Maximum Transmission Unit</description>
-              </valueHelp>
-              <constraint>
-                <validator name="numeric" argument="--range 68-9000"/>
-              </constraint>
-              <constraintErrorMessage>MTU must be between 68 and 9000</constraintErrorMessage>
-            </properties>
-          </leafNode>
+          #include <include/interface-mtu-68-9000.xml.i>
           <node name="offload-options">
             <properties>
               <help>Configurable offload options</help>
diff --git a/interface-definitions/interfaces-geneve.xml.in b/interface-definitions/interfaces-geneve.xml.in
index 146c40152..5a8c1136b 100644
--- a/interface-definitions/interfaces-geneve.xml.in
+++ b/interface-definitions/interfaces-geneve.xml.in
@@ -45,19 +45,7 @@
               </leafNode>
             </children>
           </node>
-          <leafNode name="mtu">
-            <properties>
-              <help>Maximum Transmission Unit (MTU)</help>
-              <valueHelp>
-                <format>1450-9000</format>
-                <description>Maximum Transmission Unit</description>
-              </valueHelp>
-              <constraint>
-                <validator name="numeric" argument="--range 1500-9000"/>
-              </constraint>
-              <constraintErrorMessage>MTU must be between 1500 and 9000</constraintErrorMessage>
-            </properties>
-          </leafNode>
+          #include <include/interface-mtu-1450-9000.xml.i>
           <leafNode name="remote">
             <properties>
               <help>Remote address of GENEVE tunnel</help>
diff --git a/interface-definitions/interfaces-vxlan.xml.in b/interface-definitions/interfaces-vxlan.xml.in
index 5be7125ce..01a1c68bd 100644
--- a/interface-definitions/interfaces-vxlan.xml.in
+++ b/interface-definitions/interfaces-vxlan.xml.in
@@ -66,19 +66,7 @@
               </completionHelp>
             </properties>
           </leafNode>
-          <leafNode name="mtu">
-            <properties>
-              <help>Maximum Transmission Unit (MTU)</help>
-              <valueHelp>
-                <format>1450-9000</format>
-                <description>Maximum Transmission Unit</description>
-              </valueHelp>
-              <constraint>
-                <validator name="numeric" argument="--range 1450-9000"/>
-              </constraint>
-              <constraintErrorMessage>MTU must be between 1450 and 9000</constraintErrorMessage>
-            </properties>
-          </leafNode>
+          #include <include/interface-mtu-1450-9000.xml.i>
           <leafNode name="remote">
             <properties>
               <help>Remote address of VXLAN tunnel</help>
-- 
cgit v1.2.3