From 7f2b376cb07c2a0407daf2677defddc880ca907f Mon Sep 17 00:00:00 2001 From: Christian Poessinger Date: Tue, 16 Feb 2021 19:04:48 +0100 Subject: bgp: T2100: always set "no bgp network import-check" In order to keep the current behavior when upgrading from 1.2 -> 1.3 -> 1.4 FRR requires us to set this option. This configuration modifies the behavior of the network statement. If you have this configured the underlying network must exist in the rib (default). If you have the [no] form configured then BGP will not check for the networks existence in the rib. For FRR versions 7.3 and before frr defaults for datacenter were the network must exist, traditional did not check for existence. For versions 7.4 and beyond both traditional and datacenter the network must exist. VyOS uses "traditional". --- data/templates/frr/bgp.frr.tmpl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/data/templates/frr/bgp.frr.tmpl b/data/templates/frr/bgp.frr.tmpl index bb8131730..4cb2ad092 100644 --- a/data/templates/frr/bgp.frr.tmpl +++ b/data/templates/frr/bgp.frr.tmpl @@ -176,8 +176,10 @@ ! router bgp {{ asn }} {# Disable eBGP policy by default until there is a CLI option #} -{# https://phabricator.vyos.net/T3183 & https://phabricator.vyos.net/T2100 #} +{# Workaround for T3183 until we have decided about a migration script #} no bgp ebgp-requires-policy +{# Workaround for T2100 until we have decided about a migration script #} + no bgp network import-check {% if address_family is defined and address_family is not none %} {% for afi, afi_config in address_family.items() %} ! -- cgit v1.2.3