From 858deb599c5fc207d979e9dadf423a17a9c3a2a7 Mon Sep 17 00:00:00 2001
From: Christian Poessinger <christian@poessinger.com>
Date: Sat, 30 Nov 2019 09:01:05 +0100
Subject: pppoe: T1318: "link" option is mandatory

---
 src/conf_mode/interfaces-pppoe.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/conf_mode/interfaces-pppoe.py b/src/conf_mode/interfaces-pppoe.py
index eb64d094b..c7eca5056 100755
--- a/src/conf_mode/interfaces-pppoe.py
+++ b/src/conf_mode/interfaces-pppoe.py
@@ -210,14 +210,15 @@ def get_config():
 
     return pppoe
 
-
 def verify(pppoe):
     if pppoe['deleted']:
         # bail out early
         return None
 
-    return None
+    if not pppoe['link']:
+        raise ConfigError('Physical link interface for PPPoE missing')
 
+    return None
 
 def generate(pppoe):
     config_file_pppoe = '/etc/ppp/peers/{}'.format(pppoe['intf'])
-- 
cgit v1.2.3