From f16633f0ef2dd074c24387cbd2b9d5541297509c Mon Sep 17 00:00:00 2001 From: Dmytro Aleksandrov Date: Mon, 19 Aug 2019 18:53:33 +0300 Subject: T1596 rewrite 'telnet' and 'traceroute' operations to xml style --- debian/control | 3 +++ op-mode-definitions/telnet.xml | 30 +++++++++++++++++++++ op-mode-definitions/traceroute.xml | 53 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 86 insertions(+) create mode 100644 op-mode-definitions/telnet.xml create mode 100644 op-mode-definitions/traceroute.xml diff --git a/debian/control b/debian/control index a65d0158e..41b402fc1 100644 --- a/debian/control +++ b/debian/control @@ -61,6 +61,9 @@ Depends: python3, openvpn, openvpn-auth-ldap, openvpn-auth-radius, + mtr-tiny, + telnet, + traceroute, ${shlibs:Depends}, ${misc:Depends} Description: VyOS configuration scripts and data diff --git a/op-mode-definitions/telnet.xml b/op-mode-definitions/telnet.xml new file mode 100644 index 000000000..7ec75be88 --- /dev/null +++ b/op-mode-definitions/telnet.xml @@ -0,0 +1,30 @@ + + + + + Telnet to a node + + + + + Telnet to a host + + <hostname> <x.x.x.x> <h:h:h:h:h:h:h:h> + + + /usr/bin/telnet $2 + + + + Telnet to a host:port + + <0-65535> + + + /usr/bin/telnet $2 $3 + + + + + + diff --git a/op-mode-definitions/traceroute.xml b/op-mode-definitions/traceroute.xml new file mode 100644 index 000000000..85f6047c1 --- /dev/null +++ b/op-mode-definitions/traceroute.xml @@ -0,0 +1,53 @@ + + + + + Track network path to node + + + + + Track network path to specified node + + <hostname> <x.x.x.x> <h:h:h:h:h:h:h:h> + + + /usr/bin/traceroute $2 + + + + + Track network path to <hostname|IPv4 address> + + <hostname> <x.x.x.x> + + + /usr/bin/traceroute -4 $3 + + + + + Track network path to <hostname|IPv6 address> + + <hostname> <h:h:h:h:h:h:h:h> + + + /usr/bin/traceroute -6 $3 + + + + + + + + + Monitor the path to a destination in realtime + + <hostname> <x.x.x.x> <h:h:h:h:h:h:h:h> + + + /usr/bin/mtr $3 + + + + -- cgit v1.2.3 From fe343f428a9740cdd3c6cf966f84238a14cd49fc Mon Sep 17 00:00:00 2001 From: Christian Poessinger Date: Wed, 21 Aug 2019 18:31:42 +0200 Subject: loopback: T1601: rewrite using XML/Python definitions --- interface-definitions/interfaces-loopback.xml | 46 ++++++++++++ src/conf_mode/interface-loopback.py | 102 ++++++++++++++++++++++++++ 2 files changed, 148 insertions(+) create mode 100644 interface-definitions/interfaces-loopback.xml create mode 100755 src/conf_mode/interface-loopback.py diff --git a/interface-definitions/interfaces-loopback.xml b/interface-definitions/interfaces-loopback.xml new file mode 100644 index 000000000..267731b1c --- /dev/null +++ b/interface-definitions/interfaces-loopback.xml @@ -0,0 +1,46 @@ + + + + + + + Loopback interface + 300 + + lo$ + + Loopback interface must be named lo + + lo + Loopback interface + + + + + + IP address + + ipv4net + IPv4 address and prefix length + + + ipv6net + IPv6 address and prefix length + + + + + + + Interface description + + ^.{1,256}$ + + Interface description too long (limit 256 characters) + + + + + + + diff --git a/src/conf_mode/interface-loopback.py b/src/conf_mode/interface-loopback.py new file mode 100755 index 000000000..445a9af64 --- /dev/null +++ b/src/conf_mode/interface-loopback.py @@ -0,0 +1,102 @@ +#!/usr/bin/env python3 +# +# Copyright (C) 2019 VyOS maintainers and contributors +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License version 2 or later as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . +# +# + +import os +import sys +import copy + +import vyos.configinterface as VyIfconfig + +from vyos.config import Config +from vyos import ConfigError + +default_config_data = { + 'address': [], + 'address_remove': [], + 'deleted': False, + 'description': '', +} + +def diff(first, second): + second = set(second) + return [item for item in first if item not in second] + +def get_config(): + loopback = copy.deepcopy(default_config_data) + conf = Config() + + # determine tagNode instance + try: + loopback['intf'] = os.environ['VYOS_TAGNODE_VALUE'] + except KeyError as E: + print("Interface not specified") + + # Check if interface has been removed + if not conf.exists('interfaces loopback ' + loopback['intf']): + loopback['deleted'] = True + + # set new configuration level + conf.set_level('interfaces loopback ' + loopback['intf']) + + # retrieve configured interface addresses + if conf.exists('address'): + loopback['address'] = conf.return_values('address') + + # retrieve interface description + if conf.exists('description'): + loopback['description'] = conf.return_value('description') + + # Determine interface addresses (currently effective) - to determine which + # address is no longer valid and needs to be removed from the interface + eff_addr = conf.return_effective_values('address') + act_addr = conf.return_values('address') + loopback['address_remove'] = diff(eff_addr, act_addr) + + return loopback + +def verify(loopback): + return None + +def generate(loopback): + return None + +def apply(loopback): + # Remove loopback interface + if not loopback['deleted']: + # update interface description used e.g. within SNMP + VyIfconfig.set_description(loopback['intf'], loopback['description']) + + # Configure interface address(es) + for addr in loopback['address']: + VyIfconfig.add_interface_address(loopback['intf'], addr) + + # Remove interface address(es) + for addr in loopback['address_remove']: + VyIfconfig.remove_interface_address(loopback['intf'], addr) + + return None + +if __name__ == '__main__': + try: + c = get_config() + verify(c) + generate(c) + apply(c) + except ConfigError as e: + print(e) + sys.exit(1) -- cgit v1.2.3 From 63cdf781f4604ed38591d0be71fa92ae3667da73 Mon Sep 17 00:00:00 2001 From: Christian Poessinger Date: Wed, 21 Aug 2019 18:33:06 +0200 Subject: bridge: T1556: remove superfluous if statements --- src/conf_mode/interface-bridge.py | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/conf_mode/interface-bridge.py b/src/conf_mode/interface-bridge.py index 543349e7b..65b5c4066 100755 --- a/src/conf_mode/interface-bridge.py +++ b/src/conf_mode/interface-bridge.py @@ -178,9 +178,6 @@ def get_config(): return bridge def verify(bridge): - if bridge is None: - return None - conf = Config() for br in conf.list_nodes('interfaces bridge'): # it makes no sense to verify ourself in this case @@ -195,15 +192,9 @@ def verify(bridge): return None def generate(bridge): - if bridge is None: - return None - return None def apply(bridge): - if bridge is None: - return None - cmd = '' if bridge['deleted']: # bridges need to be shutdown first -- cgit v1.2.3 From d553b380d59961093f777ce55f7e98cc8bd1844b Mon Sep 17 00:00:00 2001 From: Christian Poessinger Date: Wed, 21 Aug 2019 18:33:30 +0200 Subject: dummy: T1580: remove superfluous if statements --- src/conf_mode/interface-dummy.py | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/conf_mode/interface-dummy.py b/src/conf_mode/interface-dummy.py index 668e4acc7..ff9d57c89 100755 --- a/src/conf_mode/interface-dummy.py +++ b/src/conf_mode/interface-dummy.py @@ -77,21 +77,12 @@ def get_config(): return dummy def verify(dummy): - if dummy is None: - return None - return None def generate(dummy): - if dummy is None: - return None - return None def apply(dummy): - if dummy is None: - return None - # Remove dummy interface if dummy['deleted']: VyIfconfig.remove_interface(dummy['intf']) -- cgit v1.2.3