From c3770f57a3227f0b9e93e209811ba347b1408bb7 Mon Sep 17 00:00:00 2001
From: Christian Poessinger <christian@poessinger.com>
Date: Sun, 5 Apr 2020 20:34:51 +0200
Subject: dynamic-dns: T2230: move inlined templates to dedicated files

---
 data/templates/dynamic-dns/ddclient.conf.tmpl | 49 +++++++++++++++++
 src/conf_mode/dynamic_dns.py                  | 77 ++++++---------------------
 2 files changed, 66 insertions(+), 60 deletions(-)
 create mode 100644 data/templates/dynamic-dns/ddclient.conf.tmpl

diff --git a/data/templates/dynamic-dns/ddclient.conf.tmpl b/data/templates/dynamic-dns/ddclient.conf.tmpl
new file mode 100644
index 000000000..22cb38f4e
--- /dev/null
+++ b/data/templates/dynamic-dns/ddclient.conf.tmpl
@@ -0,0 +1,49 @@
+
+### Autogenerated by dynamic_dns.py ###
+daemon=1m
+syslog=yes
+ssl=yes
+pid={{ pid_file }}
+cache={{ cache_file }}
+
+{% for interface in interfaces -%}
+
+#
+# ddclient configuration for interface "{{ interface.interface }}":
+#
+{% if interface.web_url -%}
+use=web, web='{{ interface.web_url}}' {%- if interface.web_skip %}, web-skip='{{ interface.web_skip }}'{% endif %}
+{% else -%}
+use=if, if={{ interface.interface }}
+{% endif -%}
+
+{% for rfc in interface.rfc2136 -%}
+{% for record in rfc.record %}
+# RFC2136 dynamic DNS configuration for {{ record }}.{{ rfc.zone }}
+server={{ rfc.server }}
+protocol=nsupdate
+password={{ rfc.keyfile }}
+ttl={{ rfc.ttl }}
+zone={{ rfc.zone }}
+{{ record }}
+{% endfor -%}
+{% endfor -%}
+
+{% for srv in interface.service %}
+{% for host in srv.host %}
+# DynDNS provider configuration for {{ host }}
+protocol={{ srv.protocol }},
+max-interval=28d,
+login={{ srv.login }},
+password='{{ srv.password }}',
+{% if srv.server -%}
+server={{ srv.server }},
+{% endif -%}
+{% if srv.zone -%}
+zone={{ srv.zone }},
+{% endif -%}
+{{ host }}
+{% endfor %}
+{% endfor %}
+
+{% endfor %}
diff --git a/src/conf_mode/dynamic_dns.py b/src/conf_mode/dynamic_dns.py
index faf0663ab..56ce4fedc 100755
--- a/src/conf_mode/dynamic_dns.py
+++ b/src/conf_mode/dynamic_dns.py
@@ -1,6 +1,6 @@
 #!/usr/bin/env python3
 #
-# Copyright (C) 2018-2019 VyOS maintainers and contributors
+# Copyright (C) 2018-2020 VyOS maintainers and contributors
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 2 or later as
@@ -15,68 +15,20 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 import os
-import sys
-import jinja2
 
+from sys import exit
+from copy import deepcopy
+from jinja2 import FileSystemLoader, Environment
 from stat import S_IRUSR, S_IWUSR
+
 from vyos.config import Config
+from vyos.defaults import directories as vyos_data_dir
 from vyos import ConfigError
 
 config_file = r'/etc/ddclient/ddclient.conf'
 cache_file = r'/var/cache/ddclient/ddclient.cache'
 pid_file = r'/var/run/ddclient/ddclient.pid'
 
-config_tmpl = """
-### Autogenerated by dynamic_dns.py ###
-daemon=1m
-syslog=yes
-ssl=yes
-pid={{ pid_file }}
-cache={{ cache_file }}
-
-{% for interface in interfaces -%}
-
-#
-# ddclient configuration for interface "{{ interface.interface }}":
-#
-{% if interface.web_url -%}
-use=web, web='{{ interface.web_url}}' {%- if interface.web_skip %}, web-skip='{{ interface.web_skip }}'{% endif %}
-{% else -%}
-use=if, if={{ interface.interface }}
-{% endif -%}
-
-{% for rfc in interface.rfc2136 -%}
-{% for record in rfc.record %}
-# RFC2136 dynamic DNS configuration for {{ record }}.{{ rfc.zone }}
-server={{ rfc.server }}
-protocol=nsupdate
-password={{ rfc.keyfile }}
-ttl={{ rfc.ttl }}
-zone={{ rfc.zone }}
-{{ record }}
-{% endfor -%}
-{% endfor -%}
-
-{% for srv in interface.service %}
-{% for host in srv.host %}
-# DynDNS provider configuration for {{ host }}
-protocol={{ srv.protocol }},
-max-interval=28d,
-login={{ srv.login }},
-password='{{ srv.password }}',
-{% if srv.server -%}
-server={{ srv.server }},
-{% endif -%}
-{% if srv.zone -%}
-zone={{ srv.zone }},
-{% endif -%}
-{{ host }}
-{% endfor %}
-{% endfor %}
-
-{% endfor %}
-"""
-
 # Mapping of service name to service protocol
 default_service_protocol = {
     'afraid': 'freedns',
@@ -100,7 +52,7 @@ default_config_data = {
 }
 
 def get_config():
-    dyndns = default_config_data
+    dyndns = deepcopy(default_config_data)
     conf = Config()
     base_level = ['service', 'dns', 'dynamic']
 
@@ -200,17 +152,17 @@ def get_config():
 
         # Set config back to appropriate level for these options
         conf.set_level(base_level + ['interface', interface])
-        
+
         # Additional settings in CLI
         if conf.exists(['use-web', 'skip']):
             node['web_skip'] = conf.return_value(['use-web', 'skip'])
 
         if conf.exists(['use-web', 'url']):
             node['web_url'] = conf.return_value(['use-web', 'url'])
-        
+
         # set config level back to top level
         conf.set_level(base_level)
-        
+
         dyndns['interfaces'].append(node)
 
     return dyndns
@@ -272,6 +224,11 @@ def generate(dyndns):
 
         return None
 
+    # Prepare Jinja2 template loader from files
+    tmpl_path = os.path.join(vyos_data_dir['data'], 'templates', 'dynamic-dns')
+    fs_loader = FileSystemLoader(tmpl_path)
+    env = Environment(loader=fs_loader)
+
     dirname = os.path.dirname(dyndns['pid_file'])
     if not os.path.exists(dirname):
         os.mkdir(dirname)
@@ -280,7 +237,7 @@ def generate(dyndns):
     if not os.path.exists(dirname):
         os.mkdir(dirname)
 
-    tmpl = jinja2.Template(config_tmpl)
+    tmpl = env.get_template('ddclient.conf.tmpl')
     config_text = tmpl.render(dyndns)
     with open(config_file, 'w') as f:
         f.write(config_text)
@@ -314,4 +271,4 @@ if __name__ == '__main__':
         apply(c)
     except ConfigError as e:
         print(e)
-        sys.exit(1)
+        exit(1)
-- 
cgit v1.2.3