From 38ae3032180a3d49253237232a0e3de8d2836e7c Mon Sep 17 00:00:00 2001
From: Christian Poessinger <christian@poessinger.com>
Date: Tue, 29 Sep 2020 20:43:08 +0200
Subject: pppoe-server: T2936: move to get_config_dict()

For easier configuration read in (CLI) validation and also template rendering
it makes sense to drop the old, single implementation and move to the new,
generic get_config_dict() approach.

Recurring configuration parts like ip-pool, ipv6-pool and nameservers have
also been split our into individual templates which will be included through
Jinja2 - leading to a single-source of the template sections, too.
---
 interface-definitions/include/accel-radius-additions.xml.i | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

(limited to 'interface-definitions/include/accel-radius-additions.xml.i')

diff --git a/interface-definitions/include/accel-radius-additions.xml.i b/interface-definitions/include/accel-radius-additions.xml.i
index f4db51b97..43810625a 100644
--- a/interface-definitions/include/accel-radius-additions.xml.i
+++ b/interface-definitions/include/accel-radius-additions.xml.i
@@ -26,6 +26,7 @@
               <validator name="numeric" argument="--range 1-65535"/>
             </constraint>
           </properties>
+          <defaultValue>1813</defaultValue>
         </leafNode>
         <leafNode name="fail-time">
           <properties>
@@ -39,6 +40,7 @@
             </constraint>
             <constraintErrorMessage>Fail time must be between 0 and 600 seconds</constraintErrorMessage>
           </properties>
+          <defaultValue>0</defaultValue>
         </leafNode>
       </children>
     </tagNode>
@@ -54,6 +56,7 @@
         </constraint>
         <constraintErrorMessage>Timeout must be between 1 and 60 seconds</constraintErrorMessage>
       </properties>
+      <defaultValue>3</defaultValue>
     </leafNode>
     <leafNode name="acct-timeout">
       <properties>
@@ -67,6 +70,7 @@
         </constraint>
         <constraintErrorMessage>Timeout must be between 0 and 60 seconds</constraintErrorMessage>
       </properties>
+      <defaultValue>3</defaultValue>
     </leafNode>
     <leafNode name="max-try">
       <properties>
@@ -80,6 +84,7 @@
         </constraint>
         <constraintErrorMessage>Maximum tries must be between 1 and 20</constraintErrorMessage>
       </properties>
+      <defaultValue>3</defaultValue>
     </leafNode>
     <leafNode name="nas-identifier">
       <properties>
@@ -123,7 +128,7 @@
         </leafNode>
         <leafNode name="port">
           <properties>
-            <help>Port for Dynamic Authorization Extension server (DM/CoA)</help>
+            <help>Port for Dynamic Authorization Extension server (DM/CoA) (default: 1700)</help>
             <valueHelp>
               <format>number</format>
               <description>TCP port</description>
@@ -132,6 +137,7 @@
               <validator name="numeric" argument="--range 1-65535"/>
             </constraint>
           </properties>
+          <defaultValue>1700</defaultValue>
         </leafNode>
         <leafNode name="key">
           <properties>
-- 
cgit v1.2.3