From 18b303734d84c0c5677ea4d872ec068ffcab4cad Mon Sep 17 00:00:00 2001
From: Christian Poessinger <christian@poessinger.com>
Date: Fri, 10 Jun 2022 18:06:31 +0000
Subject: xml: drop not always applicable REQUIRED suffix from completion help
 string

If a parameter is required is determined from the Python string on commit.
This "indicator" is not used consistently and sometimes missing, or added where
it is not required anymore due to Python script improvement/rewrite.
---
 interface-definitions/include/bgp/protocol-common-config.xml.i | 10 +++++-----
 interface-definitions/include/bgp/remote-as.xml.i              |  2 +-
 interface-definitions/include/firewall/action.xml.i            |  2 +-
 interface-definitions/include/monitoring/url.xml.i             |  2 +-
 .../include/ospf/protocol-common-config.xml.i                  |  6 +++---
 interface-definitions/include/policy/action.xml.i              |  2 +-
 interface-definitions/include/policy/route-rule-action.xml.i   |  2 +-
 7 files changed, 13 insertions(+), 13 deletions(-)

(limited to 'interface-definitions/include')

diff --git a/interface-definitions/include/bgp/protocol-common-config.xml.i b/interface-definitions/include/bgp/protocol-common-config.xml.i
index abaff5232..c1b465e43 100644
--- a/interface-definitions/include/bgp/protocol-common-config.xml.i
+++ b/interface-definitions/include/bgp/protocol-common-config.xml.i
@@ -1156,7 +1156,7 @@
       <children>
         <leafNode name="identifier">
           <properties>
-            <help>Confederation AS identifier [REQUIRED]</help>
+            <help>Confederation AS identifier</help>
             <valueHelp>
               <format>u32:1-4294967294</format>
               <description>Confederation AS id</description>
@@ -1208,7 +1208,7 @@
       <children>
         <leafNode name="half-life">
           <properties>
-            <help>Half-life time for dampening [REQUIRED]</help>
+            <help>Half-life time for dampening</help>
             <valueHelp>
               <format>u32:1-45</format>
               <description>Half-life penalty in minutes</description>
@@ -1220,7 +1220,7 @@
         </leafNode>
         <leafNode name="max-suppress-time">
           <properties>
-            <help>Maximum duration to suppress a stable route [REQUIRED]</help>
+            <help>Maximum duration to suppress a stable route</help>
             <valueHelp>
               <format>u32:1-255</format>
               <description>Maximum suppress duration in minutes</description>
@@ -1232,7 +1232,7 @@
         </leafNode>
         <leafNode name="re-use">
           <properties>
-            <help>Threshold to start reusing a route [REQUIRED]</help>
+            <help>Threshold to start reusing a route</help>
             <valueHelp>
               <format>u32:1-20000</format>
               <description>Re-use penalty points</description>
@@ -1244,7 +1244,7 @@
         </leafNode>
         <leafNode name="start-suppress-time">
           <properties>
-            <help>When to start suppressing a route [REQUIRED]</help>
+            <help>When to start suppressing a route</help>
             <valueHelp>
               <format>u32:1-20000</format>
               <description>Start-suppress penalty points</description>
diff --git a/interface-definitions/include/bgp/remote-as.xml.i b/interface-definitions/include/bgp/remote-as.xml.i
index 58595b3b9..79d3b95a9 100644
--- a/interface-definitions/include/bgp/remote-as.xml.i
+++ b/interface-definitions/include/bgp/remote-as.xml.i
@@ -1,7 +1,7 @@
 <!-- include start from bgp/remote-as.xml.i -->
 <leafNode name="remote-as">
   <properties>
-    <help>Neighbor BGP AS number [REQUIRED]</help>
+    <help>Neighbor BGP AS number</help>
     <completionHelp>
       <list>external internal</list>
     </completionHelp>
diff --git a/interface-definitions/include/firewall/action.xml.i b/interface-definitions/include/firewall/action.xml.i
index 0f60e3c38..512cc23bd 100644
--- a/interface-definitions/include/firewall/action.xml.i
+++ b/interface-definitions/include/firewall/action.xml.i
@@ -1,7 +1,7 @@
 <!-- include start from firewall/action.xml.i -->
 <leafNode name="action">
   <properties>
-    <help>Rule action [REQUIRED]</help>
+    <help>Rule action</help>
     <completionHelp>
       <list>accept reject drop</list>
     </completionHelp>
diff --git a/interface-definitions/include/monitoring/url.xml.i b/interface-definitions/include/monitoring/url.xml.i
index 32c81122d..fd61c38ea 100644
--- a/interface-definitions/include/monitoring/url.xml.i
+++ b/interface-definitions/include/monitoring/url.xml.i
@@ -1,7 +1,7 @@
 <!-- include start from monitoring/url.xml.i -->
 <leafNode name="url">
   <properties>
-    <help>Remote URL [REQUIRED]</help>
+    <help>Remote URL</help>
     <valueHelp>
       <format>url</format>
       <description>Remote URL</description>
diff --git a/interface-definitions/include/ospf/protocol-common-config.xml.i b/interface-definitions/include/ospf/protocol-common-config.xml.i
index c156d5b1c..791bbc0f8 100644
--- a/interface-definitions/include/ospf/protocol-common-config.xml.i
+++ b/interface-definitions/include/ospf/protocol-common-config.xml.i
@@ -16,7 +16,7 @@
   <children>
     <leafNode name="export">
       <properties>
-        <help>Filter for outgoing routing update [REQUIRED]</help>
+        <help>Filter for outgoing routing update</help>
         <completionHelp>
           <list>bgp connected kernel rip static</list>
         </completionHelp>
@@ -178,10 +178,10 @@
     </leafNode>
     <leafNode name="network">
       <properties>
-        <help>OSPF network [REQUIRED]</help>
+        <help>OSPF network</help>
         <valueHelp>
           <format>ipv4net</format>
-          <description>OSPF network [REQUIRED]</description>
+          <description>OSPF network</description>
         </valueHelp>
         <constraint>
           <validator name="ipv4-prefix"/>
diff --git a/interface-definitions/include/policy/action.xml.i b/interface-definitions/include/policy/action.xml.i
index 0a3dc158a..5aa865523 100644
--- a/interface-definitions/include/policy/action.xml.i
+++ b/interface-definitions/include/policy/action.xml.i
@@ -1,7 +1,7 @@
 <!-- include start from policy/action.xml.i -->
 <leafNode name="action">
   <properties>
-    <help>Action to take on entries matching this rule [REQUIRED]</help>
+    <help>Action to take on entries matching this rule</help>
     <completionHelp>
       <list>permit deny</list>
     </completionHelp>
diff --git a/interface-definitions/include/policy/route-rule-action.xml.i b/interface-definitions/include/policy/route-rule-action.xml.i
index 1217055f2..456a21400 100644
--- a/interface-definitions/include/policy/route-rule-action.xml.i
+++ b/interface-definitions/include/policy/route-rule-action.xml.i
@@ -1,7 +1,7 @@
 <!-- include start from policy/route-rule-action.xml.i -->
 <leafNode name="action">
   <properties>
-    <help>Rule action [REQUIRED]</help>
+    <help>Rule action</help>
     <completionHelp>
       <list>drop</list>
     </completionHelp>
-- 
cgit v1.2.3