From 96d846d27ac818ee9a23bb7194bb58cfb7093387 Mon Sep 17 00:00:00 2001
From: Indrajit Raychaudhuri <irc@indrajit.com>
Date: Tue, 16 May 2023 20:49:59 -0500
Subject: T5226: Combine ipv4-address and ipv6-address validators

Use a single ip-address validator to combine and replace ipv4-address
and ipv6-address validators.
---
 .../include/bgp/neighbor-update-source.xml.i       |  3 +-
 .../include/bgp/protocol-common-config.xml.i       |  3 +-
 .../include/ipsec/local-address.xml.i              |  3 +-
 .../include/ipsec/remote-address.xml.i             |  3 +-
 .../include/listen-address-single.xml.i            |  3 +-
 .../include/listen-address-vrf.xml.i               |  3 +-
 interface-definitions/include/listen-address.xml.i |  3 +-
 .../include/name-server-ipv4-ipv6-port.xml.i       |  3 +-
 .../include/name-server-ipv4-ipv6.xml.i            |  3 +-
 .../include/radius-server-ipv4-ipv6.xml.i          |  3 +-
 .../include/static/static-route-bfd.xml.i          | 41 +++++++++++-----------
 11 files changed, 30 insertions(+), 41 deletions(-)

(limited to 'interface-definitions/include')

diff --git a/interface-definitions/include/bgp/neighbor-update-source.xml.i b/interface-definitions/include/bgp/neighbor-update-source.xml.i
index c6aa776c2..92e817166 100644
--- a/interface-definitions/include/bgp/neighbor-update-source.xml.i
+++ b/interface-definitions/include/bgp/neighbor-update-source.xml.i
@@ -20,8 +20,7 @@
       <description>Interface as route source</description>
     </valueHelp>
     <constraint>
-      <validator name="ipv4-address"/>
-      <validator name="ipv6-address"/>
+      <validator name="ip-address"/>
       #include <include/constraint/interface-name.xml.i>
     </constraint>
   </properties>
diff --git a/interface-definitions/include/bgp/protocol-common-config.xml.i b/interface-definitions/include/bgp/protocol-common-config.xml.i
index 527eaf991..2d36f7de6 100644
--- a/interface-definitions/include/bgp/protocol-common-config.xml.i
+++ b/interface-definitions/include/bgp/protocol-common-config.xml.i
@@ -940,8 +940,7 @@
       <description>Interface name</description>
     </valueHelp>
     <constraint>
-      <validator name="ipv4-address"/>
-      <validator name="ipv6-address"/>
+      <validator name="ip-address"/>
       #include <include/constraint/interface-name.xml.i>
     </constraint>
   </properties>
diff --git a/interface-definitions/include/ipsec/local-address.xml.i b/interface-definitions/include/ipsec/local-address.xml.i
index 9d267f3f7..71f514950 100644
--- a/interface-definitions/include/ipsec/local-address.xml.i
+++ b/interface-definitions/include/ipsec/local-address.xml.i
@@ -19,8 +19,7 @@
       <description>Allow any IPv4 address present on the system to be used for VPN</description>
     </valueHelp>
     <constraint>
-      <validator name="ipv4-address"/>
-      <validator name="ipv6-address"/>
+      <validator name="ip-address"/>
       <regex>(any)</regex>
     </constraint>
   </properties>
diff --git a/interface-definitions/include/ipsec/remote-address.xml.i b/interface-definitions/include/ipsec/remote-address.xml.i
index ba96290d0..91decba3c 100644
--- a/interface-definitions/include/ipsec/remote-address.xml.i
+++ b/interface-definitions/include/ipsec/remote-address.xml.i
@@ -19,8 +19,7 @@
       <description>Allow any IP address of the remote peer</description>
     </valueHelp>
     <constraint>
-      <validator name="ipv4-address"/>
-      <validator name="ipv6-address"/>
+      <validator name="ip-address"/>
       <validator name="fqdn"/>
       <regex>(any)</regex>
     </constraint>
diff --git a/interface-definitions/include/listen-address-single.xml.i b/interface-definitions/include/listen-address-single.xml.i
index 30293b338..6cc5aef0a 100644
--- a/interface-definitions/include/listen-address-single.xml.i
+++ b/interface-definitions/include/listen-address-single.xml.i
@@ -14,8 +14,7 @@
       <description>IPv6 address to listen for incoming connections</description>
     </valueHelp>
     <constraint>
-      <validator name="ipv4-address"/>
-      <validator name="ipv6-address"/>
+      <validator name="ip-address"/>
       <validator name="ipv6-link-local"/>
     </constraint>
   </properties>
diff --git a/interface-definitions/include/listen-address-vrf.xml.i b/interface-definitions/include/listen-address-vrf.xml.i
index 8c2bdce70..23ecc2476 100644
--- a/interface-definitions/include/listen-address-vrf.xml.i
+++ b/interface-definitions/include/listen-address-vrf.xml.i
@@ -14,8 +14,7 @@
       <description>IPv6 address to listen for incoming connections</description>
     </valueHelp>
     <constraint>
-      <validator name="ipv4-address"/>
-      <validator name="ipv6-address"/>
+      <validator name="ip-address"/>
     </constraint>
   </properties>
   <children>
diff --git a/interface-definitions/include/listen-address.xml.i b/interface-definitions/include/listen-address.xml.i
index 48003dbf2..2454f43ff 100644
--- a/interface-definitions/include/listen-address.xml.i
+++ b/interface-definitions/include/listen-address.xml.i
@@ -15,8 +15,7 @@
     </valueHelp>
     <multi/>
     <constraint>
-      <validator name="ipv4-address"/>
-      <validator name="ipv6-address"/>
+      <validator name="ip-address"/>
       <validator name="ipv6-link-local"/>
     </constraint>
   </properties>
diff --git a/interface-definitions/include/name-server-ipv4-ipv6-port.xml.i b/interface-definitions/include/name-server-ipv4-ipv6-port.xml.i
index fb0a4f4ae..b326a6537 100644
--- a/interface-definitions/include/name-server-ipv4-ipv6-port.xml.i
+++ b/interface-definitions/include/name-server-ipv4-ipv6-port.xml.i
@@ -11,8 +11,7 @@
       <description>Domain Name Server (DNS) IPv6 address</description>
     </valueHelp>
     <constraint>
-      <validator name="ipv4-address"/>
-      <validator name="ipv6-address"/>
+      <validator name="ip-address"/>
     </constraint>
   </properties>
   <children>
diff --git a/interface-definitions/include/name-server-ipv4-ipv6.xml.i b/interface-definitions/include/name-server-ipv4-ipv6.xml.i
index 14973234b..cf483e5d9 100644
--- a/interface-definitions/include/name-server-ipv4-ipv6.xml.i
+++ b/interface-definitions/include/name-server-ipv4-ipv6.xml.i
@@ -11,8 +11,7 @@
       <description>Domain Name Server (DNS) IPv6 address</description>
     </valueHelp>
     <constraint>
-      <validator name="ipv4-address"/>
-      <validator name="ipv6-address"/>
+      <validator name="ip-address"/>
     </constraint>
     <multi/>
   </properties>
diff --git a/interface-definitions/include/radius-server-ipv4-ipv6.xml.i b/interface-definitions/include/radius-server-ipv4-ipv6.xml.i
index c593512b4..efd418bb2 100644
--- a/interface-definitions/include/radius-server-ipv4-ipv6.xml.i
+++ b/interface-definitions/include/radius-server-ipv4-ipv6.xml.i
@@ -16,8 +16,7 @@
           <description>RADIUS server IPv6 address</description>
         </valueHelp>
         <constraint>
-          <validator name="ipv4-address"/>
-          <validator name="ipv6-address"/>
+          <validator name="ip-address"/>
         </constraint>
       </properties>
       <children>
diff --git a/interface-definitions/include/static/static-route-bfd.xml.i b/interface-definitions/include/static/static-route-bfd.xml.i
index a05a08d12..d588b369f 100644
--- a/interface-definitions/include/static/static-route-bfd.xml.i
+++ b/interface-definitions/include/static/static-route-bfd.xml.i
@@ -10,28 +10,27 @@
         <help>Use BFD multi hop session</help>
       </properties>
       <children>
-       <tagNode name="source">
-         <properties>
-           <help>Use source for BFD session</help>
-          <valueHelp>
-             <format>ipv4</format>
-             <description>IPv4 source address</description>
-           </valueHelp>
-           <valueHelp>
-             <format>ipv6</format>
-             <description>IPv6 source address</description>
-           </valueHelp>
-           <constraint>
-             <validator name="ipv4-address"/>
-             <validator name="ipv6-address"/>
-           </constraint>
-         </properties>
-         <children>
-           #include <include/bfd/profile.xml.i>
-         </children>
-       </tagNode>
+        <tagNode name="source">
+          <properties>
+            <help>Use source for BFD session</help>
+            <valueHelp>
+              <format>ipv4</format>
+              <description>IPv4 source address</description>
+            </valueHelp>
+            <valueHelp>
+              <format>ipv6</format>
+              <description>IPv6 source address</description>
+            </valueHelp>
+            <constraint>
+              <validator name="ip-address"/>
+            </constraint>
+          </properties>
+          <children>
+            #include <include/bfd/profile.xml.i>
+          </children>
+        </tagNode>
       </children>
     </node>
   </children>
 </node>
-<!-- include end -->
\ No newline at end of file
+<!-- include end -->
-- 
cgit v1.2.3