From cc87303aad1f5b9140ddcd82a9a75df1979b087c Mon Sep 17 00:00:00 2001 From: Christian Poessinger Date: Wed, 22 Apr 2020 17:44:52 +0200 Subject: accel-ppp: provide common wins-server include definition --- interface-definitions/include/accel-wins-server.xml.i | 13 +++++++++++++ interface-definitions/service_pppoe-server.xml.in | 14 +------------- interface-definitions/vpn_l2tp.xml.in | 14 +------------- 3 files changed, 15 insertions(+), 26 deletions(-) create mode 100644 interface-definitions/include/accel-wins-server.xml.i (limited to 'interface-definitions') diff --git a/interface-definitions/include/accel-wins-server.xml.i b/interface-definitions/include/accel-wins-server.xml.i new file mode 100644 index 000000000..461a65ddf --- /dev/null +++ b/interface-definitions/include/accel-wins-server.xml.i @@ -0,0 +1,13 @@ + + + Windows Internet Name Service (WINS) servers propagated to client + + ipv4 + Domain Name Server (DNS) IPv4 address + + + + + + + diff --git a/interface-definitions/service_pppoe-server.xml.in b/interface-definitions/service_pppoe-server.xml.in index 27669f1c3..6b09b3db4 100644 --- a/interface-definitions/service_pppoe-server.xml.in +++ b/interface-definitions/service_pppoe-server.xml.in @@ -255,19 +255,7 @@ - - - Windows Internet Name Service (WINS) servers propagated to client - - ipv4 - Domain Name Server (DNS) IPv4 address - - - - - - - + #include Advanced protocol options diff --git a/interface-definitions/vpn_l2tp.xml.in b/interface-definitions/vpn_l2tp.xml.in index ab0435172..702ef8b5a 100644 --- a/interface-definitions/vpn_l2tp.xml.in +++ b/interface-definitions/vpn_l2tp.xml.in @@ -165,19 +165,7 @@ - - - Windows Internet Name Service (WINS) servers propagated to client - - ipv4 - Domain Name Server (DNS) IPv4 address - - - - - - - + #include Pool of client IP addresses (must be within a /24) -- cgit v1.2.3 From f9fbda14a2559794999f3391e420c70b31e6a343 Mon Sep 17 00:00:00 2001 From: Christian Poessinger Date: Wed, 22 Apr 2020 17:55:30 +0200 Subject: vpn: pptp: T2351: migrate to common name-server, wins-server nodes --- interface-definitions/vpn_pptp.xml.in | 64 +++++++--------------------------- src/conf_mode/vpn_pptp.py | 15 ++++---- src/migration-scripts/pptp/1-to-2 | 65 +++++++++++++++++++++++++++++++++++ 3 files changed, 84 insertions(+), 60 deletions(-) create mode 100755 src/migration-scripts/pptp/1-to-2 (limited to 'interface-definitions') diff --git a/interface-definitions/vpn_pptp.xml.in b/interface-definitions/vpn_pptp.xml.in index 439fd7259..2cafae60f 100644 --- a/interface-definitions/vpn_pptp.xml.in +++ b/interface-definitions/vpn_pptp.xml.in @@ -28,60 +28,20 @@ - + - IPv4 Domain Name Service (DNS) server - - - - - Primary DNS server - - ipv4 - IPv4 address - - - - - - - - - Secondary DNS server - - ipv4 - IPv4 address - - - - - - - - - - - Windows Internet Name Service (WINS) server settings + Domain Name Server (DNS) propagated to client + + ipv4 + Domain Name Server (DNS) IPv4 address + + + + + - - - - Primary WINS server - - - - - - - - Secondary WINS server - - - - - - - + + #include Pool of client IP addresses (must be within a /24) diff --git a/src/conf_mode/vpn_pptp.py b/src/conf_mode/vpn_pptp.py index 653b21161..841c1b375 100755 --- a/src/conf_mode/vpn_pptp.py +++ b/src/conf_mode/vpn_pptp.py @@ -62,15 +62,11 @@ def get_config(): pptp = deepcopy(default_pptp) conf.set_level(base_path) - for server in ['server-1', 'server-2']: - if conf.exists(['dns-servers', server]): - tmp = conf.return_value(['dns-servers', server]) - pptp['dnsv4'].append(tmp) + if conf.exists(['name-server']): + pptp['dnsv4'] = conf.return_values(['name-server']) - for server in ['server-1', 'server-2']: - if conf.exists(['wins-servers', server]): - tmp = conf.return_value(['wins-servers', server]) - pptp['wins'].append(tmp) + if conf.exists(['wins-server']): + pptp['wins'] = conf.return_values(['wins-server']) if conf.exists(['outside-address']): pptp['outside_addr'] = conf.return_value(['outside-address']) @@ -243,6 +239,9 @@ def verify(pptp): if len(pptp['dnsv4']) > 2: raise ConfigError('Not more then two IPv4 DNS name-servers can be configured') + if len(pptp['wins']) > 2: + raise ConfigError('Not more then two IPv4 WINS name-servers can be configured') + def generate(pptp): if not pptp: diff --git a/src/migration-scripts/pptp/1-to-2 b/src/migration-scripts/pptp/1-to-2 new file mode 100755 index 000000000..605081f1c --- /dev/null +++ b/src/migration-scripts/pptp/1-to-2 @@ -0,0 +1,65 @@ +#!/usr/bin/env python3 +# +# Copyright (C) 2020 VyOS maintainers and contributors +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License version 2 or later as +# published by the Free Software Foundation. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# - migrate dns-servers node to common name-servers + +from sys import argv, exit + +from vyos.configtree import ConfigTree + +if (len(argv) < 1): + print("Must specify file name!") + exit(1) + +file_name = argv[1] + +with open(file_name, 'r') as f: + config_file = f.read() + +config = ConfigTree(config_file) +base = ['vpn', 'pptp', 'remote-access'] +if not config.exists(base): + # Nothing to do + exit(0) +else: + # Migrate IPv4 DNS servers + dns_base = base + ['dns-servers'] + if config.exists(dns_base): + for server in ['server-1', 'server-2']: + if config.exists(dns_base + [server]): + dns = config.return_value(dns_base + [server]) + config.set(base + ['name-server'], value=dns, replace=False) + + config.delete(dns_base) + + # Migrate IPv4 WINS servers + wins_base = base + ['wins-servers'] + if config.exists(wins_base): + for server in ['server-1', 'server-2']: + if config.exists(wins_base + [server]): + wins = config.return_value(wins_base + [server]) + config.set(base + ['wins-server'], value=wins, replace=False) + + config.delete(wins_base) + + + + try: + with open(file_name, 'w') as f: + f.write(config.to_string()) + except OSError as e: + print("Failed to save the modified config: {}".format(e)) + exit(1) -- cgit v1.2.3 From d55ab3a9fa06f3b4827665d269cef6819b549771 Mon Sep 17 00:00:00 2001 From: Christian Poessinger Date: Wed, 22 Apr 2020 18:16:13 +0200 Subject: vpn: pptp: T2351: migrate to common radius CLI --- interface-definitions/vpn_pptp.xml.in | 34 +--------------------------------- src/conf_mode/vpn_pptp.py | 8 ++++---- src/migration-scripts/pptp/1-to-2 | 8 +++++++- 3 files changed, 12 insertions(+), 38 deletions(-) (limited to 'interface-definitions') diff --git a/interface-definitions/vpn_pptp.xml.in b/interface-definitions/vpn_pptp.xml.in index 2cafae60f..34b528690 100644 --- a/interface-definitions/vpn_pptp.xml.in +++ b/interface-definitions/vpn_pptp.xml.in @@ -152,39 +152,7 @@ - - - RADIUS specific configuration - - - - - IP address of radius server - - ipv4 - IP address of RADIUS server - - - - - - Key for accessing the specified server - - - - - Maximum number of simultaneous requests to server (default: unlimited) - - - - - If server does not responds mark it as unavailable for this time (seconds) - - - - - - + #include diff --git a/src/conf_mode/vpn_pptp.py b/src/conf_mode/vpn_pptp.py index 841c1b375..a602de412 100755 --- a/src/conf_mode/vpn_pptp.py +++ b/src/conf_mode/vpn_pptp.py @@ -119,8 +119,8 @@ def get_config(): if conf.exists(['port']): radius['port'] = conf.return_value(['port']) - if conf.exists(['secret']): - radius['key'] = conf.return_value(['secret']) + if conf.exists(['key']): + radius['key'] = conf.return_value(['key']) if not conf.exists(['disable']): pptp['radius_server'].append(radius) @@ -161,8 +161,8 @@ def get_config(): if conf.exists(['dynamic-author', 'port']): dae['port'] = conf.return_value(['dynamic-author', 'port']) - if conf.exists(['dynamic-author', 'secret']): - dae['key'] = conf.return_value(['dynamic-author', 'secret']) + if conf.exists(['dynamic-author', 'key']): + dae['key'] = conf.return_value(['dynamic-author', 'key']) pptp['radius_dynamic_author'] = dae diff --git a/src/migration-scripts/pptp/1-to-2 b/src/migration-scripts/pptp/1-to-2 index 605081f1c..a13cc3a4f 100755 --- a/src/migration-scripts/pptp/1-to-2 +++ b/src/migration-scripts/pptp/1-to-2 @@ -15,6 +15,7 @@ # along with this program. If not, see . # - migrate dns-servers node to common name-servers +# - remove radios req-limit node from sys import argv, exit @@ -55,7 +56,12 @@ else: config.delete(wins_base) - + # Remove RADIUS server req-limit node + radius_base = base + ['authentication', 'radius'] + if config.exists(radius_base): + for server in config.list_nodes(radius_base + ['server']): + if config.exists(radius_base + ['server', server, 'req-limit']): + config.delete(radius_base + ['server', server, 'req-limit']) try: with open(file_name, 'w') as f: -- cgit v1.2.3 From afaa399fe50badcd0e98ff0d320bcdcd8bf7141e Mon Sep 17 00:00:00 2001 From: Christian Poessinger Date: Wed, 22 Apr 2020 18:26:13 +0200 Subject: vpn: pptp: T2351: add support for common radius-additions XML --- interface-definitions/vpn_pptp.xml.in | 1 + 1 file changed, 1 insertion(+) (limited to 'interface-definitions') diff --git a/interface-definitions/vpn_pptp.xml.in b/interface-definitions/vpn_pptp.xml.in index 34b528690..032455b4d 100644 --- a/interface-definitions/vpn_pptp.xml.in +++ b/interface-definitions/vpn_pptp.xml.in @@ -153,6 +153,7 @@ #include + #include -- cgit v1.2.3