From 6b66e59d1640672dd6ce683f61c4dda98cc3d367 Mon Sep 17 00:00:00 2001
From: Christian Breunig <christian@breunig.cc>
Date: Thu, 26 Mar 2026 16:48:56 +0100
Subject: pseudo-ethernet: T8434: source-interface does not show bridge or bond
 interfaces

We can create pseudo-ethernet (peth, macvlan) interfaces from bond or bridge
interfaces as the unddelraying parent, so the completion helper should honor it.
---
 .../include/source-interface-broadcast.xml.i               | 14 ++++++++++++++
 .../include/source-interface-ethernet.xml.i                |  2 +-
 interface-definitions/interfaces_pseudo-ethernet.xml.in    |  2 +-
 3 files changed, 16 insertions(+), 2 deletions(-)
 create mode 100644 interface-definitions/include/source-interface-broadcast.xml.i

(limited to 'interface-definitions')

diff --git a/interface-definitions/include/source-interface-broadcast.xml.i b/interface-definitions/include/source-interface-broadcast.xml.i
new file mode 100644
index 000000000..344a49024
--- /dev/null
+++ b/interface-definitions/include/source-interface-broadcast.xml.i
@@ -0,0 +1,14 @@
+<!-- include start from source-interface-broadcast.xml.i -->
+<leafNode name="source-interface">
+  <properties>
+    <help>Physical interface the traffic will go through</help>
+    <valueHelp>
+      <format>interface</format>
+      <description>Interface name</description>
+    </valueHelp>
+    <completionHelp>
+      <script>${vyos_completion_dir}/list_interfaces --broadcast</script>
+    </completionHelp>
+  </properties>
+</leafNode>
+<!-- include end -->
diff --git a/interface-definitions/include/source-interface-ethernet.xml.i b/interface-definitions/include/source-interface-ethernet.xml.i
index e06e47d6c..ff6948090 100644
--- a/interface-definitions/include/source-interface-ethernet.xml.i
+++ b/interface-definitions/include/source-interface-ethernet.xml.i
@@ -4,7 +4,7 @@
     <help>Physical interface the traffic will go through</help>
     <valueHelp>
       <format>interface</format>
-      <description>Physical interface used for traffic forwarding</description>
+      <description>Interface name</description>
     </valueHelp>
     <completionHelp>
       <script>${vyos_completion_dir}/list_interfaces --type ethernet</script>
diff --git a/interface-definitions/interfaces_pseudo-ethernet.xml.in b/interface-definitions/interfaces_pseudo-ethernet.xml.in
index f13144bed..f6e3b6970 100644
--- a/interface-definitions/interfaces_pseudo-ethernet.xml.in
+++ b/interface-definitions/interfaces_pseudo-ethernet.xml.in
@@ -26,7 +26,7 @@
           #include <include/interface/ipv4-options.xml.i>
           #include <include/interface/ipv6-options.xml.i>
           #include <include/interface/ipv6-options-with-nd.xml.i>
-          #include <include/source-interface-ethernet.xml.i>
+          #include <include/source-interface-broadcast.xml.i>
           #include <include/interface/mac.xml.i>
           #include <include/interface/mirror.xml.i>
           <leafNode name="mode">
-- 
cgit v1.2.3