From 917c658e37b619b1b2cd261ae43dd02f11eef720 Mon Sep 17 00:00:00 2001
From: Christian Breunig <christian@breunig.cc>
Date: Fri, 20 Sep 2024 22:28:13 +0200
Subject: T6630: ntp: move interface timestamping configuration under ptp node

---
 interface-definitions/service_ntp.xml.in | 37 +++++++++++++-------------------
 1 file changed, 15 insertions(+), 22 deletions(-)

(limited to 'interface-definitions')

diff --git a/interface-definitions/service_ntp.xml.in b/interface-definitions/service_ntp.xml.in
index d6d3e0818..5dc0cd295 100644
--- a/interface-definitions/service_ntp.xml.in
+++ b/interface-definitions/service_ntp.xml.in
@@ -13,34 +13,38 @@
           #include <include/generic-interface.xml.i>
           #include <include/listen-address.xml.i>
           #include <include/interface/vrf.xml.i>
-          <node name="offload">
+          <node name="ptp">
             <properties>
-              <help>Configurable offload options</help>
+              <help>Enable Precision Time Protocol (PTP) transport</help>
             </properties>
             <children>
+              #include <include/port-number.xml.i>
+              <leafNode name="port">
+                <defaultValue>319</defaultValue>
+              </leafNode>
               <node name="timestamp">
                 <properties>
                   <help>Enable timestamping of packets in the NIC hardware</help>
                 </properties>
                 <children>
-                  <leafNode name="default-enable">
-                    <properties>
-                      <help>Enable timestamping on all supported interfaces</help>
-                      <valueless/>
-                    </properties>
-                  </leafNode>
                   <tagNode name="interface">
                     <properties>
                       <help>Interface to enable timestamping on</help>
                       <completionHelp>
                         <script>${vyos_completion_dir}/list_interfaces</script>
+                        <list>all</list>
                       </completionHelp>
+                      <valueHelp>
+                        <format>all</format>
+                        <description>Select all interfaces</description>
+                      </valueHelp>
                       <valueHelp>
                         <format>txt</format>
                         <description>Interface name</description>
                       </valueHelp>
                       <constraint>
                         #include <include/constraint/interface-name.xml.i>
+                        <regex>all</regex>
                       </constraint>
                     </properties>
                     <children>
@@ -52,7 +56,7 @@
                           </completionHelp>
                           <valueHelp>
                             <format>all</format>
-                            <description>All received packets are timestamped</description>
+                            <description>All packets are timestamped</description>
                           </valueHelp>
                           <valueHelp>
                             <format>ntp</format>
@@ -60,11 +64,11 @@
                           </valueHelp>
                           <valueHelp>
                             <format>ptp</format>
-                            <description>Only PTP packets, or NTP packets using the PTP transport, are timestamped</description>
+                            <description>Only PTP or NTP packets using the PTP transport are timestamped</description>
                           </valueHelp>
                           <valueHelp>
                             <format>none</format>
-                            <description>No received packets are timestamped</description>
+                            <description>No packet is timestamped</description>
                           </valueHelp>
                           <constraint>
                             <regex>(all|ntp|ptp|none)</regex>
@@ -77,17 +81,6 @@
               </node>
             </children>
           </node>
-          <node name="ptp">
-            <properties>
-              <help>Enable Precision Time Protocol (PTP) transport</help>
-            </properties>
-            <children>
-              #include <include/port-number.xml.i>
-              <leafNode name="port">
-                <defaultValue>319</defaultValue>
-              </leafNode>
-            </children>
-          </node>
           <leafNode name="leap-second">
             <properties>
               <help>Leap second behavior</help>
-- 
cgit v1.2.3