From a0d3c5702dfcf0ac0008039357a2e0e02c625235 Mon Sep 17 00:00:00 2001
From: Christian Poessinger <christian@poessinger.com>
Date: Sun, 25 Dec 2022 11:09:21 +0100
Subject: container: T2216: use defaultValue XML definition to define port
 protocol

Instead of hardcoding the default protocol as TCP in the Python script we shall
use the XML based defaultValue approach instead. This also automatically exports
the default to the CLI completion helper.
---
 interface-definitions/container.xml.in | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

(limited to 'interface-definitions')

diff --git a/interface-definitions/container.xml.in b/interface-definitions/container.xml.in
index d50039665..4bac305d1 100644
--- a/interface-definitions/container.xml.in
+++ b/interface-definitions/container.xml.in
@@ -207,14 +207,23 @@
               </leafNode>
               <leafNode name="protocol">
                 <properties>
-                  <help>Protocol tcp/udp</help>
+                  <help>Transport protocol used for port mapping</help>
                   <completionHelp>
                     <list>tcp udp</list>
                   </completionHelp>
+                  <valueHelp>
+                    <format>tcp</format>
+                    <description>Use Transmission Control Protocol for given port</description>
+                  </valueHelp>
+                  <valueHelp>
+                    <format>udp</format>
+                    <description>Use User Datagram Protocol for given port</description>
+                  </valueHelp>
                   <constraint>
                     <regex>(tcp|udp)</regex>
                   </constraint>
                 </properties>
+                <defaultValue>tcp</defaultValue>
               </leafNode>
             </children>
           </tagNode>
-- 
cgit v1.2.3