From b83fed095c418d27a08309af2d6bf50c11505117 Mon Sep 17 00:00:00 2001
From: hagbard <vyosdev@derith.de>
Date: Fri, 28 Jun 2019 12:39:40 -0700
Subject: [IPoE] config structure improved

  * fixed minor issues
  * fixed lower function for mac addresses if user capitalized it (local mode only)
  * added some checks to verify()
  * cli ip-address checks on input
---
 interface-definitions/ipoe-server.xml | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

(limited to 'interface-definitions')

diff --git a/interface-definitions/ipoe-server.xml b/interface-definitions/ipoe-server.xml
index 18968a033..4884b5915 100644
--- a/interface-definitions/ipoe-server.xml
+++ b/interface-definitions/ipoe-server.xml
@@ -244,6 +244,13 @@
                     <leafNode name="nas-ip-address">
                       <properties>
                         <help>Value to send to RADIUS server in NAS-IP-Address attribute and to be matched in DM/CoA requests. Also DM/CoA server will bind to that address.</help>
+                        <valueHelp>
+                          <format>ipv4</format>
+                          <description>IPv4 address of the DAE Server</description>
+                        </valueHelp>
+                        <constraint>
+                          <validator name="ipv4-address"/>
+                        </constraint>
                       </properties>
                     </leafNode>
                     <node name="dae-server">
@@ -254,11 +261,25 @@
                         <leafNode name="ip-address">
                           <properties>
                             <help>IP address for Dynamic Authorization Extension server (DM/CoA)</help>
+                            <valueHelp>
+                              <format>ipv4</format>
+                              <description>IPv4 address of the DAE Server</description>
+                            </valueHelp>
+                            <constraint>
+                              <validator name="ipv4-address"/>
+                            </constraint>
                           </properties>
                         </leafNode>
                         <leafNode name="port">
                           <properties>
                             <help>Port for Dynamic Authorization Extension server (DM/CoA)</help>
+                            <valueHelp>
+                              <format>number</format>
+                                <description>port number</description>
+                            </valueHelp>
+                            <constraint>
+                              <validator name="numeric" argument="--range 1-65535"/>
+                            </constraint>
                           </properties>
                         </leafNode>
                         <leafNode name="secret">
-- 
cgit v1.2.3