From b85755383b2a4c76b0ad557e1f6396162dd6f937 Mon Sep 17 00:00:00 2001
From: Indrajit Raychaudhuri <irc@indrajit.com>
Date: Fri, 9 Jun 2023 10:52:38 -0500
Subject: dns: T5144: Support dynamic dns monitor and log via journalctl

Add support for monitoring dynamic dns updates via journalctl.
Additionally, switch to using journalctl to show dynamic dns updates.

Also add/adjust the CLI help messages for consistency.
---
 op-mode-definitions/dns-dynamic.xml.in | 35 ++++++++++++++++++++++++++++++----
 1 file changed, 31 insertions(+), 4 deletions(-)

(limited to 'op-mode-definitions/dns-dynamic.xml.in')

diff --git a/op-mode-definitions/dns-dynamic.xml.in b/op-mode-definitions/dns-dynamic.xml.in
index 8047d55cd..4f0399964 100644
--- a/op-mode-definitions/dns-dynamic.xml.in
+++ b/op-mode-definitions/dns-dynamic.xml.in
@@ -1,16 +1,40 @@
 <?xml version="1.0"?>
 <interfaceDefinition>
+  <node name="monitor">
+    <children>
+      <node name="log">
+        <children>
+          <node name="dns">
+            <properties>
+              <help>Monitor last lines of Domain Name System (DNS) related services</help>
+            </properties>
+            <children>
+              <node name="dynamic">
+                <properties>
+                  <help>Monitor last lines of Dynamic DNS update service</help>
+                </properties>
+                <command>journalctl --no-hostname --follow --boot --unit ddclient.service</command>
+              </node>
+            </children>
+          </node>
+        </children>
+      </node>
+    </children>
+  </node>
   <node name="show">
     <children>
       <node name="log">
         <children>
           <node name="dns">
+            <properties>
+              <help>Show log for Domain Name System (DNS) related services</help>
+            </properties>
             <children>
               <node name="dynamic">
                 <properties>
-                  <help>Show log for dynamic DNS</help>
+                  <help>Show log for Dynamic DNS update service</help>
                 </properties>
-                <command>cat $(printf "%s\n" /var/log/messages* | sort -nr) | grep -e "ddclient"</command>
+                <command>journalctl --no-hostname --boot --unit ddclient.service</command>
               </node>
             </children>
           </node>
@@ -18,7 +42,7 @@
       </node>
       <node name="dns">
         <properties>
-          <help>Show DNS information</help>
+          <help>Show Domain Name System (DNS) related information</help>
         </properties>
         <children>
           <node name="dynamic">
@@ -41,6 +65,9 @@
   <node name="restart">
     <children>
       <node name="dns">
+        <properties>
+          <help>Restart specific Domain Name System (DNS) related service</help>
+        </properties>
         <children>
           <node name="dynamic">
             <properties>
@@ -59,7 +86,7 @@
     <children>
       <node name="dns">
         <properties>
-          <help>Update DNS information</help>
+          <help>Update Domain Name System (DNS) related information</help>
         </properties>
         <children>
           <node name="dynamic">
-- 
cgit v1.2.3