From 36adc975316b8511c53c813b7542196e3d2779a8 Mon Sep 17 00:00:00 2001
From: Christian Breunig <christian@breunig.cc>
Date: Mon, 23 Jan 2023 17:45:20 +0100
Subject: op-mode: T4952: improve interface completion helper CLI experience

There are currently two ways to generate the interface name completion helper
list (we use openvpn in this example)

- <script> ${vyos_completion_dir}/list_interfaces.py --type openvpn</script>
- <path>interfaces openvpn</path>

The first one using <script> tends to be rather slow as there is a Python
interpreter startup involved (expensive). The latter simply calls a C program
which is executed rather fast and gives the same result.

We can simply replace the first call with the second one to make the CLI
feel faster.
---
 op-mode-definitions/openvpn.xml.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'op-mode-definitions/openvpn.xml.in')

diff --git a/op-mode-definitions/openvpn.xml.in b/op-mode-definitions/openvpn.xml.in
index b2763da81..0a2657398 100644
--- a/op-mode-definitions/openvpn.xml.in
+++ b/op-mode-definitions/openvpn.xml.in
@@ -20,7 +20,7 @@
             <properties>
               <help>Reset OpenVPN process on interface</help>
               <completionHelp>
-                <script>sudo ${vyos_completion_dir}/list_interfaces.py --type openvpn</script>
+                <path>interfaces openvpn</path>
               </completionHelp>
             </properties>
             <command>sudo ${vyos_op_scripts_dir}/openvpn.py reset --interface $4</command>
@@ -51,7 +51,7 @@
             <properties>
               <help>Show OpenVPN interface information</help>
               <completionHelp>
-                <script>sudo ${vyos_completion_dir}/list_interfaces.py --type openvpn</script>
+                <path>interfaces openvpn</path>
               </completionHelp>
             </properties>
             <command>${vyos_op_scripts_dir}/interfaces.py show --intf_name=$4</command>
-- 
cgit v1.2.3