From 5644809bb4384de8e409042d803d1898124178e1 Mon Sep 17 00:00:00 2001 From: Christian Poessinger Date: Wed, 24 Jun 2020 09:44:01 +0200 Subject: ifconfig: vxlan: T2629: append() takes exactly one argument Commit 9390988709 ("vxlan: T2629: fix multiple configuration issues") called append() on a list and passed two arguments which is invalid. Traceback (most recent call last): File "/usr/libexec/vyos/conf_mode/interfaces-vxlan.py", line 300, in apply(c) File "/usr/libexec/vyos/conf_mode/interfaces-vxlan.py", line 245, in apply v = VXLANIf(vxlan['intf'], **conf) File "/usr/lib/python3/dist-packages/vyos/ifconfig/interface.py", line 221, in __init__ self._create() File "/usr/lib/python3/dist-packages/vyos/ifconfig/vxlan.py", line 84, in _create cmdline.append('group', 'src_interface') TypeError: append() takes exactly one argument (2 given) --- python/vyos/ifconfig/vxlan.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'python') diff --git a/python/vyos/ifconfig/vxlan.py b/python/vyos/ifconfig/vxlan.py index cd9026bf8..973b4ef05 100644 --- a/python/vyos/ifconfig/vxlan.py +++ b/python/vyos/ifconfig/vxlan.py @@ -71,7 +71,7 @@ class VXLANIf(Interface): } def _create(self): - cmdline = ['ifname', 'type', 'vni', 'port'] + cmdline = ['ifname', 'type', 'vni', 'port'] if self.config['src_address']: cmdline.append('src_address') @@ -81,11 +81,13 @@ class VXLANIf(Interface): if self.config['group'] or self.config['src_interface']: if self.config['group'] and self.config['src_interface']: - cmdline.append('group', 'src_interface') + cmdline.append('group') + cmdline.append('src_interface') else: ifname = self.config['ifname'] raise ConfigError( - f'VXLAN "{ifname}" is missing mandatory underlay multicast group or source interface for a multicast network.') + f'VXLAN "{ifname}" is missing mandatory underlay multicast' + 'group or source interface for a multicast network.') cmd = 'ip link' for key in cmdline: -- cgit v1.2.3