From 02471a8b893b699c7e5ba49a20beb239c52b7226 Mon Sep 17 00:00:00 2001 From: Christian Breunig Date: Thu, 6 Aug 2026 21:59:21 +0200 Subject: ethtool: T3871: honor the unsupported-driver denylist for flow-control too Flow-control commits failed intermittently on virtio_net and similar paravirtualized drivers: they support reading pause parameters but not setting them, and that mismatch varies across kernel/QEMU versions. The existing denylist for this already covered speed/duplex changes and its name implied flow-control too, but nothing actually consulted it there - the check relied solely on a live probe. The paired smoketest branched on that same raw probe instead of the fixed capability check, so it missed the same drivers. Assisted-by: Claude:claude-sonnet-5 --- python/vyos/ethtool.py | 2 ++ 1 file changed, 2 insertions(+) (limited to 'python') diff --git a/python/vyos/ethtool.py b/python/vyos/ethtool.py index 85e228ede..688fa3249 100644 --- a/python/vyos/ethtool.py +++ b/python/vyos/ethtool.py @@ -217,6 +217,8 @@ class Ethtool: def check_flow_control(self): """ Check if the NIC supports flow-control """ + if self.get_driver_name() in _drivers_without_speed_duplex_flow: + return False return bool(self._flow_control) def get_flow_control(self): -- cgit v1.2.3