From 4995a58f998d3bdd055e49e919945bc0aa939be4 Mon Sep 17 00:00:00 2001 From: Christian Breunig Date: Mon, 20 Oct 2025 18:52:10 +0200 Subject: T7948: always call setUp() and tearDown() base class methods While working on task T7664 (FRR 10.4 upgrade), I identified the need for additional validation and safeguards around the FRR management daemon. The most appropriate place for this logic is in the setUp() and tearDown() methods of the smoketest base class, VyOSUnitTestSHIM. However, during implementation, it became apparent that test cases do not consistently invoke the base class's setup and teardown methods. This inconsistency complicates the process of capturing the FRR mgmtd PID at the start of a test and verifying that it remains unchanged by the end - a key step in detecting crashes or unexpected terminations (e.g., SIGSEGV) of the FRR management daemon during tests. --- smoketest/scripts/cli/test_service_https.py | 2 ++ 1 file changed, 2 insertions(+) (limited to 'smoketest/scripts/cli/test_service_https.py') diff --git a/smoketest/scripts/cli/test_service_https.py b/smoketest/scripts/cli/test_service_https.py index df7657685..7fee7158d 100755 --- a/smoketest/scripts/cli/test_service_https.py +++ b/smoketest/scripts/cli/test_service_https.py @@ -113,6 +113,8 @@ class TestHTTPSService(VyOSUnitTestSHIM.TestCase): # Check for stopped process self.assertFalse(process_named_running(PROCESS_NAME)) + # always forward to base class + super().tearDown() def test_listen_address(self): test_prefix = ['192.0.2.1/26', '2001:db8:1::ffff/64'] -- cgit v1.2.3