From 02a3e26e88f0ac3c7368e288769bfed38b41df46 Mon Sep 17 00:00:00 2001 From: Christian Breunig Date: Tue, 21 Nov 2023 21:18:17 +0100 Subject: smoketest: macsec: T5770: fix NameError: name 'cipher' is not defined --- smoketest/scripts/cli/test_interfaces_macsec.py | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) (limited to 'smoketest') diff --git a/smoketest/scripts/cli/test_interfaces_macsec.py b/smoketest/scripts/cli/test_interfaces_macsec.py index 6e57fdfd4..d8d564792 100755 --- a/smoketest/scripts/cli/test_interfaces_macsec.py +++ b/smoketest/scripts/cli/test_interfaces_macsec.py @@ -22,10 +22,10 @@ from netifaces import interfaces from vyos.configsession import ConfigSessionError from vyos.ifconfig import Section -from vyos.utils.process import cmd from vyos.utils.file import read_file from vyos.utils.network import get_interface_config from vyos.utils.network import interface_exists +from vyos.utils.process import cmd from vyos.utils.process import process_named_running PROCESS_NAME = 'wpa_supplicant' @@ -138,7 +138,7 @@ class MACsecInterfaceTest(BasicInterfaceTest.TestCase): # final commit and verify self.cli_commit() - self.assertIn(interface, interfaces()) + self.assertTrue(interface_exists(interface)) # Verify proper cipher suite (T4537) tmp = get_interface_config(interface) @@ -162,7 +162,7 @@ class MACsecInterfaceTest(BasicInterfaceTest.TestCase): # final commit and verify self.cli_commit() - self.assertIn(interface, interfaces()) + self.assertTrue(interface_exists(interface)) # Verify proper cipher suite (T4537) tmp = get_interface_config(interface) @@ -193,7 +193,7 @@ class MACsecInterfaceTest(BasicInterfaceTest.TestCase): # final commit and verify self.cli_commit() - self.assertIn(interface, interfaces()) + self.assertTrue(interface_exists(interface)) def test_macsec_static_keys(self): src_interface = 'eth0' @@ -263,11 +263,10 @@ class MACsecInterfaceTest(BasicInterfaceTest.TestCase): # final commit and verify self.cli_commit() - self.assertIn(interface, interfaces()) - self.assertTrue(interface_exists(interface)) + self.assertTrue(interface_exists(interface)) tmp = get_interface_config(interface) - self.assertEqual(cipher, tmp['linkinfo']['info_data']['cipher_suite'].lower()) + self.assertEqual(cipher2, tmp['linkinfo']['info_data']['cipher_suite'].lower()) # Encryption enabled? self.assertTrue(tmp['linkinfo']['info_data']['encrypt']) -- cgit v1.2.3