From 98a0fdbef343c20c5054abea478a81e5b86c254f Mon Sep 17 00:00:00 2001
From: Nicolas Vollmar <nvollmar@gmail.com>
Date: Fri, 19 Apr 2024 23:59:17 +0200
Subject: T6246: improve haproxy http check configuration

(cherry picked from commit 050f24770aec7a74c1a07ba64cf2cb83afb72f1a)
---
 .../cli/test_load-balancing_reverse-proxy.py       | 23 ++++++++++++++++++++--
 1 file changed, 21 insertions(+), 2 deletions(-)

(limited to 'smoketest')

diff --git a/smoketest/scripts/cli/test_load-balancing_reverse-proxy.py b/smoketest/scripts/cli/test_load-balancing_reverse-proxy.py
index 8ccf2cf97..737c07401 100755
--- a/smoketest/scripts/cli/test_load-balancing_reverse-proxy.py
+++ b/smoketest/scripts/cli/test_load-balancing_reverse-proxy.py
@@ -304,15 +304,34 @@ class TestLoadBalancingReverseProxy(VyOSUnitTestSHIM.TestCase):
 
       # Set http-check
       self.cli_set(base_path + ['backend', 'bk-01', 'http-check', 'method', 'get'])
-      self.cli_set(base_path + ['backend', 'bk-01', 'http-check', 'uri', '/health'])
-      self.cli_set(base_path + ['backend', 'bk-01', 'http-check', 'expect', 'status 200'])
       self.cli_commit()
 
       # Test http-check
       config = read_file(HAPROXY_CONF)
       self.assertIn('option httpchk', config)
+      self.assertIn('http-check send meth GET', config)
+
+      # Set http-check with uri and status
+      self.cli_set(base_path + ['backend', 'bk-01', 'http-check', 'uri', '/health'])
+      self.cli_set(base_path + ['backend', 'bk-01', 'http-check', 'expect', 'status', '200'])
+      self.cli_commit()
+
+      # Test http-check with uri and status
+      config = read_file(HAPROXY_CONF)
+      self.assertIn('option httpchk', config)
       self.assertIn('http-check send meth GET uri /health', config)
       self.assertIn('http-check expect status 200', config)
 
+      # Set http-check with string
+      self.cli_delete(base_path + ['backend', 'bk-01', 'http-check', 'expect', 'status', '200'])
+      self.cli_set(base_path + ['backend', 'bk-01', 'http-check', 'expect', 'string', 'success'])
+      self.cli_commit()
+
+      # Test http-check with string
+      config = read_file(HAPROXY_CONF)
+      self.assertIn('option httpchk', config)
+      self.assertIn('http-check send meth GET uri /health', config)
+      self.assertIn('http-check expect string success', config)
+
 if __name__ == '__main__':
     unittest.main(verbosity=2)
-- 
cgit v1.2.3