From 713647429b981f35822e8b4c9fafe990d120643c Mon Sep 17 00:00:00 2001 From: Christian Breunig Date: Tue, 3 Oct 2023 20:51:21 +0200 Subject: pppoe: T5630: verify MRU is less or equal then MTU (cherry picked from commit e357258e645cf85de0035d4ecfbf99db4dd90f7e) --- src/conf_mode/interfaces-pppoe.py | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'src/conf_mode/interfaces-pppoe.py') diff --git a/src/conf_mode/interfaces-pppoe.py b/src/conf_mode/interfaces-pppoe.py index fca91253c..0a03a172c 100755 --- a/src/conf_mode/interfaces-pppoe.py +++ b/src/conf_mode/interfaces-pppoe.py @@ -77,6 +77,11 @@ def verify(pppoe): if {'connect_on_demand', 'vrf'} <= set(pppoe): raise ConfigError('On-demand dialing and VRF can not be used at the same time') + # both MTU and MRU have default values, thus we do not need to check + # if the key exists + if int(pppoe['mru']) > int(pppoe['mtu']): + raise ConfigError('PPPoE MRU needs to be lower then MTU!') + return None def generate(pppoe): -- cgit v1.2.3