From 0206a0bb8233a678be3dcc89d842f2367ec9dfc3 Mon Sep 17 00:00:00 2001 From: John Estabrook Date: Sun, 6 Aug 2023 19:41:17 -0500 Subject: T5319: remove workarounds for defaults in service_upnp.py --- src/conf_mode/service_upnp.py | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) (limited to 'src/conf_mode/service_upnp.py') diff --git a/src/conf_mode/service_upnp.py b/src/conf_mode/service_upnp.py index b37d502c2..cf26bf9ce 100755 --- a/src/conf_mode/service_upnp.py +++ b/src/conf_mode/service_upnp.py @@ -23,12 +23,10 @@ from ipaddress import IPv4Network from ipaddress import IPv6Network from vyos.config import Config -from vyos.configdict import dict_merge from vyos.utils.process import call from vyos.template import render from vyos.template import is_ipv4 from vyos.template import is_ipv6 -from vyos.xml import defaults from vyos import ConfigError from vyos import airbag airbag.enable() @@ -47,10 +45,7 @@ def get_config(config=None): if not upnpd: return None - if 'rule' in upnpd: - default_member_values = defaults(base + ['rule']) - for rule,rule_config in upnpd['rule'].items(): - upnpd['rule'][rule] = dict_merge(default_member_values, upnpd['rule'][rule]) + upnpd = conf.merge_defaults(upnpd, recursive=True) uuidgen = uuid.uuid1() upnpd.update({'uuid': uuidgen}) -- cgit v1.2.3