From 4e11adfb927c22e2f977c897d56a4d243860e877 Mon Sep 17 00:00:00 2001 From: Oleksandr Kuchmystyi Date: Fri, 26 Jun 2026 10:23:54 +0300 Subject: bgp: T8865: Reject `vni` sub-block in VRF l2vpn-evpn when `advertise-all-vni` is globally active When `advertise-all-vni` is configured in the global/default BGP instance, VyOS generated a `vni ` sub-block under each VRF BGP `address-family l2vpn evpn` context. This conflicts with advertise-all-vni: FRR already owns all kernel VNIs and returns `% Failed to create VNI` when frr-reload.py attempts to apply the VRF-level vni sub-block. FRR then performs an early exit from config processing, silently dropping the entire l2vpn evpn address-family for all subsequent VRF BGP instances. --- src/conf_mode/protocols_bgp.py | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) (limited to 'src/conf_mode') diff --git a/src/conf_mode/protocols_bgp.py b/src/conf_mode/protocols_bgp.py index 2ec631f4c..bde6fcdd0 100755 --- a/src/conf_mode/protocols_bgp.py +++ b/src/conf_mode/protocols_bgp.py @@ -647,6 +647,29 @@ def verify(config_dict): if 'route_target' in vni_config and 'advertise_all_vni' not in afi_config: raise ConfigError('BGP EVPN "route-target" requires "advertise-all-vni" to be set!') + # T8865: Detect conflict between VRF-level "vni" sub-block and global + # "advertise-all-vni". When advertise-all-vni is active in the default + # BGP instance, FRR already owns all VNIs discovered from the kernel. + # Attempting to create the same VNI again via a VRF BGP "vni" sub-block + # causes FRR to return "% Failed to create VNI" and perform an early exit + # from config processing. + if vrf and 'vni' in afi_config: + default_bgp_evpn = dict_search( + 'dependent_vrfs.default.protocols.bgp.address_family.l2vpn_evpn', + bgp, + ) + if ( + default_bgp_evpn is not None + and 'deleted' not in default_bgp_evpn + ): + if 'advertise_all_vni' in default_bgp_evpn: + raise ConfigError( + 'BGP EVPN "vni" sub-configuration conflicts with ' + '"advertise-all-vni" in the default BGP instance. ' + 'Remove "vni" from the VRF l2vpn-evpn configuration ' + 'or disable "advertise-all-vni" for the default BGP.' + ) + return None def generate(config_dict): -- cgit v1.2.3