From 5f5b2808c0a647cd20fb4c94bdb3dc36d634e3f2 Mon Sep 17 00:00:00 2001
From: Christian Poessinger <christian@poessinger.com>
Date: Sat, 21 Nov 2020 00:32:21 +0100
Subject: ethernet: T3048: drop static smp-affinity for dynamic performance
 tuning

After migrating the ethernet interfaces from the good old Perl days the
smp-affinity node yet has no effect anymore as the code is still missing (my
bad, sorry).

Drop the smp-affinity node and rather use tuned instead with the
network-throughput or network-latency profile.

- network-throughput: Profile for throughput network tuning. It is based on the
  throughput-performance profile. It additionaly increases kernel network buffers.

- network-latency: Profile for low latency network tuning. It is based on the
  latency-performance profile. It additionaly disables transparent hugepages,
  NUMA balancing and tunes several other network related sysctl parameters.

I'd set network-throughput as the default on a new set system option performance
<throughput | latency> CLI node which is present in the default configuration.

https://access.redhat.com/sites/default/files/attachments/201501-perf-brief-low-latency-tuning-rhel7-v2.1.pdf
---
 src/migration-scripts/interfaces/14-to-15 | 54 +++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)
 create mode 100755 src/migration-scripts/interfaces/14-to-15

(limited to 'src/migration-scripts')

diff --git a/src/migration-scripts/interfaces/14-to-15 b/src/migration-scripts/interfaces/14-to-15
new file mode 100755
index 000000000..b170f7e4d
--- /dev/null
+++ b/src/migration-scripts/interfaces/14-to-15
@@ -0,0 +1,54 @@
+#!/usr/bin/env python3
+#
+# Copyright (C) 2020 VyOS maintainers and contributors
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 2 or later as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+# T3048: remove smp-affinity node from ethernet and use tuned instead
+
+import os
+
+from sys import exit, argv
+from vyos.configtree import ConfigTree
+
+if __name__ == '__main__':
+    if (len(argv) < 1):
+        print("Must specify file name!")
+        exit(1)
+
+    file_name = argv[1]
+    with open(file_name, 'r') as f:
+        config_file = f.read()
+
+    config = ConfigTree(config_file)
+    base = ['interfaces', 'ethernet']
+
+    migrate = False
+    for interface in config.list_nodes(base):
+        smp_base = base + [interface, 'smp-affinity']
+        # if any one interface had smp-affinity configured manually, we will
+        # configure "system option performance"
+        if config.exists(smp_base):
+            if config.return_value(smp_base) != 'auto':
+                migrate = True
+            config.delete(smp_base)
+
+    if migrate:
+        config.set(['system', 'options', 'performance'], value='throughput')
+
+    try:
+        with open(file_name, 'w') as f:
+            f.write(config.to_string())
+    except OSError as e:
+        print("Failed to save the modified config: {}".format(e))
+        exit(1)
-- 
cgit v1.2.3