From 59e5e64cfbb67a5eb1a9d4d21dd54d946897b8d7 Mon Sep 17 00:00:00 2001
From: Daniil Baturin <daniil@baturin.org>
Date: Wed, 11 Sep 2019 23:14:23 +0200
Subject: T1598: annotate the vyos-hostsd unit file.

---
 src/systemd/vyos-hostsd.service | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

(limited to 'src')

diff --git a/src/systemd/vyos-hostsd.service b/src/systemd/vyos-hostsd.service
index 2444f5352..731e570c9 100644
--- a/src/systemd/vyos-hostsd.service
+++ b/src/systemd/vyos-hostsd.service
@@ -1,6 +1,12 @@
 [Unit]
 Description=VyOS DNS configuration keeper
+
+# Without this option, lots of default dependencies are added,
+# among them network.target, which creates a dependency cycle
 DefaultDependencies=no
+
+# Seemingly sensible way to say "as early as the system is ready"
+# All vyos-hostsd needs is read/write mounted root
 After=systemd-remount-fs.service
 
 [Service]
@@ -13,9 +19,13 @@ SyslogFacility=daemon
 
 Restart=on-failure
 
-# Does't work but leave it here
+# Does't work in Jessie but leave it here
 User=root
 Group=vyattacfg
 
 [Install]
+
+# Note: After= doesn't actually create a dependency,
+# it just sets order for the case when both services are to start,
+# and without RequiredBy it *does not* set vyos-hostsd to start.
 RequiredBy=cloud-init-local.service vyos-router.service
-- 
cgit v1.2.3