summaryrefslogtreecommitdiff
path: root/src/migration-scripts/interfaces/1-to-2
blob: c95623c2bce94e10aaf12d09043a43c49dfb7574 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
#!/usr/bin/env python3

# Change syntax of bond interface
# - move interface based bond-group to actual bond (de-nest)
# https://vyos.dev/T1614

import sys
from vyos.configtree import ConfigTree

if len(sys.argv) < 2:
    print("Must specify file name!")
    sys.exit(1)

file_name = sys.argv[1]

with open(file_name, 'r') as f:
    config_file = f.read()

config = ConfigTree(config_file)
base = ['interfaces', 'bonding']

if not config.exists(base):
    # Nothing to do
    sys.exit(0)
else:
    #
    # move interface based bond-group to actual bond (de-nest)
    #
    for intf in config.list_nodes(['interfaces', 'ethernet']):
        # check if bond-group exists
        if config.exists(['interfaces', 'ethernet', intf, 'bond-group']):
            # get configured bond interface
            bond = config.return_value(['interfaces', 'ethernet', intf, 'bond-group'])
            # delete old interface asigned (nested) bond group
            config.delete(['interfaces', 'ethernet', intf, 'bond-group'])
            # create new bond member interface
            config.set(base + [bond, 'member', 'interface'], value=intf, replace=False)

    #
    # some combinations were allowed in the past from a CLI perspective
    # but the kernel overwrote them - remove from CLI to not confuse the users.
    # In addition new consitency checks are in place so users can't repeat the
    # mistake. One of those nice issues is https://vyos.dev/T532
    for bond in config.list_nodes(base):
        if config.exists(base + [bond, 'arp-monitor', 'interval']) and config.exists(base + [bond, 'mode']):
            mode = config.return_value(base + [bond, 'mode'])
            if mode in ['802.3ad', 'transmit-load-balance', 'adaptive-load-balance']:
                intvl = int(config.return_value(base + [bond, 'arp-monitor', 'interval']))
                if intvl > 0:
                    # this is not allowed and the linux kernel replies with:
                    # option arp_interval: mode dependency failed, not supported in mode 802.3ad(4)
                    # option arp_interval: mode dependency failed, not supported in mode balance-alb(6)
                    # option arp_interval: mode dependency failed, not supported in mode balance-tlb(5)
                    #
                    # so we simply disable arp_interval by setting it to 0 and miimon will take care about the link
                    config.set(base + [bond, 'arp-monitor', 'interval'], value='0')

    try:
        with open(file_name, 'w') as f:
            f.write(config.to_string())
    except OSError as e:
        print("Failed to save the modified config: {}".format(e))
        sys.exit(1)