VyOS image build scripts (mirror of https://github.com/vyos/vyos-build.git) https://git.amelek.net/vyos/vyos-build.git/atom?h=current 2025-06-10T14:43:29+00:00 2025-06-10T14:43:29+00:00 Daniil Baturin daniil@baturin.org 2025-06-10T14:43:29+00:00 urn:sha1:75f72ab9013c7ae5226497526e4db6e36dd43678 2025-06-06T18:59:22+00:00 Gabin-CC gabin.laurent@rte-international.com 2025-06-06T18:54:03+00:00 urn:sha1:02c2e306228a3de24623946499923604341884d3 Enhanced the raw image creation logic to dynamically detect and assign EFI and root partitions based on the number of partitions created by kpartx. - Supports both 2-partition and 3-partition layouts - Adds debug output for mapped partitions - Avoids hardcoded assumptions about partition order - Improves resilience in cloud-init and containerized build contexts Fixes build failure when /dev/loopXp3 is missing or not mapped properly. Signed-off-by: Gabin-CC <gabin.laurent@rte-international.com> 2025-06-06T18:58:04+00:00 Gabin-CC gabin.laurent@rte-international.com 2025-06-05T01:37:56+00:00 urn:sha1:1cda2d42bb5064868c6435c14a5d3e4b047500d8 Description This pull request introduces improvements to the raw_image.py script responsible for building raw disk images in the VyOS build process. Main Changes Added use of kpartx to reliably map EFI and root partitions from the loop device. Introduced disk_details as an attribute on the BuildContext object to pass partition metadata through the image build steps. Improved the __exit__ method for BuildContext to unmount all mount points and clean up kpartx mappings and loop devices, even in failure cases. Fixed a crash in mount_image() when con.disk_details was not set. Added useful debug logs for loop device usage and partition mapping. Motivation The previous implementation assumed partitions like /dev/loopXp3 would appear automatically, which is unreliable across some environments (especially containers or newer systems). This PR makes the process more reliable by explicitly mapping partitions with kpartx, a tool designed for this purpose. It also ensures proper resource cleanup by unmounting and detaching everything cleanly, preventing leaked loop devices or stale mount points. Test Instructions Flavor : cloud-init.toml packages = [ "cloud-init", "qemu-guest-agent" ] image_format = ["qcow2"] disk_size = 10 [boot_settings] console_type = "ttyS0" Run: sudo ./build-vyos-image --architecture amd64 \ --build-by "you@example.com" \ --reuse-iso vyos-1.5-rolling-*.iso \ cloud-init Expected behavior: The build completes without errors. The .qcow2 image file is generated and bootable (e.g., in KVM or Proxmox). Partitions are mounted correctly via /dev/mapper/loopXp*. Signed-off-by: Gabin-CC <gabin.laurent@rte-international.com> 2025-04-29T14:23:12+00:00 Daniil Baturin daniil@vyos.io 2025-04-29T14:23:12+00:00 urn:sha1:65f3b103a5b3127fbd39b21efc4026073fa53082 build: T7409: do not include MD5 checksums in the ISO image 2025-04-28T17:27:58+00:00 Daniil Baturin daniil@baturin.org 2025-04-28T17:27:58+00:00 urn:sha1:64ff1e538d09b0859b1b3f8e5adc8529bcea2919 2025-04-25T18:45:03+00:00 Daniil Baturin daniil@baturin.org 2025-04-25T18:41:18+00:00 urn:sha1:1f400a4b01aa19ab240b34fab19b78a53f3f9bc1 It doesn't appear necessary anymore, if it ever was 2025-04-18T12:04:44+00:00 Daniil Baturin daniil@baturin.org 2025-04-18T12:04:44+00:00 urn:sha1:2986466f7b7550c142eaa5a0c03a3505d8bf3706 2025-03-18T15:19:39+00:00 Christian Breunig christian@breunig.cc 2025-03-16T19:10:09+00:00 urn:sha1:a02b10b2ba4197c4dcd84eef053e4ab94995295b 2025-03-18T15:19:39+00:00 Christian Breunig christian@breunig.cc 2025-03-16T19:07:49+00:00 urn:sha1:8d58a72368e6462fb464dad88bbc97599476b863 2025-01-30T14:14:17+00:00 Daniil Baturin daniil@baturin.org 2025-01-30T14:14:17+00:00 urn:sha1:f11b5a3282c2374994f4460b7bfd9bd23f628194