vyos-cloud-init.git, branch 22.1

Release 22.1 (#1267)

2022-02-15T18:59:19+00:00

Bump the version in cloudinit/version.py to 22.1 and update ChangeLog. LP: #1960939

sources/azure: report ready in local phase (#1265)

2022-02-15T17:19:19+00:00

Pre-provisioned instances report ready early in the local phase and again in the non-local phase, during setup(). Non-PPS only reports ready during non-local phase. Update the process to report ready during the local phase for all cases. Only attempt to do so if networking is up to prevent stalling boot. We've already waited at least 20 minutes for DHCP if we're provisioning, or 5 minutes for DHCP on normal boot requesting updated network configuration. - Extend _report_ready() with pubkey_info and raise exception on error to consolidate reporting done in _negotiate() and _report_ready(). - Remove setup(), moving relevant logic into crawl_metadata(). - Move remaining _negotiate() logic into _cleanup_markers() and _determine_wireserver_pubkey_info(). These changes effectively fix two issues that were present: (1) _negotiated is incorrectly set to True When failing to report ready. _negotiate() squashed the exception and the return value was not checked. This was probably masked due to the forced removal of obj.pkl on Ubuntu instances, but would be preferable once we start persisting it to prevent unnecessary re-negotiation. (2) provisioning media is not ejected for non-PPS _negotiate() did not pass iso_dev parameter when reporting ready. The host will ensure this operation takes place, but it is preferable to eject /dev/sr0 from within the guest when we're done with it. Lastly, this removes any need for lease file parsing as the wireserver addressed is tracked for ephemeral DHCP. A follow-up PR will remove this now-unused logic. Signed-off-by: Chris Patterson

sources/azure: validate IMDS network configuration metadata (#1257)

2022-02-14T19:53:36+00:00

Due to race conditions and caching, IMDS may return stale or incomplete metadata. Add some validation to detect these scenarios and report appropriate telemetry. Introduce normalize_mac_address() to allow for comparison of mac addresses, replacing that found inline in: _generate_network_config_from_imds_metadata() Add validation of final fetch of IMDS metadata. Signed-off-by: Chris Patterson

docs: Add more details to runcmd docs (#1266)

2022-02-14T19:25:10+00:00

use PEP 589 syntax for TypeDict (#1253)

2022-02-14T19:24:00+00:00

Use PEP 589 syntax for TypeDict annotation. Also fixes previously broken typing MetaSchema typing implementation.

mypy: introduce type checking (#1254)

2022-02-14T17:09:01+00:00

All currently failing modules are excluded from reporting errors using follow-imports=silent and an exclusion list. Future work can whittle down this failing list. This change will start enforcing new modules and those currently passing. Includes some minor alphabetical reordering in tox.ini. Signed-off-by: Chris Patterson

Fix extra ipv6 issues, code reduction and simplification (#1243)

2022-02-14T17:00:12+00:00

Eliminated the duplicate code and now run the entire configuration routine against both public and private interfaces. Also addressed an inconsistency from our metadata api for ipv6 address configuration.

tests: when generating crypted password, generate in target env (#1252)

2022-02-14T15:51:03+00:00

There are inconsistencies for cryptographic libraries across major distribution releases. From a bionic host, which doesn't support yescrypt hashing scheme, attempting run run crypt.crypt locally using a yescrypt hash from a Jammmy /etc/shadow file will result in failure to produce an encrypted password. For "unsupported" hash schemes, crypt.crypt returns None. To avoid inconsistencies of python cryptographic libs across Linux releases, perform the password encryption on the system under test.

sources/azure: address mypy/pyright typing complaints (#1245)

2022-02-12T04:40:45+00:00

Raise runtime errors for unhandled cases which would cause other exceptions. Ignore types for a few cases where a non-trivial refactor would be required to prevent the warning. Signed-off-by: Chris Patterson

Docs for x-shellscript* userdata (#1260)

2022-02-12T02:02:11+00:00