(mirror of https://github.com/vyos/vyos-cloud-init.git) https://git.amelek.net/vyos/vyos-cloud-init.git/atom?h=circinus-public-unmaintained 2022-02-14T19:24:00+00:00 2022-02-14T19:24:00+00:00 Brett Holman bholman.devel@gmail.com 2022-02-14T19:24:00+00:00 urn:sha1:50195ec8d1052d2b7a80f47a3709ebc4e74d6764 Use PEP 589 syntax for TypeDict annotation. Also fixes previously broken typing MetaSchema typing implementation. 2021-12-16T02:16:38+00:00 James Falcon james.falcon@canonical.com 2021-12-16T02:16:38+00:00 urn:sha1:bae9b11da9ed7dd0b16fe5adeaf4774b7cc628cf Applied Black and isort, fixed any linting issues, updated tox.ini and CI. 2021-12-06T22:27:12+00:00 Brett Holman bholman.devel@gmail.com 2021-12-06T22:27:12+00:00 urn:sha1:bedac77e9348e7a54c0ec364fb61df90cd893972 Improve schema validation. This adds strict validation of config module definitions at testing time, with plumbing included for future runtime validation. This eliminates a class of bugs resulting from schemas that have definitions that are incorrect, but get interpreted by jsonschema as "additionalProperties" that are therefore ignored. - Add strict meta-schema for jsonschema unit test validation - Separate schema from module metadata structure - Improve type annotations for various functions and data types Cleanup: - Remove unused jsonschema "required" elements - Eliminate manual memoization in schema.py:get_schema(), reference module.__doc__ directly 2020-06-08T16:49:12+00:00 Scott Moser smoser@brickies.net 2020-06-08T16:49:12+00:00 urn:sha1:3c551f6ebc12f7729a2755c89b19b9000e27cc88 This was painful, but it finishes a TODO from cloudinit/subp.py. It moves the following from util to subp: ProcessExecutionError subp which target_path I moved subp_blob_in_tempfile into cc_chef, which is its only caller. That saved us from having to deal with it using write_file and temp_utils from subp (which does not import any cloudinit things now). It is arguable that 'target_path' could be moved to a 'path_utils' or something, but in order to use it from subp and also from utils, we had to get it out of utils. 2020-05-21T15:16:35+00:00 Daniel Watkins oddbloke@ubuntu.com 2020-05-21T15:16:35+00:00 urn:sha1:98a6d9a0da82a764943c9495d7f21f3acc5ccd05 And add an example of providing a list of assertions. 2020-05-18T17:30:27+00:00 Daniel Watkins oddbloke@ubuntu.com 2020-05-18T17:30:27+00:00 urn:sha1:8bcf1c069d8ddf28898342e541254bdeb54445df Specifically, ensure that given values are either strings, or arrays of strings. 2020-05-06T20:19:35+00:00 lucasmoura lucas.moura@canonical.com 2020-05-06T20:19:35+00:00 urn:sha1:022122a54e895468d054ed162fdf1b403b7aaf3f Add a unit test to validate if the examples provided in the config modules are conforming to the concatenated schema of all config modules. The rationale behind that is not only to verify if the examples are correctly written but to assert that no config schema is interfering with each other. Failures in validate_cloudconfig_schema raise the SchemaValidationError by using strict=True, so I have only called the function passing the right schema examples to validate. This branch also fixes an invalid schema example in cc_snap. LP: #1876412 2018-04-20T03:30:08+00:00 Scott Moser smoser@ubuntu.com 2018-04-20T03:30:08+00:00 urn:sha1:1081962eacf2814fea6f4fa3255c530de14e4a24 This enables warnings produced by pylint for unused variables (W0612), and fixes the existing errors. 2018-04-19T02:37:07+00:00 Scott Moser smoser@ubuntu.com 2018-04-19T02:37:07+00:00 urn:sha1:6811926fdb991ad02ad9c0134c1d4bbe82ef87e1 runcmd, bootcmd, snap/commands, ubuntu-advantage/commands would log warning (and fail if strict) on duplicate values in the commands. But those should be allowed. Example, it is perfectly valid to do: runcmd: ['sleep 1', 'sleep 1'] LP: #1764264 2018-03-23T01:13:06+00:00 Chad Smith chad.smith@canonical.com 2018-03-23T01:13:06+00:00 urn:sha1:0d51e912146b3031c458ce415b7d4cd6eb17d06e ubuntu-advantage-tools is a package for enabling and disabling extended support services such as Extended Security Maintenance (ESM), Canonical Livepatch and FIPS certified PPAs. Simplify Ubuntu Advantage setup on machines by allowing users to provide a list of ubuntu-advantage commands in cloud-config.