(mirror of https://github.com/vyos/vyos-cloud-init.git) https://git.amelek.net/vyos/vyos-cloud-init.git/atom?h=rolling 2021-12-03T20:11:46+00:00 2021-12-03T20:11:46+00:00 Brett Holman bholman.devel@gmail.com 2021-12-03T20:11:46+00:00 urn:sha1:039c40f9b3d88ee8158604bb18ca4bf2fb5d5e51 This attempts to standardize unit test file location under test/unittests/ such that any source file located at cloudinit/path/to/file.py may have a corresponding unit test file at test/unittests/path/to/test_file.py. Noteworthy Comments: ==================== Four different duplicate test files existed: test_{gpg,util,cc_mounts,cc_resolv_conf}.py Each of these duplicate file pairs has been merged together. This is a break in git history for these files. The test suite appears to have a dependency on test order. Changing test order causes some tests to fail. This should be rectified, but for now some tests have been modified in tests/unittests/config/test_set_passwords.py. A helper class name starts with "Test" which causes pytest to try executing it as a test case, which then throws warnings "due to Class having __init__()". Silence by changing the name of the class. # helpers.py is imported in many test files, import paths change cloudinit/tests/helpers.py -> tests/unittests/helpers.py # Move directories: cloudinit/distros/tests -> tests/unittests/distros cloudinit/cmd/devel/tests -> tests/unittests/cmd/devel cloudinit/cmd/tests -> tests/unittests/cmd/ cloudinit/sources/helpers/tests -> tests/unittests/sources/helpers cloudinit/sources/tests -> tests/unittests/sources cloudinit/net/tests -> tests/unittests/net cloudinit/config/tests -> tests/unittests/config cloudinit/analyze/tests/ -> tests/unittests/analyze/ # Standardize tests already in tests/unittests/ test_datasource -> sources test_distros -> distros test_vmware -> sources/vmware test_handler -> config # this contains cloudconfig module tests test_runs -> runs 2020-06-08T16:49:12+00:00 Scott Moser smoser@brickies.net 2020-06-08T16:49:12+00:00 urn:sha1:3c551f6ebc12f7729a2755c89b19b9000e27cc88 This was painful, but it finishes a TODO from cloudinit/subp.py. It moves the following from util to subp: ProcessExecutionError subp which target_path I moved subp_blob_in_tempfile into cc_chef, which is its only caller. That saved us from having to deal with it using write_file and temp_utils from subp (which does not import any cloudinit things now). It is arguable that 'target_path' could be moved to a 'path_utils' or something, but in order to use it from subp and also from utils, we had to get it out of utils. 2020-05-21T15:16:35+00:00 Daniel Watkins oddbloke@ubuntu.com 2020-05-21T15:16:35+00:00 urn:sha1:98a6d9a0da82a764943c9495d7f21f3acc5ccd05 And add an example of providing a list of assertions. 2020-05-18T17:30:27+00:00 Daniel Watkins oddbloke@ubuntu.com 2020-05-18T17:30:27+00:00 urn:sha1:8bcf1c069d8ddf28898342e541254bdeb54445df Specifically, ensure that given values are either strings, or arrays of strings. 2020-05-14T19:39:19+00:00 Daniel Watkins oddbloke@ubuntu.com 2020-05-14T19:39:19+00:00 urn:sha1:09492b1d0f4b1826a7a98709c61d48bf14a1ec64 We recently discovered that pylint is failing to report some errors when invoked across our entire codebase (see https://github.com/PyCQA/pylint/issues/3611). I've run pylint across every Python file under cloudinit/[0], and this commit fixes the issues so-discovered. [0] find cloudinit/ -name "*.py" | xargs -n 1 -t .tox/pylint/bin/python -m pylint 2020-01-31T15:15:31+00:00 Daniel Watkins oddbloke@ubuntu.com 2020-01-31T15:15:31+00:00 urn:sha1:1bb1896ec900622e02c1ffb59db4d3f2df4a964d 2018-09-05T16:02:25+00:00 Scott Moser smoser@ubuntu.com 2018-09-05T16:02:25+00:00 urn:sha1:a8dcad9ac62bb1d2a4f7489960395bad6cac9382 In many cases, cloud-init uses 'util.subp' to run a subprocess. This is not really desirable in our unit tests as it makes the tests dependent upon existance of those utilities. The change here is to modify the base test case class (CiTestCase) to raise exception any time subp is called. Then, fix all callers. For cases where subp is necessary or actually desired, we can use it via   a.) context hander CiTestCase.allow_subp(value)   b.) class level self.allowed_subp = value Both cases the value is a list of acceptable executable names that will be called (essentially argv[0]). Some cleanups in AltCloud were done as the code was being updated. 2018-04-21T00:25:48+00:00 Scott Moser smoser@ubuntu.com 2018-04-21T00:25:48+00:00 urn:sha1:5037252ca5dc54c6d978b23dba063ac5fabc98fa validate_cloudconfig_schema with strict=True would not actually validate if there was no jsonschema available. That seems kind of strange. The change here is to make it raise an exception if strict was passed in. And then to fix the one test that needed a skipIfJsonSchema wrapper. 2018-04-19T02:37:07+00:00 Scott Moser smoser@ubuntu.com 2018-04-19T02:37:07+00:00 urn:sha1:6811926fdb991ad02ad9c0134c1d4bbe82ef87e1 runcmd, bootcmd, snap/commands, ubuntu-advantage/commands would log warning (and fail if strict) on duplicate values in the commands. But those should be allowed. Example, it is perfectly valid to do: runcmd: ['sleep 1', 'sleep 1'] LP: #1764264 2018-03-23T19:16:55+00:00 Scott Moser smoser@ubuntu.com 2018-03-23T19:16:55+00:00 urn:sha1:0c2f1ea29abc88957d21f56d432649989a8e4dfd The recently added snap and ubuntu_advantage modules had unit tests that exercised jsonschema. Those throw error if jsonschema is not present. Fix to skip in that scenario.