(mirror of https://github.com/vyos/vyos-cloud-init.git) https://git.amelek.net/vyos/vyos-cloud-init.git/atom?h=feature%2FT9082-codeql-onboard 2021-12-16T02:16:38+00:00 2021-12-16T02:16:38+00:00 James Falcon james.falcon@canonical.com 2021-12-16T02:16:38+00:00 urn:sha1:bae9b11da9ed7dd0b16fe5adeaf4774b7cc628cf Applied Black and isort, fixed any linting issues, updated tox.ini and CI. 2021-07-20T14:58:21+00:00 Paride Legovini paride.legovini@canonical.com 2021-07-20T14:58:21+00:00 urn:sha1:ec6afadbf0f0f77d5b58dccd70df77da89c2c91d In CI run against pylint 2.9.3 and fix occurrences of: - W0237 (arguments-renamed) - W0402 (deprecated-module) The W0402 deprecated-module was about module `imp`: cloudinit/patcher.py:9: [W0402(deprecated-module), ] Uses of a deprecated module 'imp' The imp module is deprecated and replaced by importlib, which according to the documentation has no replacement for acquire_lock() and release_lock(), which are the only reason why `imp` is imported. Nothing about the code using this lock that actually requires it. Let's remove the locking code and the import altogether. Dropping the locking makes patcher.patch() an empty wrapper around _patch_logging(). Rename _patch_logging() to patch_logging() and call it directly instead. Drop patch(). 2021-07-01T19:43:07+00:00 James Falcon therealfalcon@gmail.com 2021-07-01T19:43:07+00:00 urn:sha1:81299de5fe3b6e491a965a6ebef66c6b8bf2c037 Currently _bring_up_interfaces() is a no-op for any distro using renderers. We need to be able to support bringing up a single interfaces, a list of interfaces, and all interfaces. This should be independent of the renderers, as the network config is often generated independent of the mechanism used to apply it. Additionally, I included a refactor to remove "_supported_write_network_config". We had a confusing call chain of apply_network_config->_write_network_config->_supported_write_network_config. The last two have been combined. 2021-06-18T16:53:44+00:00 sshedi 53473811+sshedi@users.noreply.github.com 2021-06-18T16:53:44+00:00 urn:sha1:35aa9db6f8e2ba05d366776c0e8d97f52217e930 Also added a new (currently experimental) systemd-networkd renderer, and includes a small refactor to cc_resolv_conf.py to support the resolved.conf used by systemd-resolved. 2021-04-15T23:45:12+00:00 hamalq 81582959+hamalq@users.noreply.github.com 2021-04-15T23:45:12+00:00 urn:sha1:45db197cfc7e3488baae7dc1053c45da070248f6 the above option allows the user to control the behavior of a distro hostname selection if both short hostname and FQDN are supplied. If `prefer_fqdn_over_hostname` is true the FQDN will be selected as hostname; if false the hostname will be selected LP: #1921004 2020-06-08T16:49:12+00:00 Scott Moser smoser@brickies.net 2020-06-08T16:49:12+00:00 urn:sha1:3c551f6ebc12f7729a2755c89b19b9000e27cc88 This was painful, but it finishes a TODO from cloudinit/subp.py. It moves the following from util to subp: ProcessExecutionError subp which target_path I moved subp_blob_in_tempfile into cc_chef, which is its only caller. That saved us from having to deal with it using write_file and temp_utils from subp (which does not import any cloudinit things now). It is arguable that 'target_path' could be moved to a 'path_utils' or something, but in order to use it from subp and also from utils, we had to get it out of utils. 2018-09-20T09:08:37+00:00 Scott Moser smoser@ubuntu.com 2018-09-20T09:08:37+00:00 urn:sha1:c3680475f9c97028d75a8f1bb58139ddd47d00ed Any distro that has a '_write_nework_config' method should no longer get their _write_network called at all. So lets drop that code and raise a RuntimeError any time we got there. Replace the one caller of 'apply_network' (legacy openstack path) with a call to apply_network_config after converting the ENI to network config. 2018-09-05T14:17:16+00:00 Ryan Harper ryan.harper@canonical.com 2018-09-05T14:17:16+00:00 urn:sha1:db50bc0d999e3a90136864a774f85e4e15b144e8 Multiple distros use sysconfig format but have different content and paths to certain files. Update distros to specify these template paths in their renderer_configs dictionary. 2017-04-12T16:32:27+00:00 Jon Grimm jon.grimm@canonical.com 2017-04-03T16:52:42+00:00 urn:sha1:aab609104988b9d14572eb8fa1dd28a8156c0aea Several references that were using URL shorteners are now broken due to their service going away, making it painful to even figure out what they were supposed to be pointing at. Put back long URLS using '# noqa' to make flake8 happy. LP: #1669727 2017-03-18T01:31:56+00:00 Scott Moser smoser@brickies.net 2017-03-15T18:33:45+00:00 urn:sha1:5beecdf88b630a397b3722ddb299e9a37ff02737 Previously, the distro had hard coded which network renderer it would use. This adds support for just picking the right renderer based on what is available. Now, that can be set via a priority in system_info, but should generally work. That config looks like: system_info: network: renderers: ["eni", "sysconfig"] When no renderers are found, a specific RendererNotFoundError is raised. stages.py is modified to catch that and log it at error level. This path should not really be exercised, but could occur if for example an Ubuntu system did not have ifupdown, or a rhel system did not have sysconfig. In such a system previously we would have quietly rendered ENI configuration but that would have been ignored. This is one step better in that we at least log the error.