(mirror of https://github.com/vyos/vyos-cloud-init.git) https://git.amelek.net/vyos/vyos-cloud-init.git/atom?h=cla 2021-12-03T20:11:46+00:00 2021-12-03T20:11:46+00:00 Brett Holman bholman.devel@gmail.com 2021-12-03T20:11:46+00:00 urn:sha1:039c40f9b3d88ee8158604bb18ca4bf2fb5d5e51 This attempts to standardize unit test file location under test/unittests/ such that any source file located at cloudinit/path/to/file.py may have a corresponding unit test file at test/unittests/path/to/test_file.py. Noteworthy Comments: ==================== Four different duplicate test files existed: test_{gpg,util,cc_mounts,cc_resolv_conf}.py Each of these duplicate file pairs has been merged together. This is a break in git history for these files. The test suite appears to have a dependency on test order. Changing test order causes some tests to fail. This should be rectified, but for now some tests have been modified in tests/unittests/config/test_set_passwords.py. A helper class name starts with "Test" which causes pytest to try executing it as a test case, which then throws warnings "due to Class having __init__()". Silence by changing the name of the class. # helpers.py is imported in many test files, import paths change cloudinit/tests/helpers.py -> tests/unittests/helpers.py # Move directories: cloudinit/distros/tests -> tests/unittests/distros cloudinit/cmd/devel/tests -> tests/unittests/cmd/devel cloudinit/cmd/tests -> tests/unittests/cmd/ cloudinit/sources/helpers/tests -> tests/unittests/sources/helpers cloudinit/sources/tests -> tests/unittests/sources cloudinit/net/tests -> tests/unittests/net cloudinit/config/tests -> tests/unittests/config cloudinit/analyze/tests/ -> tests/unittests/analyze/ # Standardize tests already in tests/unittests/ test_datasource -> sources test_distros -> distros test_vmware -> sources/vmware test_handler -> config # this contains cloudconfig module tests test_runs -> runs 2021-11-09T19:41:03+00:00 Andrew Kutz 101085+akutz@users.noreply.github.com 2021-11-09T19:41:03+00:00 urn:sha1:fff6de4a18fa4eca709870e995de99c543a4ac1c This patch address an issue where the use of the "set-name" directive caused the networkd renderer to fail. LP: #1949407 2021-10-08T17:49:58+00:00 Andrew Kutz 101085+akutz@users.noreply.github.com 2021-10-08T17:49:58+00:00 urn:sha1:ca0da042e73d1cf078435befa02a6e09d004b62d This patch addresses an issue caused when the v2 network config directive "set-name" was used in conjunction with interface- specific DNS settings. The patch adds a test to validate the fix. For more information please see bug 1946493 as well as the issue https://github.com/kubernetes-sigs/image-builder/issues/712. LP: #1946493 2021-09-17T18:04:07+00:00 James Falcon therealfalcon@gmail.com 2021-09-17T18:04:07+00:00 urn:sha1:612e39087aee3b1242765e7c4f463f54a6ebd723 Add connectivity_url to Oracle's EphemeralDHCPv4 On bionic, when trying to bring up the EphemeralDHCPv4, it's possible that we already have a route defined, which will result in an error when trying to add the DHCP route. Use the connectivity_url to check if we can reach the metadata service, and if so, skip the EphemeralDHCPv4. The has_url_connectivity function has also been modified to take a dict of kwargs to send to readurl. LP: #1939603 2021-07-01T19:43:07+00:00 James Falcon therealfalcon@gmail.com 2021-07-01T19:43:07+00:00 urn:sha1:81299de5fe3b6e491a965a6ebef66c6b8bf2c037 Currently _bring_up_interfaces() is a no-op for any distro using renderers. We need to be able to support bringing up a single interfaces, a list of interfaces, and all interfaces. This should be independent of the renderers, as the network config is often generated independent of the mechanism used to apply it. Additionally, I included a refactor to remove "_supported_write_network_config". We had a confusing call chain of apply_network_config->_write_network_config->_supported_write_network_config. The last two have been combined. 2021-06-17T21:44:55+00:00 James Falcon TheRealFalcon@users.noreply.github.com 2021-06-17T21:44:55+00:00 urn:sha1:abd2da5777195e7e432b0d53a3f7f29d071dd50e v1 network config currently has no concept of interface-specific DNS, which is required for certain renderers. To fix this, added an optional 'interface' key on the v1 nameserver definition. If specified, it makes the DNS settings specific to the interface. Otherwise, it will be defined as global DNS as it always has. Additionally, DNS for v2 wasn't being recognized correctly. For DNS defined on a particular interface, these settings now also go into the global DNS settings as they were intended. 2021-06-01T22:30:00+00:00 eb3095 45504889+eb3095@users.noreply.github.com 2021-06-01T22:30:00+00:00 urn:sha1:503e2d398660e8af5d49bdf6944a50ad793a3a31 dhclient output that contains brackets for pxe variables will break the dhclient parsing regex line. This fix retains the current functionality while fixing this particular issue. 2021-04-07T16:16:30+00:00 Petr Fedchenkov giggsoff@gmail.com 2021-04-07T16:16:30+00:00 urn:sha1:15dd3601c484e189ea82917600322b7d0e25c088 When bringing up DHCP-provided static routes, we check for "0.0.0.0/0" to indicate an unspecified gateway. However, when parsing the static route in `parse_static_routes`, the gateway is never specified with a net length, so the "/0" will never happen. This change updates the gateway check to check only for "0.0.0.0". 2021-03-08T17:50:57+00:00 Daniel Watkins oddbloke@ubuntu.com 2021-03-08T17:50:57+00:00 urn:sha1:121bc04cdf0e6732fe143b7419131dc250c13384 `get_interfaces` is used to in two ways, broadly: firstly, to determine the available interfaces when converting cloud network configuration formats to cloud-init's network configuration formats; and, secondly, to ensure that any interfaces which are specified in network configuration are (a) available, and (b) named correctly. The first of these is unaffected by this commit, as no clouds support Open vSwitch configuration in their network configuration formats. For the second, we check that MAC addresses of physical devices are unique. In some OVS configurations, there are OVS-created devices which have duplicate MAC addresses, either with each other or with physical devices. As these interfaces are created by OVS, we can be confident that (a) they will be available when appropriate, and (b) that OVS will name them correctly. As such, this commit excludes any OVS-internal interfaces from the set of interfaces returned by `get_interfaces`. LP: #1912844 2020-10-29T13:38:56+00:00 Lukas Märdian luk@slyon.de 2020-10-29T13:38:56+00:00 urn:sha1:3c432b32de1bdce2699525201396a8bbc6a41f3e If an OVS bridge was used as the only/primary interface, the 'init' stage failed with a "Not all expected physical devices present" error, leaving the system with a broken SSH setup. LP: #1898997