(mirror of https://github.com/vyos/vyos-cloud-init.git) https://git.amelek.net/vyos/vyos-cloud-init.git/atom?h=20.3 2020-08-25T15:21:18+00:00 2020-08-25T15:21:18+00:00 Paride Legovini paride.legovini@canonical.com 2020-08-25T15:21:18+00:00 urn:sha1:07104504ab5b30efd2d1f7a8c36effe18b8e5fe0 Changes: tox: bump the pylint version to 2.6.0 in the default run Fix pylint 2.6.0 W0707 warnings (raise-missing-from) 2020-08-20T19:04:03+00:00 Moustafa Moustafa momousta@microsoft.com 2020-08-20T19:04:03+00:00 urn:sha1:d941c7f7846e0216873384044d20f4b6723697c5 Push the cloud-init.log file (Up to 500KB at once) to the KVP before reporting ready to the Azure platform. Based on the analysis done on a large sample of cloud-init.log files, Here's the statistics collected on the log file size: P50 P90 P95 P99 P99.9 P99.99 137K 423K 537K 3.5MB 6MB 16MB This change limits the size of cloud-init.log file data that gets dumped to KVP to 500KB. So for ~95% of the cases, the whole log file will be dumped and for the remaining ~5%, we will get the last 500KB of the cloud-init.log file. To asses the performance of the 500KB limit, 250 VM were deployed with a 500KB cloud-init.log file and the time taken to compress, encode and dump the entries to KVP was measured. Here's the time in milliseconds percentiles: P50 P99 P999 75.705 232.701 1169.636 Another 250 VMs were deployed with this logic dumping their normal cloud-init.log file to KVP, the same timing was measured as above. Here's the time in milliseconds percentiles: P50 P99 P999 1.88 5.277 6.992 Added excluded_handlers to the report_event function to be able to opt-out from reporting the events of the compressed cloud-init.log file to the cloud-init.log file. The KVP break_down logic had a bug, where it will reuse the same key for all the split chunks of KVP which results in overwriting the split KVPs by the last one when consumed by Hyper-V. I added the split chunk index as a differentiator to the KVP key. The Hyper-V consumes the KVPs from the KVP file as chunks whose key is 512KB and value is 2048KB but the Azure platform expects the value to be 1024KB, thus I introduced the Azure value limit. 2020-08-13T20:50:07+00:00 Johnson Shi Johnson.Shi@microsoft.com 2020-08-13T20:50:07+00:00 urn:sha1:c3556ae82dfb47d635344fcd78908f003648d6d2 This PR refactors Azure report ready code to include more robust tests and telemetry. 2020-07-21T15:52:29+00:00 xiaofengw-vmware 42736879+xiaofengw-vmware@users.noreply.github.com 2020-07-21T15:52:29+00:00 urn:sha1:995f8adf00509e5d2aefc9f0680c3c4894ae6666 Add support for VMware's vCD configuration setting DEFAULT-RUN-POST-CUST-SCRIPT. When set True, it will default vms to run post customization scripts if the VM has not been configured in VMTools with "enable-custom-scripts" set False. Add datasource documentation with a bit more context about this interaction on VMware products. With this fix, the behavior will be: * If VM administrator doesn't want others to execute a script on this VM, VMtools can set "enable-custom-scripts" to false from the utility "vmware-toolbox-cmd". * If VM administrator doesn't set value to "enable-custom-scripts", then by default this script is disabled for security purpose. * For VMware's vCD product , the preference is to enable the script if "enable-custom-scripts" is not set. vCD will generate a configuration file with "DEFAULT-RUN-POST-CUST-SCRIPT" set to true. This flag works for both VMware customization engine and cloud-init. 2020-07-15T14:26:12+00:00 Daniel Watkins oddbloke@ubuntu.com 2020-07-15T14:26:12+00:00 urn:sha1:4fe576516d65feda17ba78e9265a8e494a195e7b * cloudinit: remove global disable of pylint W0107 and fix errors This includes removing a test class which contained no tests but wasn't detected as empty because of an errant pass statement. * .pylintrc: update disable comment to match arguments 2020-07-06T15:31:33+00:00 Daniel Watkins oddbloke@ubuntu.com 2020-07-06T15:31:33+00:00 urn:sha1:411dbbebd328163bcb1c676cc711f3e5ed805375 Specifically: * disable E1102 in cloudinit/sources/helpers/openstack.py for reasons described in a comment, and * refactor `abs_join` to require at least one positional argument; this matches os.path.join's signature, and that mismatch is what was causing pylint to emit a warning * bump to pylint 2.4.2 2020-06-30T18:19:38+00:00 Daniel Watkins oddbloke@ubuntu.com 2020-06-30T18:19:38+00:00 urn:sha1:882f1a5f2d5bafd08e6900a2782c3affa67c9d86 As the first refactor PR, this also includes the initial structure for tests. LP: #1884619 2020-06-22T18:44:37+00:00 Scott Moser smoser@brickies.net 2020-06-22T18:44:37+00:00 urn:sha1:76652f3e07b6f659b2fd166a6619cb427dc6bc7e Hetzner cloud only supports user-data as a string (presumably utf-8). In order to allow users on Hetzner to provide binary data to cloud-init, we will attempt to base64decode the userdata. The change here adds a 'maybe_b64decode' function that will decode data if and only if is base64 encoded. The reason for not using util.b64d is that we do not want the return value decoded to a string, and util.b64d will do that if it can. Additionally we call decode with validate=True which oddly is not the default. LP: #1884071 2020-06-19T13:38:05+00:00 Moustafa Moustafa momousta@microsoft.com 2020-06-19T13:38:05+00:00 urn:sha1:d083a0315faf67c00acdecdc3f95c700edf6ba06 This introduces a way to log the dhclient error stream, and uses it for the Azure datasource (where we have a specific requirement for this data to be logged). 2020-06-10T14:39:29+00:00 Joshua Powers josh.powers@canonical.com 2020-06-10T14:39:29+00:00 urn:sha1:f3bd42659efeed4b092ffcdfd5df7f24813f2d3e