(mirror of https://github.com/vyos/vyos-cloud-init.git) https://git.amelek.net/vyos/vyos-cloud-init.git/atom?h=current 2021-12-03T20:11:46+00:00 2021-12-03T20:11:46+00:00 Brett Holman bholman.devel@gmail.com 2021-12-03T20:11:46+00:00 urn:sha1:039c40f9b3d88ee8158604bb18ca4bf2fb5d5e51 This attempts to standardize unit test file location under test/unittests/ such that any source file located at cloudinit/path/to/file.py may have a corresponding unit test file at test/unittests/path/to/test_file.py. Noteworthy Comments: ==================== Four different duplicate test files existed: test_{gpg,util,cc_mounts,cc_resolv_conf}.py Each of these duplicate file pairs has been merged together. This is a break in git history for these files. The test suite appears to have a dependency on test order. Changing test order causes some tests to fail. This should be rectified, but for now some tests have been modified in tests/unittests/config/test_set_passwords.py. A helper class name starts with "Test" which causes pytest to try executing it as a test case, which then throws warnings "due to Class having __init__()". Silence by changing the name of the class. # helpers.py is imported in many test files, import paths change cloudinit/tests/helpers.py -> tests/unittests/helpers.py # Move directories: cloudinit/distros/tests -> tests/unittests/distros cloudinit/cmd/devel/tests -> tests/unittests/cmd/devel cloudinit/cmd/tests -> tests/unittests/cmd/ cloudinit/sources/helpers/tests -> tests/unittests/sources/helpers cloudinit/sources/tests -> tests/unittests/sources cloudinit/net/tests -> tests/unittests/net cloudinit/config/tests -> tests/unittests/config cloudinit/analyze/tests/ -> tests/unittests/analyze/ # Standardize tests already in tests/unittests/ test_datasource -> sources test_distros -> distros test_vmware -> sources/vmware test_handler -> config # this contains cloudconfig module tests test_runs -> runs 2021-11-22T22:56:41+00:00 James Falcon james.falcon@canonical.com 2021-11-22T22:56:41+00:00 urn:sha1:31daf6670aeeba1d452c70bc0d4d04139652be36 testing: monkeypatch system_info call in unit tests system_info can make calls that read or write from the filesystem, which should require special mocking. It is also decorated with 'lru_cache', which means test authors often don't realize they need to be mocking. Also, we don't actually want the results from the user's local machine, so monkeypatching it across all tests should be reasonable. Additionally, moved some of 'system_info` into a helper function to reduce the surface area of the monkeypatch, added tests for the new function (and fixed a bug as a result), and removed related mocks that should be no longer needed. 2021-10-07T20:08:13+00:00 Brett Holman bpholman5@gmail.com 2021-10-07T20:08:13+00:00 urn:sha1:725a7f7f19eb39b472e1f24b447fc9a596bf1748 Allow comments in runcmd and report failed commands correctly A `runcmd` script may fail to parse properly, but does not mark `runcmd` as failed when that occurs. Additionally `shellify()` fails to correctly parse scripts that contain a comment line. Rectify both issues and add unit tests to verify correct behavior. LP: #1853146 2021-09-21T20:28:30+00:00 Paride Legovini paride.legovini@canonical.com 2021-09-21T20:28:30+00:00 urn:sha1:089a307db1fc572461eea1589f1876132c058311 tox: bump the pinned flake8 and pylint version * pylint: fix W1406 (redundant-u-string-prefix) The u prefix for strings is no longer necessary in Python >=3.0. * pylint: disable W1514 (unspecified-encoding) From https://www.python.org/dev/peps/pep-0597/ (Python 3.10): The new warning stems form https://www.python.org/dev/peps/pep-0597, which says: Developers using macOS or Linux may forget that the default encoding is not always UTF-8. [...] Even Python experts may assume that the default encoding is UTF-8. This creates bugs that only happen on Windows. The warning could be fixed by always specifying encoding='utf-8', however we should be careful to not break environments which are not utf-8 (or explicitly state that only utf-8 is supported). Let's silence the warning for now. * _quick_read_instance_id: cover the case where load_yaml() returns None Spotted by pylint: - E1135 (unsupported-membership-test) - E1136 (unsubscriptable-object) LP: #1944414 2021-09-13T18:21:28+00:00 zhuzaifangxuele 52022596+zhuzaifangxuele@users.noreply.github.com 2021-09-13T18:21:28+00:00 urn:sha1:f4c47e3e25d1fb79e2673e37f8fc67750d025be2 openEuler Homepage: https://www.openeuler.org/en/ 2021-09-01T19:01:09+00:00 Alexandr Kravchenko sasha121196@mail.ru 2021-09-01T19:01:09+00:00 urn:sha1:f6c71fd758a3589ac5f62fd251d60b00edf5bb1c https://www.cloudlinux.com/ 2021-08-05T16:32:36+00:00 Aleksander Baranowski aleksander.baranowski@yahoo.pl 2021-08-05T16:32:36+00:00 urn:sha1:3d9c862b6ded798031fad827328fa437bc14ac97 2021-07-21T20:48:05+00:00 eb3095 45504889+eb3095@users.noreply.github.com 2021-07-21T20:48:05+00:00 urn:sha1:4257e30ac4b8730af35c078f2df0a2234dd19ffa Virtuozzo Linux is a distro based off of CentOS 8, similar to Alma Linux and Rocky Linux. 2021-06-18T16:53:44+00:00 sshedi 53473811+sshedi@users.noreply.github.com 2021-06-18T16:53:44+00:00 urn:sha1:35aa9db6f8e2ba05d366776c0e8d97f52217e930 Also added a new (currently experimental) systemd-networkd renderer, and includes a small refactor to cc_resolv_conf.py to support the resolved.conf used by systemd-resolved. 2021-06-02T21:10:32+00:00 Robert Schweikert rjschwei@suse.com 2021-06-02T21:10:32+00:00 urn:sha1:29ac50f2b9e7634fc59fc161d77d27e970ae8080 Security scanners are often simple minded and complain on arbitrary settings such as file permissions. For /var/log/* having world read is one of these cases.