(mirror of https://github.com/vyos/vyos-cloud-init.git) https://git.amelek.net/vyos/vyos-cloud-init.git/atom?h=rolling 2021-12-03T20:11:46+00:00 2021-12-03T20:11:46+00:00 Brett Holman bholman.devel@gmail.com 2021-12-03T20:11:46+00:00 urn:sha1:039c40f9b3d88ee8158604bb18ca4bf2fb5d5e51 This attempts to standardize unit test file location under test/unittests/ such that any source file located at cloudinit/path/to/file.py may have a corresponding unit test file at test/unittests/path/to/test_file.py. Noteworthy Comments: ==================== Four different duplicate test files existed: test_{gpg,util,cc_mounts,cc_resolv_conf}.py Each of these duplicate file pairs has been merged together. This is a break in git history for these files. The test suite appears to have a dependency on test order. Changing test order causes some tests to fail. This should be rectified, but for now some tests have been modified in tests/unittests/config/test_set_passwords.py. A helper class name starts with "Test" which causes pytest to try executing it as a test case, which then throws warnings "due to Class having __init__()". Silence by changing the name of the class. # helpers.py is imported in many test files, import paths change cloudinit/tests/helpers.py -> tests/unittests/helpers.py # Move directories: cloudinit/distros/tests -> tests/unittests/distros cloudinit/cmd/devel/tests -> tests/unittests/cmd/devel cloudinit/cmd/tests -> tests/unittests/cmd/ cloudinit/sources/helpers/tests -> tests/unittests/sources/helpers cloudinit/sources/tests -> tests/unittests/sources cloudinit/net/tests -> tests/unittests/net cloudinit/config/tests -> tests/unittests/config cloudinit/analyze/tests/ -> tests/unittests/analyze/ # Standardize tests already in tests/unittests/ test_datasource -> sources test_distros -> distros test_vmware -> sources/vmware test_handler -> config # this contains cloudconfig module tests test_runs -> runs 2021-10-27T14:43:34+00:00 James Falcon james.falcon@canonical.com 2021-10-27T14:43:34+00:00 urn:sha1:1d01da5d9916d97ef463ba61a36b3f98f8911419 This commit removes automatically installing udev rules for hotplug and adds a module to install them instead. Automatically including the udev rules and checking if hotplug was enabled consumed too many resources in certain circumstances. Moving the rules to a module ensures we don't spend extra extra cycles on hotplug if hotplug functionality isn't desired. LP: #1946003 2021-10-25T19:31:07+00:00 Lucendio github+dev@lucendio.com 2021-10-25T19:31:07+00:00 urn:sha1:a4236c375ddf78258a8f9252c1d79c665aa4f88b The main idea is to introduce a second module that takes care of writing files, but in the 'final' stage. While the introduction of a second module would allow for choosing the appropriate place withing the order of modules (and stages), there is no addition top-level directive being added to the cloud configuration schema. Instead, 'write-files' schema is being extended to include a 'defer' attribute used only by the 'write-deffered-files' modules. The new module 'write-deferred-files' reuses as much as possible of the 'write-files' functionality. 2021-10-23T03:06:51+00:00 James Falcon james.falcon@canonical.com 2021-10-23T03:06:51+00:00 urn:sha1:2db713346d656c3486228678ad020b56440c1e34 In jsonschema 4, hostname validation was changed to have an optional dependency on the fqdn package. Since we don't have this dependency in cloud-init, attempting this validation will no longer fail for a string that isn't a valid hostname. 2021-09-29T23:32:53+00:00 James Falcon james.falcon@canonical.com 2021-09-29T23:32:53+00:00 urn:sha1:ba083245537abd5bf5942fbe851e21eb8f245000 Cloud tests have been replaced with integration tests 2020-11-18T14:23:44+00:00 Chad Smith chad.smith@canonical.com 2020-11-18T14:23:44+00:00 urn:sha1:f680114446a5a20ce88f3d10d966811a774c8e8f Allow root user to validate the userdata provided to the launched machine using `cloud-init devel schema --system` 2020-08-19T23:18:25+00:00 dermotbradley dermot_bradley@yahoo.com 2020-08-19T23:18:25+00:00 urn:sha1:79a8ce7e714ae1686c10bff77612eab0f6eccc95 Add new module cc_apk_configure for creating Alpine /etc/apk/repositories file. Modify cc_ca_certs, cc_ntp, cc_power_state_change, and cc_resolv_conf for Alpine. Add Alpine template files for Chrony and Busybox NTP support. Add Alpine template file for /etc/hosts. 2020-06-29T16:21:04+00:00 lucasmoura lucas.moura@canonical.com 2020-06-29T16:21:04+00:00 urn:sha1:b0eba6a4c3a25a13259c01ac4c9a35720fecfdd2 Create a schema object for the chef module and validate this schema in the handle function of the module. Some of the config keys description, so I tried looking at the code and chef documentation to provide an information to the user. However, I don't know if I have the best description for all fields. For example, for the key show_time I could not find an accurate description of what it did, so I used what was in our code base to infer what it should do. LP: #1858888 2020-05-13T20:45:01+00:00 lucasmoura lucas.moura@canonical.com 2020-05-13T20:45:01+00:00 urn:sha1:2e32c40a607250bc9e713c0daf360dc6617f4420 Create a schema object for the `apt_configure` module and validate this schema in the `handle` function of the module. There are some considerations regarding this PR: * The `primary` and `security` keys have the exact same properties. I tried to eliminate this redundancy by moving their properties to a common place and then just referencing it for both security and primary. Similar to what is documented here: https://json-schema.org/understanding-json-schema/structuring.html under the `Reuse` paragraph. However, this approach does not work, because the `#` pointer goes to the beginning of the file, which is a python module instead of a json file, not allowing the pointer to find the correct definition. What I did was to create a separate dict for the mirror config and reuse it for primary and security, but maybe there are better approaches to do that. * There was no documentation for the config `debconf_selections`. I tried to infer what it supposed to do by looking at the code and the `debconf-set-selections` manpage, but my description may not be accurate or complete. * Add a _parse_description function to schema.py to render multi-line preformatted content instead of squashing all whitespace LP: #1858884 2020-05-08T21:38:51+00:00 James Falcon TheRealFalcon@users.noreply.github.com 2020-05-08T21:38:51+00:00 urn:sha1:34b868020254106af8c79ffb85e04e294b19e44f Also update all examples to include the cloud-config header if they don't have it LP: #1876414