diff options
| author | Daniel Watkins <oddbloke@ubuntu.com> | 2020-03-24 17:36:34 -0400 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-03-24 17:36:34 -0400 |
| commit | d605db4cb55d67915cb27a244faf1b7201468c84 (patch) | |
| tree | 6b65ded3fa26dde91b641cc88a227e97209280d3 | |
| parent | 53b6d1d6cdd1691b4379df4829109db40097b61b (diff) | |
| download | vyos-cloud-init-d605db4cb55d67915cb27a244faf1b7201468c84.tar.gz vyos-cloud-init-d605db4cb55d67915cb27a244faf1b7201468c84.zip | |
HACKING.rst: add links to new Code Review Process doc (#276)
Co-authored-by: Joshua Powers <josh.powers@canonical.com>
| -rw-r--r-- | HACKING.rst | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/HACKING.rst b/HACKING.rst index e050fa93..0dec469c 100644 --- a/HACKING.rst +++ b/HACKING.rst @@ -60,6 +60,9 @@ Do these things once git remote add GH_USER git@github.com:GH_USER/cloud-init.git git push GH_USER master +* Read through the cloud-init `Code Review Process`_, so you understand + how your changes will end up in cloud-init's codebase. + .. _GitHub: https://github.com .. _Launchpad: https://launchpad.net .. _repository: https://github.com/canonical/cloud-init @@ -119,13 +122,15 @@ Do these things for each feature or bug - Click 'Create Pull Request` Then, someone in the `Ubuntu Server`_ team will review your changes and -follow up in the pull request. +follow up in the pull request. Look at the `Code Review Process`_ doc +to understand the following steps. Feel free to ping and/or join ``#cloud-init`` on freenode irc if you have any questions. .. _tox: https://tox.readthedocs.io/en/latest/ .. _Ubuntu Server: https://github.com/orgs/canonical/teams/ubuntu-server +.. _Code Review Process: https://cloudinit.readthedocs.io/en/latest/topics/code_review.html Design ====== |