FreeBSD: improvements for packages, setting password and timezone

 - Implement set_passwd
 - Implement set_timezone
 - support installing packages
 - Use /bin/tcsh as default user shell (FreeBSD default)
 - Change default username to freebsd
 - Enable set-passwords, package-update-upgrade-install and timezone modules

3 files changed, 50 insertions, 12 deletions

diff --git a/ChangeLog b/ChangeLog
index 6d6da417..e06bf60f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -96,6 +96,8 @@
    avoid dependency on network metadata service on every boot (LP: #1553815)
  - support network configuration in cloud-init --local with support
    device naming via systemd.link.
+ - FreeBSD: add support for installing packages, setting password and
+   timezone.  Change default user to 'freebsd'. [Ben Arblaster]
 
 0.7.6:
  - open 0.7.6
diff --git a/cloudinit/distros/freebsd.py b/cloudinit/distros/freebsd.py
index 72012056..91bf4a4e 100644
--- a/cloudinit/distros/freebsd.py
+++ b/cloudinit/distros/freebsd.py
@@ -16,6 +16,7 @@
 #    You should have received a copy of the GNU General Public License
 #    along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+import os
 import six
 from six import StringIO
 
@@ -30,6 +31,8 @@ from cloudinit import util
 from cloudinit.distros import net_util
 from cloudinit.distros.parsers.resolv_conf import ResolvConf
 
+from cloudinit.settings import PER_INSTANCE
+
 LOG = logging.getLogger(__name__)
 
 
@@ -236,9 +239,21 @@ class Distro(distros.Distro):
             util.logexc(LOG, "Failed to create user %s", name)
             raise e
 
-    # TODO:
     def set_passwd(self, user, passwd, hashed=False):
-        return False
+        cmd = ['pw', 'usermod', user]
+
+        if hashed:
+            cmd.append('-H')
+        else:
+            cmd.append('-h')
+
+        cmd.append('0')
+
+        try:
+            util.subp(cmd, passwd, logstring="chpasswd for %s" % user)
+        except Exception as e:
+            util.logexc(LOG, "Failed to set password for %s", user)
+            raise e
 
     def lock_passwd(self, name):
         try:
@@ -369,13 +384,34 @@ class Distro(distros.Distro):
             LOG.warn("Error running %s: %s", cmd, err)
 
     def install_packages(self, pkglist):
-        return
+        self.update_package_sources()
+        self.package_command('install', pkgs=pkglist)
+
+    def package_command(self, command, args=None, pkgs=None):
+        if pkgs is None:
+            pkgs = []
+
+        e = os.environ.copy()
+        e['ASSUME_ALWAYS_YES'] = 'YES'
+
+        cmd = ['pkg']
+        if args and isinstance(args, str):
+            cmd.append(args)
+        elif args and isinstance(args, list):
+            cmd.extend(args)
+
+        if command:
+            cmd.append(command)
+
+        pkglist = util.expand_package_list('%s-%s', pkgs)
+        cmd.extend(pkglist)
 
-    def package_command(self, cmd, args=None, pkgs=None):
-        return
+        # Allow the output of this to flow outwards (ie not be captured)
+        util.subp(cmd, env=e, capture=False)
 
     def set_timezone(self, tz):
-        return
+        distros.set_etc_timezone(tz=tz, tz_file=self._find_tz_file(tz))
 
     def update_package_sources(self):
-        return
+        self._runner.run("update-sources", self.package_command,
+                         ["update"], freq=PER_INSTANCE)
diff --git a/config/cloud.cfg-freebsd b/config/cloud.cfg-freebsd
index 5ac181ff..be664f5d 100644
--- a/config/cloud.cfg-freebsd
+++ b/config/cloud.cfg-freebsd
@@ -49,10 +49,10 @@ cloud_config_modules:
 # - mounts
  - ssh-import-id
  - locale
-# - set-passwords
-# - package-update-upgrade-install
+ - set-passwords
+ - package-update-upgrade-install
 # - landscape
-# - timezone
+ - timezone
 # - puppet
 # - chef
 # - salt-minion
@@ -80,9 +80,9 @@ cloud_final_modules:
 system_info:
    distro: freebsd
    default_user:
-     name: beastie
+     name: freebsd
      lock_passwd: True
      gecos: FreeBSD
      groups: [wheel]
      sudo: ["ALL=(ALL) NOPASSWD:ALL"]
-     shell: /bin/sh
+     shell: /bin/tcsh