summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorScott Moser <smoser@ubuntu.com>2016-06-03 15:27:32 -0400
committerScott Moser <smoser@ubuntu.com>2016-06-03 15:27:32 -0400
commit80931f7008971c9a7705c054fabc29fec7a133e2 (patch)
treee9609437aba6adb0c6b4d70682117fae71d20872
parentaefffff0e3df98a435133b598217401c3f953cc6 (diff)
downloadvyos-cloud-init-80931f7008971c9a7705c054fabc29fec7a133e2.tar.gz
vyos-cloud-init-80931f7008971c9a7705c054fabc29fec7a133e2.zip
fix tox -e flake8
-rw-r--r--cloudinit/config/cc_apt_configure.py4
-rw-r--r--tests/unittests/test_handler/test_handler_apt_configure_sources_list.py17
-rw-r--r--tests/unittests/test_handler/test_handler_apt_source.py66
3 files changed, 43 insertions, 44 deletions
diff --git a/cloudinit/config/cc_apt_configure.py b/cloudinit/config/cc_apt_configure.py
index d603f417..7a9777c0 100644
--- a/cloudinit/config/cc_apt_configure.py
+++ b/cloudinit/config/cc_apt_configure.py
@@ -199,8 +199,8 @@ def add_key(ent):
def convert_to_new_format(srclist):
- """ convert_to_new_format
- convert the old list based format to the new dict based one
+ """convert_to_new_format
+ convert the old list based format to the new dict based one
"""
srcdict = {}
if isinstance(srclist, list):
diff --git a/tests/unittests/test_handler/test_handler_apt_configure_sources_list.py b/tests/unittests/test_handler/test_handler_apt_configure_sources_list.py
index 5cf386f8..5d0417a2 100644
--- a/tests/unittests/test_handler/test_handler_apt_configure_sources_list.py
+++ b/tests/unittests/test_handler/test_handler_apt_configure_sources_list.py
@@ -3,7 +3,6 @@ Test templating of sources list
"""
import logging
import os
-import re
import shutil
import tempfile
@@ -62,14 +61,14 @@ deb-src http://archive.ubuntu.com/ubuntu/ fakerelease main restricted
def load_tfile_or_url(*args, **kwargs):
- """ load_tfile_or_url
+ """load_tfile_or_url
load file and return content after decoding
"""
return util.decode_binary(util.read_file_or_url(*args, **kwargs).contents)
class TestAptSourceConfigSourceList(t_help.FilesystemMockingTestCase):
- """ TestAptSourceConfigSourceList
+ """TestAptSourceConfigSourceList
Main Class to test sources list rendering
"""
def setUp(self):
@@ -89,7 +88,7 @@ class TestAptSourceConfigSourceList(t_help.FilesystemMockingTestCase):
return cloud.Cloud(myds, paths, {}, mydist, None)
def apt_source_list(self, distro, mirror, mirrorcheck=None):
- """ apt_source_list
+ """apt_source_list
Test rendering of a source.list from template for a given distro
"""
if mirrorcheck is None:
@@ -115,19 +114,19 @@ class TestAptSourceConfigSourceList(t_help.FilesystemMockingTestCase):
{'codename': '', 'primary': mirrorcheck, 'mirror': mirrorcheck})
def test_apt_source_list_debian(self):
- """ test_apt_source_list_debian
+ """test_apt_source_list_debian
Test rendering of a source.list from template for debian
"""
self.apt_source_list('debian', 'http://httpredir.debian.org/debian')
def test_apt_source_list_ubuntu(self):
- """ test_apt_source_list_ubuntu
+ """test_apt_source_list_ubuntu
Test rendering of a source.list from template for ubuntu
"""
self.apt_source_list('ubuntu', 'http://archive.ubuntu.com/ubuntu/')
def test_apt_srcl_debian_mirrorfail(self):
- """ test_apt_source_list_debian_mirrorfail
+ """test_apt_source_list_debian_mirrorfail
Test rendering of a source.list from template for debian
"""
self.apt_source_list('debian', ['http://does.not.exist',
@@ -135,7 +134,7 @@ class TestAptSourceConfigSourceList(t_help.FilesystemMockingTestCase):
'http://httpredir.debian.org/debian')
def test_apt_srcl_ubuntu_mirrorfail(self):
- """ test_apt_source_list_ubuntu_mirrorfail
+ """test_apt_source_list_ubuntu_mirrorfail
Test rendering of a source.list from template for ubuntu
"""
self.apt_source_list('ubuntu', ['http://does.not.exist',
@@ -143,7 +142,7 @@ class TestAptSourceConfigSourceList(t_help.FilesystemMockingTestCase):
'http://archive.ubuntu.com/ubuntu/')
def test_apt_srcl_custom(self):
- """ test_apt_srcl_custom
+ """test_apt_srcl_custom
Test rendering from a custom source.list template
"""
cfg = util.load_yaml(YAML_TEXT_CUSTOM_SL)
diff --git a/tests/unittests/test_handler/test_handler_apt_source.py b/tests/unittests/test_handler/test_handler_apt_source.py
index fe2ffae5..4dbe69f0 100644
--- a/tests/unittests/test_handler/test_handler_apt_source.py
+++ b/tests/unittests/test_handler/test_handler_apt_source.py
@@ -33,14 +33,14 @@ S0ORP6HXET3+jC8BMG4tBWCTK/XEZw==
def load_tfile_or_url(*args, **kwargs):
- """ load_tfile_or_url
+ """load_tfile_or_url
load file and return content after decoding
"""
return util.decode_binary(util.read_file_or_url(*args, **kwargs).contents)
class TestAptSourceConfig(TestCase):
- """ TestAptSourceConfig
+ """TestAptSourceConfig
Main Class to test apt_source configs
"""
def setUp(self):
@@ -57,7 +57,7 @@ class TestAptSourceConfig(TestCase):
@staticmethod
def _get_default_params():
- """ get_default_params
+ """get_default_params
Get the most basic default mrror and release info to be used in tests
"""
params = {}
@@ -66,7 +66,7 @@ class TestAptSourceConfig(TestCase):
return params
def myjoin(self, *args, **kwargs):
- """ myjoin - redir into writable tmpdir"""
+ """myjoin - redir into writable tmpdir"""
if (args[0] == "/etc/apt/sources.list.d/" and
args[1] == "cloud_config_sources.list" and
len(args) == 2):
@@ -75,7 +75,7 @@ class TestAptSourceConfig(TestCase):
return self.join(*args, **kwargs)
def apt_src_basic(self, filename, cfg):
- """ apt_src_basic
+ """apt_src_basic
Test Fix deb source string, has to overwrite mirror conf in params
"""
params = self._get_default_params()
@@ -92,7 +92,7 @@ class TestAptSourceConfig(TestCase):
contents, flags=re.IGNORECASE))
def test_apt_src_basic(self):
- """ test_apt_src_basic
+ """test_apt_src_basic
Test Fix deb source string, has to overwrite mirror conf in params.
Test with a filename provided in config.
"""
@@ -103,7 +103,7 @@ class TestAptSourceConfig(TestCase):
self.apt_src_basic(self.aptlistfile, [cfg])
def test_apt_src_basic_dict(self):
- """ test_apt_src_basic_dict
+ """test_apt_src_basic_dict
Test Fix deb source string, has to overwrite mirror conf in params.
Test with a filename provided in config.
Provided in a dictionary with filename being the key (new format)
@@ -115,7 +115,7 @@ class TestAptSourceConfig(TestCase):
self.apt_src_basic(self.aptlistfile, cfg)
def apt_src_basic_tri(self, cfg):
- """ apt_src_basic_tri
+ """apt_src_basic_tri
Test Fix three deb source string, has to overwrite mirror conf in
params. Test with filenames provided in config.
generic part to check three files with different content
@@ -137,7 +137,7 @@ class TestAptSourceConfig(TestCase):
contents, flags=re.IGNORECASE))
def test_apt_src_basic_tri(self):
- """ test_apt_src_basic_tri
+ """test_apt_src_basic_tri
Test Fix three deb source string, has to overwrite mirror conf in
params. Test with filenames provided in config.
"""
@@ -156,7 +156,7 @@ class TestAptSourceConfig(TestCase):
self.apt_src_basic_tri([cfg1, cfg2, cfg3])
def test_apt_src_basic_dict_tri(self):
- """ test_apt_src_basic_dict_tri
+ """test_apt_src_basic_dict_tri
Test Fix three deb source string, has to overwrite mirror conf in
params. Test with filenames provided in config.
Provided in a dictionary with filename being the key (new format)
@@ -176,7 +176,7 @@ class TestAptSourceConfig(TestCase):
self.apt_src_basic_tri(cfg)
def test_apt_src_basic_nofn(self):
- """ test_apt_src_basic_nofn
+ """test_apt_src_basic_nofn
Test Fix deb source string, has to overwrite mirror conf in params.
Test without a filename provided in config and test for known fallback.
"""
@@ -187,7 +187,7 @@ class TestAptSourceConfig(TestCase):
self.apt_src_basic(self.fallbackfn, [cfg])
def apt_src_replacement(self, filename, cfg):
- """ apt_src_replace
+ """apt_src_replace
Test Autoreplacement of MIRROR and RELEASE in source specs
"""
params = self._get_default_params()
@@ -202,7 +202,7 @@ class TestAptSourceConfig(TestCase):
contents, flags=re.IGNORECASE))
def test_apt_src_replace(self):
- """ test_apt_src_replace
+ """test_apt_src_replace
Test Autoreplacement of MIRROR and RELEASE in source specs with
Filename being set
"""
@@ -211,7 +211,7 @@ class TestAptSourceConfig(TestCase):
self.apt_src_replacement(self.aptlistfile, [cfg])
def apt_src_replace_tri(self, cfg):
- """ apt_src_replace_tri
+ """apt_src_replace_tri
Test three autoreplacements of MIRROR and RELEASE in source specs with
generic part
"""
@@ -231,7 +231,7 @@ class TestAptSourceConfig(TestCase):
contents, flags=re.IGNORECASE))
def test_apt_src_replace_tri(self):
- """ test_apt_src_replace_tri
+ """test_apt_src_replace_tri
Test three autoreplacements of MIRROR and RELEASE in source specs with
Filename being set
"""
@@ -244,7 +244,7 @@ class TestAptSourceConfig(TestCase):
self.apt_src_replace_tri([cfg1, cfg2, cfg3])
def test_apt_src_replace_dict_tri(self):
- """ test_apt_src_replace_dict_tri
+ """test_apt_src_replace_dict_tri
Test three autoreplacements of MIRROR and RELEASE in source specs with
Filename being set
Provided in a dictionary with filename being the key (new format)
@@ -252,13 +252,13 @@ class TestAptSourceConfig(TestCase):
filenames to be overwritten inside the directory entry.
"""
cfg = {self.aptlistfile: {'source': 'deb $MIRROR $RELEASE multiverse'},
- 'notused': {'source': 'deb $MIRROR $RELEASE main',
- 'filename': self.aptlistfile2},
+ 'notused': {'source': 'deb $MIRROR $RELEASE main',
+ 'filename': self.aptlistfile2},
self.aptlistfile3: {'source': 'deb $MIRROR $RELEASE universe'}}
self.apt_src_replace_tri(cfg)
def test_apt_src_replace_nofn(self):
- """ test_apt_src_replace_nofn
+ """test_apt_src_replace_nofn
Test Autoreplacement of MIRROR and RELEASE in source specs with
No filename being set
"""
@@ -267,7 +267,7 @@ class TestAptSourceConfig(TestCase):
self.apt_src_replacement(self.fallbackfn, [cfg])
def apt_src_keyid(self, filename, cfg, keynum):
- """ apt_src_keyid
+ """apt_src_keyid
Test specification of a source + keyid
"""
params = self._get_default_params()
@@ -293,7 +293,7 @@ class TestAptSourceConfig(TestCase):
contents, flags=re.IGNORECASE))
def test_apt_src_keyid(self):
- """ test_apt_src_keyid
+ """test_apt_src_keyid
Test specification of a source + keyid with filename being set
"""
cfg = {'source': ('deb '
@@ -305,7 +305,7 @@ class TestAptSourceConfig(TestCase):
self.apt_src_keyid(self.aptlistfile, [cfg], 1)
def test_apt_src_keyid_tri(self):
- """ test_apt_src_keyid_tri
+ """test_apt_src_keyid_tri
Test specification of a source + keyid with filename being set
Setting three of such, check for content and keys
"""
@@ -345,7 +345,7 @@ class TestAptSourceConfig(TestCase):
contents, flags=re.IGNORECASE))
def test_apt_src_keyid_nofn(self):
- """ test_apt_src_keyid_nofn
+ """test_apt_src_keyid_nofn
Test specification of a source + keyid without filename being set
"""
cfg = {'source': ('deb '
@@ -357,7 +357,7 @@ class TestAptSourceConfig(TestCase):
self.apt_src_keyid(self.fallbackfn, [cfg], 1)
def apt_src_key(self, filename, cfg):
- """ apt_src_key
+ """apt_src_key
Test specification of a source + key
"""
params = self._get_default_params()
@@ -378,7 +378,7 @@ class TestAptSourceConfig(TestCase):
contents, flags=re.IGNORECASE))
def test_apt_src_key(self):
- """ test_apt_src_key
+ """test_apt_src_key
Test specification of a source + key with filename being set
"""
cfg = {'source': ('deb '
@@ -390,7 +390,7 @@ class TestAptSourceConfig(TestCase):
self.apt_src_key(self.aptlistfile, cfg)
def test_apt_src_key_nofn(self):
- """ test_apt_src_key_nofn
+ """test_apt_src_key_nofn
Test specification of a source + key without filename being set
"""
cfg = {'source': ('deb '
@@ -402,7 +402,7 @@ class TestAptSourceConfig(TestCase):
self.apt_src_key(self.fallbackfn, cfg)
def test_apt_src_keyonly(self):
- """ test_apt_src_keyonly
+ """test_apt_src_keyonly
Test specification key without source
"""
params = self._get_default_params()
@@ -419,7 +419,7 @@ class TestAptSourceConfig(TestCase):
self.assertFalse(os.path.isfile(self.aptlistfile))
def test_apt_src_keyidonly(self):
- """ test_apt_src_keyidonly
+ """test_apt_src_keyidonly
Test specification of a keyid without source
"""
params = self._get_default_params()
@@ -436,7 +436,7 @@ class TestAptSourceConfig(TestCase):
self.assertFalse(os.path.isfile(self.aptlistfile))
def test_apt_src_keyid_real(self):
- """ test_apt_src_keyid_real
+ """test_apt_src_keyid_real
Test specification of a keyid without source incl
up to addition of the key (nothing but add_key_raw mocked)
"""
@@ -454,7 +454,7 @@ class TestAptSourceConfig(TestCase):
self.assertFalse(os.path.isfile(self.aptlistfile))
def test_apt_src_longkeyid_real(self):
- """ test_apt_src_longkeyid_real
+ """test_apt_src_longkeyid_real
Test specification of a long key fingerprint without source incl
up to addition of the key (nothing but add_key_raw mocked)
"""
@@ -472,7 +472,7 @@ class TestAptSourceConfig(TestCase):
self.assertFalse(os.path.isfile(self.aptlistfile))
def test_apt_src_ppa(self):
- """ test_apt_src_ppa
+ """test_apt_src_ppa
Test specification of a ppa
"""
params = self._get_default_params()
@@ -491,7 +491,7 @@ class TestAptSourceConfig(TestCase):
self.assertFalse(os.path.isfile(self.aptlistfile))
def test_apt_src_ppa_tri(self):
- """ test_apt_src_ppa_tri
+ """test_apt_src_ppa_tri
Test specification of a ppa
"""
params = self._get_default_params()
@@ -519,7 +519,7 @@ class TestAptSourceConfig(TestCase):
self.assertFalse(os.path.isfile(self.aptlistfile3))
def test_convert_to_new_format(self):
- """ test_convert_to_new_format
+ """test_convert_to_new_format
Test the conversion of old to new format
And the noop conversion of new to new format as well
"""