get_cmdline_url: fix in python3 when calling

get_cmdline_url was passing a string to response.contents.startswith()
where response.contents is now bytes.

this changes it to convert input to text, and also to default to text.

2 files changed, 7 insertions, 5 deletions

diff --git a/cloudinit/util.py b/cloudinit/util.py
index 039aa3f2..cc20305c 100644
--- a/cloudinit/util.py
+++ b/cloudinit/util.py
@@ -970,7 +970,7 @@ def get_fqdn_from_hosts(hostname, filename="/etc/hosts"):
 
 
 def get_cmdline_url(names=('cloud-config-url', 'url'),
-                    starts="#cloud-config", cmdline=None):
+                    starts=b"#cloud-config", cmdline=None):
     if cmdline is None:
         cmdline = get_cmdline()
 
@@ -986,6 +986,8 @@ def get_cmdline_url(names=('cloud-config-url', 'url'),
         return (None, None, None)
 
     resp = read_file_or_url(url)
+    # allow callers to pass starts as text when comparing to bytes contents
+    starts = encode_text(starts)
     if resp.ok() and resp.contents.startswith(starts):
         return (key, url, resp.contents)
 
diff --git a/tests/unittests/test__init__.py b/tests/unittests/test__init__.py
index 1a307e56..c32783a6 100644
--- a/tests/unittests/test__init__.py
+++ b/tests/unittests/test__init__.py
@@ -181,7 +181,7 @@ class TestCmdlineUrl(unittest.TestCase):
     def test_invalid_content(self):
         url = "http://example.com/foo"
         key = "mykey"
-        payload = "0"
+        payload = b"0"
         cmdline = "ro %s=%s bar=1" % (key, url)
 
         with mock.patch('cloudinit.url_helper.readurl',
@@ -194,13 +194,13 @@ class TestCmdlineUrl(unittest.TestCase):
     def test_valid_content(self):
         url = "http://example.com/foo"
         key = "mykey"
-        payload = "xcloud-config\nmydata: foo\nbar: wark\n"
+        payload = b"xcloud-config\nmydata: foo\nbar: wark\n"
         cmdline = "ro %s=%s bar=1" % (key, url)
 
         with mock.patch('cloudinit.url_helper.readurl',
                         return_value=url_helper.StringResponse(payload)):
             self.assertEqual(
-                util.get_cmdline_url(names=[key], starts="xcloud-config",
+                util.get_cmdline_url(names=[key], starts=b"xcloud-config",
                                      cmdline=cmdline),
                 (key, url, payload))
 
@@ -210,7 +210,7 @@ class TestCmdlineUrl(unittest.TestCase):
         cmdline = "ro %s=%s bar=1" % (key, url)
 
         with mock.patch('cloudinit.url_helper.readurl',
-                        return_value=url_helper.StringResponse('')):
+                        return_value=url_helper.StringResponse(b'')):
             self.assertEqual(
                 util.get_cmdline_url(names=["does-not-appear"],
                                      starts="#cloud-config", cmdline=cmdline),