summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChad Smith <chad.smith@canonical.com>2022-02-07 07:46:16 -0700
committerGitHub <noreply@github.com>2022-02-07 08:46:16 -0600
commita804c108f51c806f1aa91a127433fcc3d8f8a78f (patch)
tree2a12f942e56c7374e87fd757cf635a9851e72ba6
parent826783d83f55b78336cdb9e16ea39a1038618b03 (diff)
downloadvyos-cloud-init-a804c108f51c806f1aa91a127433fcc3d8f8a78f.tar.gz
vyos-cloud-init-a804c108f51c806f1aa91a127433fcc3d8f8a78f.zip
tests: do not check instance.pull_file().ok() (#1246)
Test pycloudlib's BaseInstance.pull_file doesn't return a Result object. So we can't call ok() on the response in integration tests. Leave the try/except handling as pull_file will raise an IOError if there is an error connecting via paramiko's sftp.get.
-rw-r--r--tests/integration_tests/instances.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/integration_tests/instances.py b/tests/integration_tests/instances.py
index f30456fc..e26ee233 100644
--- a/tests/integration_tests/instances.py
+++ b/tests/integration_tests/instances.py
@@ -81,7 +81,7 @@ class IntegrationInstance:
# First copy to a temporary directory because of permissions issues
tmp_path = _get_tmp_path()
self.instance.execute("cp {} {}".format(str(remote_path), tmp_path))
- assert self.instance.pull_file(tmp_path, str(local_path)).ok
+ self.instance.pull_file(tmp_path, str(local_path))
def push_file(self, local_path, remote_path):
# First push to a temporary directory because of permissions issues